| Message ID | 20231004070309.2408745-1-andreas@kemnade.info |
|---|---|
| State | Accepted |
| Commit | 10dfde4bec529aa1d78e4b3acce7882a312880b7 |
| Headers | show |
| Series | [v2] ARM: dts: omap4-embt2ws: Add Bluetooth | expand |
Hi Tony, On Sat, 7 Oct 2023 10:24:42 +0300 Tony Lindgren <tony@atomide.com> wrote: > * Tony Lindgren <tony@atomide.com> [231007 07:00]: > > * Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> [231005 08:47]: > > > On 04/10/2023 09:03, Andreas Kemnade wrote: > > > > Since the required clock is now available, add bluetooth. > > > > > > > > Note: Firmware (bts file) from device vendor reroutes tx for some time > > > > during initialisation and later put it back, producing timeouts in > > > > bluetooth initialisation but ignoring that command leads to proper > > > > initialisation. > > > > > > > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info> > > > > --- > > > > > > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > > Applying into omap-for-v6.7/dt thanks. > > Looks like this causes the following #clock-cells warning so dropping > this patch. > > Regards, > > Tony > > arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts:457.17-462.4: Warning (clocks_property): > /ocp/interconnect@48000000/segment@0/target-module@6c000/serial@0/bluetooth-gnss: > Missing property '#clock-cells' in node /ocp/interconnect@48000000/segment@0/targe > I do not get this warning on top of omap-for-v6.8/dt. So I think the time is really there for this patch. Regards, Andreas
diff --git a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts index 46a80eacf771..6a790124bcf5 100644 --- a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts +++ b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts @@ -447,10 +447,12 @@ &uart2 { interrupts-extended = <&wakeupgen GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH &omap4_pmx_core OMAP4_UART2_RX>; - /* - * BT + GPS in WL1283 in WG7500 requiring CLK32KAUDIO of pmic - * which does not have a driver - */ + bluetooth-gnss { + compatible = "ti,wl1283-st"; + enable-gpios = <&gpio1 25 GPIO_ACTIVE_HIGH>; /* GPIO_25 */ + clocks = <&twl 1>; + clock-names = "ext_clock"; + }; }; &uart3 {
Since the required clock is now available, add bluetooth. Note: Firmware (bts file) from device vendor reroutes tx for some time during initialisation and later put it back, producing timeouts in bluetooth initialisation but ignoring that command leads to proper initialisation. Signed-off-by: Andreas Kemnade <andreas@kemnade.info> --- Depends on: https://lore.kernel.org/linux-omap/20230916100515.1650336-6-andreas@kemnade.info/T/#u Changes in V2: - more standard node name, removing unneeded label arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)