Message ID | 20231129100422.16659-1-quic_tengfan@quicinc.com |
---|---|
Headers | show |
Series | pinctrl: qcom: fix some sm4450 pinctrl issue | expand |
在 11/29/2023 9:21 PM, Konrad Dybcio 写道: > On 29.11.2023 11:04, Tengfei Fan wrote: >> Use .remove_new() instead of .remove() for converting to plarform remove > s/plarform/platform > >> callback returning void. >> >> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> >> --- > The commit title should include the platform name, i.e. > pinctrl: qcom: sm4450: xxx > > The change itself looks good > > Konrad Thanks Konrad review this patch, I will update patch as your comments.
Use .remove_new() instead of .remove() for converting to plarform remove callback returning void. Correct incorrect address offset which used by ufs and sdc. Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> --- "[PATCH v4 0/2] pinctl: qcom: Add SM4450 pinctrl driver" https://lore.kernel.org/linux-arm-msm/20230920082102.5744-1-quic_tengfan@quicinc.com/ Tengfei Fan (2): pinctrl: qcom: Convert to platform remove callback returning void pinctrl: qcom: correct incorrect address offset drivers/pinctrl/qcom/pinctrl-sm4450.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) base-commit: 1f5c003694fab4b1ba6cbdcc417488b975c088d0