| Message ID | 4-v1-720585788a7d+811b-iommu_fwspec_p1_jgg@nvidia.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | IOMMU related FW parsing cleanup | expand |
On 2023/11/29 8:48, Jason Gunthorpe wrote: > Allocation of dev->iommu must be done under the > iommu_probe_device_lock. Mark this with lockdep to discourage future > mistakes. > > Reviewed-by: Jerry Snitselaar<jsnitsel@redhat.com> > Tested-by: Hector Martin<marcan@marcan.st> > Signed-off-by: Jason Gunthorpe<jgg@nvidia.com> > --- > drivers/iommu/iommu.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com> Best regards, baolu
On Tue, Nov 28, 2023 at 08:48:00PM -0400, Jason Gunthorpe wrote: > Allocation of dev->iommu must be done under the > iommu_probe_device_lock. Mark this with lockdep to discourage future > mistakes. > Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com> > Tested-by: Hector Martin <marcan@marcan.st> > Signed-off-by: Jason Gunthorpe <jgg@nvidia.com> > --- > drivers/iommu/iommu.c | 2 ++ > 1 file changed, 2 insertions(+) > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c > index 0d25468d53a68a..4323b6276e977f 100644 > --- a/drivers/iommu/iommu.c > +++ b/drivers/iommu/iommu.c > @@ -334,6 +334,8 @@ static struct dev_iommu *dev_iommu_get(struct device > *dev) > { > struct dev_iommu *param = dev->iommu; > + lockdep_assert_held(&iommu_probe_device_lock); > + > if (param) > return param; > -- > 2.42.0 Reviewed-by: Moritz Fischer <moritzf@google.com> Cheers, Moritz
diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c index 0d25468d53a68a..4323b6276e977f 100644 --- a/drivers/iommu/iommu.c +++ b/drivers/iommu/iommu.c @@ -334,6 +334,8 @@ static struct dev_iommu *dev_iommu_get(struct device *dev) { struct dev_iommu *param = dev->iommu; + lockdep_assert_held(&iommu_probe_device_lock); + if (param) return param;