| Message ID | E1r0JKv-00CTwf-R9@rmk-PC.armlinux.org.uk |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [RFC,01/22] arch_topology: Make register_cpu_capacity_sysctl() tolerant to late CPUs | expand |
On 11/7/23 20:29, Russell King (Oracle) wrote: > arch_register_cpu() and arch_unregister_cpu() are not used by anything > that can be a module - they are used by drivers/base/cpu.c and > drivers/acpi/acpi_processor.c, neither of which can be a module. > > Remove the exports. > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > --- > arch/x86/kernel/topology.c | 2 -- > 1 file changed, 2 deletions(-) > Reviewed-by: Gavin Shan <gshan@redhat.com>
On Tue, 07 Nov 2023 10:29:33 +0000 "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk> wrote: > arch_register_cpu() and arch_unregister_cpu() are not used by anything > that can be a module - they are used by drivers/base/cpu.c and > drivers/acpi/acpi_processor.c, neither of which can be a module. > > Remove the exports. > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Would be 'novel' to have CPUs registered by a module. Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
diff --git a/arch/x86/kernel/topology.c b/arch/x86/kernel/topology.c index 0bab03130033..fcb62cfdf946 100644 --- a/arch/x86/kernel/topology.c +++ b/arch/x86/kernel/topology.c @@ -45,13 +45,11 @@ int arch_register_cpu(int cpu) xc->cpu.hotpluggable = cpu > 0; return register_cpu(&xc->cpu, cpu); } -EXPORT_SYMBOL(arch_register_cpu); void arch_unregister_cpu(int num) { unregister_cpu(&per_cpu(cpu_devices, num).cpu); } -EXPORT_SYMBOL(arch_unregister_cpu); #else /* CONFIG_HOTPLUG_CPU */ int __init arch_register_cpu(int num)
arch_register_cpu() and arch_unregister_cpu() are not used by anything that can be a module - they are used by drivers/base/cpu.c and drivers/acpi/acpi_processor.c, neither of which can be a module. Remove the exports. Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> --- arch/x86/kernel/topology.c | 2 -- 1 file changed, 2 deletions(-)