| Message ID | 20231117192305.17612-1-petre.rodan@subdimension.ro |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/2] dt-bindings: iio: pressure: add honeywell,hsc030 | expand |
On Fri, Nov 17, 2023 at 09:22:57PM +0200, Petre Rodan wrote: > Adds binding for digital Honeywell TruStability HSC and SSC series pressure > and temperature sensors. > > Datasheet: > [HSC] https://prod-edam.honeywell.com/content/dam/honeywell-edam/sps/siot/en-us/products/sensors/pressure-sensors/board-mount-pressure-sensors/trustability-hsc-series/documents/sps-siot-trustability-hsc-series-high-accuracy-board-mount-pressure-sensors-50099148-a-en-ciid-151133.pdf > [SSC] https://prod-edam.honeywell.com/content/dam/honeywell-edam/sps/siot/en-us/products/sensors/pressure-sensors/board-mount-pressure-sensors/trustability-ssc-series/documents/sps-siot-trustability-ssc-series-standard-accuracy-board-mount-pressure-sensors-50099533-a-en-ciid-151134.pdf > > Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro> > --- > > Changes for v2: > - Removed redundant quotations reported by robh's bot > - Fixed yamllint warnings > > I'm failing to run 'make DT_CHECKER_FLAGS=-m dt_binding_check' due to > python errors and exceptions What exceptions?
On Mon, 20 Nov 2023 20:25:08 +0200 Petre Rodan <petre.rodan@subdimension.ro> wrote: > Hello! > > On Mon, Nov 20, 2023 at 05:39:29PM +0000, Jonathan Cameron wrote: > > On Mon, 20 Nov 2023 16:40:51 +0200 > > Petre Rodan <petre.rodan@subdimension.ro> wrote: > > > > > Hello! > > > > > > On Mon, Nov 20, 2023 at 03:04:07PM +0100, Krzysztof Kozlowski wrote: > > > > On 20/11/2023 14:42, Petre Rodan wrote: > > > > > > > > >>> +properties: > > > > >>> + compatible: > > > > >>> + enum: > > > > >>> + - honeywell,hsc > > > > >> > > > > >> Way too generic > > > > > > > > > > I'm new to this, please excuse my ignorance. > > > > > my driver covers all Honeywell pressure sensors under the "TruStability board mount HSC/SSC" moniker. > > > > > > > > We talk here about bindings, not driver. For the driver you can use > > > > whatever name is approved by reviewers of your driver. > > > > > > > > > that is why my intention was to provide a rather generic name for the driver itself. > > > > > are you afraid that they will come up with a different device that they will call "hsc" in the future? > > > > > in this case honeywell,trustability-hsc would be fine? > > > > > > > > > > as I see you prefer to target a particular chip, but I am a bit afraid that the end-user will be confused by needing to set up something like > > > > > > > > > > pressure@28 { > > > > > compatible = "honeywell,hsc030pa"; > > > > > > > > The compatible should be specific, thus for example match exact model > > > > number. > > > > > > there are an infinite number of combinations of 4 transfer functions and 118 ranges + one custom range, so providing an array with all specific chips that could end up as compatible is out of the question. > > > I was aiming at providing a generic name for the binding and get the transfer function and the pressure range as required parameters. > > > > > > > If you can guarantee that all devices from given family are the same in > > > > respect of programming model and hardware requirements (e.g. supplies), > > > > then you could go with family name. However such guarantees are rarely > > > > given. > > > > > > I see your point. > > > > > > > Therefore for mprls0025pa I agreed for using one specific model > > > > for entire family. > > > > > > > > https://lore.kernel.org/all/d577bc44-780f-f25d-29c6-ed1d353b540c@linaro.org/ > > > > > > > > > > > > > reg = <0x28>; > > > > > honeywell,transfer-function = <0>; > > > > > honeywell,pressure-range = "250MD"; > > > > > }; > > > > > > > > > > ie. specifying "hsc030pa" as driver while his chip is not in the 030PA range, but 250MD. > > > > > > > > > > so do you prefer > > > > > honeywell,trustability-hsc OR > > > > > honeywell,hsc030pa > > > > > > > > I think the latter, just like we did for mprls0025pa. How many devices > > > > do you have there? > > > > > > both hsc and ssc have 118 ranges, 4 transfer functions and both can be requested from the manufacturer with custom measurement ranges. > > > > > > ok,I will rename hsc->hsc030pa in the code as you requested. > > > > Where does pa come from? > > honeywell,hsc030pa was provided as an equivalent to honeywell,mprls0025pa (which is already in the repo). > > '030PA' and '0025PA' define the pressure range (0-30, 0-25), the unit of measure (Psi) and the measurement type (Absolute) for a particular chip in the honeywell catalog. (please ignore the psi part, we convert everything to pascals). > but both my driver and Andreas Klinger's mprls0025pa actually provide a generic abstraction layer for entire series of sensors. ah ok. That's fine then - searching the datasheet I found didn't include that particular string, so I was rather confused. I'm fine with specific now you've explained where it came from! Jonathan > > > If we are going generic, feels like trustability-ssc etc are more representative > > and matches the datasheet cover page. > > Krzysztof voted for non-generic, honeywell,mprls0025pa is already set up non-generic, my intent was to go generic. > > I'll rewrite the code to whatever you guys feel is best. > > peter > >
diff --git a/Documentation/devicetree/bindings/iio/pressure/honeywell,hsc030pa.yaml b/Documentation/devicetree/bindings/iio/pressure/honeywell,hsc030pa.yaml new file mode 100644 index 000000000000..c7e5d3bd5ef4 --- /dev/null +++ b/Documentation/devicetree/bindings/iio/pressure/honeywell,hsc030pa.yaml @@ -0,0 +1,156 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/pressure/honeywell,hsc030pa.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Honeywell TruStability HSC and SSC pressure sensor families + +description: | + support for Honeywell TruStability HSC and SSC digital pressure sensor + families. + + These sensors have either an I2C, an SPI or an analog interface. Only the + digital versions are supported by this driver. + + There are 118 models with different pressure ranges available in each family. + The vendor calls them "HSC series" and "SSC series". All of them have an + identical programming model but differ in pressure range, unit and transfer + function. + + To support different models one need to specify the pressure range as well as + the transfer function. Pressure range can either be provided via range_str or + in case it's a custom chip via numerical range limits converted to pascals. + + The transfer function defines the ranges of raw conversion values delivered + by the sensor. pmin-pascal and pmax-pascal corespond to the minimum and + maximum pressure that can be measured. + + Specifications about the devices can be found at: + https://prod-edam.honeywell.com/content/dam/honeywell-edam/sps/siot/en-us/products/sensors/pressure-sensors/board-mount-pressure-sensors/trustability-hsc-series/documents/sps-siot-trustability-hsc-series-high-accuracy-board-mount-pressure-sensors-50099148-a-en-ciid-151133.pdf + https://prod-edam.honeywell.com/content/dam/honeywell-edam/sps/siot/en-us/products/sensors/pressure-sensors/board-mount-pressure-sensors/trustability-ssc-series/documents/sps-siot-trustability-ssc-series-standard-accuracy-board-mount-pressure-sensors-50099533-a-en-ciid-151134.pdf + +maintainers: + - Petre Rodan <petre.rodan@subdimension.ro> + +properties: + compatible: + enum: + - honeywell,hsc + - honeywell,ssc + + reg: + maxItems: 1 + + honeywell,transfer-function: + description: | + Transfer function which defines the range of valid values delivered by + the sensor. + 0 - A, 10% to 90% of 2^14 + 1 - B, 5% to 95% of 2^14 + 2 - C, 5% to 85% of 2^14 + 3 - F, 4% to 94% of 2^14 + $ref: /schemas/types.yaml#/definitions/uint32 + + honeywell,range_str: + description: | + Five character string that defines "pressure range, unit and type" + as part of the device nomenclature. In the unlikely case of a custom + chip, set to "NA" and provide honeywell,pmin-pascal honeywell,pmax-pascal + enum: [001BA, 1.6BA, 2.5BA, 004BA, 006BA, 010BA, 1.6MD, 2.5MD, 004MD, + 006MD, 010MD, 016MD, 025MD, 040MD, 060MD, 100MD, 160MD, 250MD, + 400MD, 600MD, 001BD, 1.6BD, 2.5BD, 004BD, 2.5MG, 004MG, 006MG, + 010MG, 016MG, 025MG, 040MG, 060MG, 100MG, 160MG, 250MG, 400MG, + 600MG, 001BG, 1.6BG, 2.5BG, 004BG, 006BG, 010BG, 100KA, 160KA, + 250KA, 400KA, 600KA, 001GA, 160LD, 250LD, 400LD, 600LD, 001KD, + 1.6KD, 2.5KD, 004KD, 006KD, 010KD, 016KD, 025KD, 040KD, 060KD, + 100KD, 160KD, 250KD, 400KD, 250LG, 400LG, 600LG, 001KG, 1.6KG, + 2.5KG, 004KG, 006KG, 010KG, 016KG, 025KG, 040KG, 060KG, 100KG, + 160KG, 250KG, 400KG, 600KG, 001GG, 015PA, 030PA, 060PA, 100PA, + 150PA, 0.5ND, 001ND, 002ND, 004ND, 005ND, 010ND, 020ND, 030ND, + 001PD, 005PD, 015PD, 030PD, 060PD, 001NG, 002NG, 004NG, 005NG, + 010NG, 020NG, 030NG, 001PG, 005PG, 015PG, 030PG, 060PG, 100PG, + 150PG, NA] + $ref: /schemas/types.yaml#/definitions/string + + honeywell,pmin-pascal: + description: | + Minimum pressure value the sensor can measure in pascal. + To be specified only if honeywell,range_str is set to "NA". + $ref: /schemas/types.yaml#/definitions/int32 + + honeywell,pmax-pascal: + description: | + Maximum pressure value the sensor can measure in pascal. + To be specified only if honeywell,range_str is set to "NA". + $ref: /schemas/types.yaml#/definitions/int32 + + vdd-supply: + description: | + Provide VDD power to the sensor (either 3.3V or 5V depending on the chip). + Optional, activate only if required by the target board. + + spi-max-frequency: + description: SPI clock to be kept between 50 and 800kHz + + clock-frequency: + description: i2c clock to be kept between 100 and 400kHz + +required: + - compatible + - reg + - honeywell,transfer-function + - honeywell,range_str + - clock-frequency + - spi-max-frequency + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + i2c { + status = "okay"; + clock-frequency = <400000>; + #address-cells = <1>; + #size-cells = <0>; + + HSCMRNN030PA2A3@28 { + status = "okay"; + compatible = "honeywell,hsc"; + reg = <0x28>; + + honeywell,transfer-function = <0>; + honeywell,range_str = "030PA"; + }; + }; + + spi { + # note that MOSI is not required by this sensor + status = "okay"; + #address-cells = <1>; + #size-cells = <0>; + + HSCMLNN100PASA3@0 { + status = "okay"; + compatible = "honeywell,hsc"; + reg = <0>; + spi-max-frequency = <800000>; + + honeywell,transfer-function = <0>; + honeywell,range_str = "100PA"; + }; + + HSC_CUSTOM_CHIP@0 { + status = "okay"; + compatible = "honeywell,hsc"; + reg = <1>; + spi-max-frequency = <800000>; + + honeywell,transfer-function = <0>; + honeywell,range_str = "NA"; + honeywell,pmin-pascal = <0>; + honeywell,pmax-pascal = <206850>; + }; + + };
Adds binding for digital Honeywell TruStability HSC and SSC series pressure and temperature sensors. Datasheet: [HSC] https://prod-edam.honeywell.com/content/dam/honeywell-edam/sps/siot/en-us/products/sensors/pressure-sensors/board-mount-pressure-sensors/trustability-hsc-series/documents/sps-siot-trustability-hsc-series-high-accuracy-board-mount-pressure-sensors-50099148-a-en-ciid-151133.pdf [SSC] https://prod-edam.honeywell.com/content/dam/honeywell-edam/sps/siot/en-us/products/sensors/pressure-sensors/board-mount-pressure-sensors/trustability-ssc-series/documents/sps-siot-trustability-ssc-series-standard-accuracy-board-mount-pressure-sensors-50099533-a-en-ciid-151134.pdf Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro> --- Changes for v2: - Removed redundant quotations reported by robh's bot - Fixed yamllint warnings I'm failing to run 'make DT_CHECKER_FLAGS=-m dt_binding_check' due to python errors and exceptions --- .../iio/pressure/honeywell,hsc030pa.yaml | 156 ++++++++++++++++++ 1 file changed, 156 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/pressure/honeywell,hsc030pa.yaml