| Message ID | 20231117112833.v2.1.I4c7ab22148e168e3cde00f27b89748ff4bc651c2@changeid |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/2] Bluetooth: btusb: Return when coredump trigger cmd fails | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=802039 ---Test result--- Test Summary: CheckPatch PASS 1.25 seconds GitLint PASS 0.63 seconds SubjectPrefix PASS 0.27 seconds BuildKernel PASS 27.85 seconds CheckAllWarning PASS 30.67 seconds CheckSparse PASS 36.17 seconds CheckSmatch PASS 99.43 seconds BuildKernel32 PASS 27.06 seconds TestRunnerSetup PASS 418.24 seconds TestRunner_l2cap-tester PASS 22.99 seconds TestRunner_iso-tester PASS 40.48 seconds TestRunner_bnep-tester PASS 7.39 seconds TestRunner_mgmt-tester PASS 166.09 seconds TestRunner_rfcomm-tester PASS 11.09 seconds TestRunner_sco-tester PASS 14.54 seconds TestRunner_ioctl-tester PASS 12.09 seconds TestRunner_mesh-tester PASS 8.94 seconds TestRunner_smp-tester PASS 9.73 seconds TestRunner_userchan-tester PASS 7.33 seconds IncrementalBuild PASS 31.82 seconds --- Regards, Linux Bluetooth
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index b8e9de887b5d..35a26440cabd 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -3463,8 +3463,11 @@ static void btusb_coredump_qca(struct hci_dev *hdev) struct sk_buff *skb; skb = __hci_cmd_sync(hdev, 0xfc0c, 1, param, HCI_CMD_TIMEOUT); - if (IS_ERR(skb)) - bt_dev_err(hdev, "%s: triggle crash failed (%ld)", __func__, PTR_ERR(skb)); + if (IS_ERR(skb)) { + bt_dev_err(hdev, "%s: trigger crash failed (%ld)", __func__, PTR_ERR(skb)); + return; + } + kfree_skb(skb); }
Avoid freeing NULL skb when hci command fails. Fixes: 20981ce2d5a5 ("Bluetooth: btusb: Add WCN6855 devcoredump support") Signed-off-by: Manish Mandlik <mmandlik@google.com> --- Changes in v2: - Fixed a typo in error log in btusb_coredump_qca() drivers/bluetooth/btusb.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)