| Message ID | 20231117193135.1180657-1-richard.henderson@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [for-8.2] target/arm: Fix SME FMOPA (16-bit), BFMOPA | expand |
On 17/11/23 20:31, Richard Henderson wrote: > Perform the loop increment unconditionally, not nested > within the predication. > > Cc: qemu-stable@nongnu.org > Fixes: 3916841ac75 ("target/arm: Implement FMOPA, FMOPS (widening)") > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1985 > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > target/arm/tcg/sme_helper.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
On Fri, 17 Nov 2023 at 19:32, Richard Henderson <richard.henderson@linaro.org> wrote: > > Perform the loop increment unconditionally, not nested > within the predication. > > Cc: qemu-stable@nongnu.org > Fixes: 3916841ac75 ("target/arm: Implement FMOPA, FMOPS (widening)") > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1985 > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> Applied to target-arm.next, thanks. -- PMM
diff --git a/target/arm/tcg/sme_helper.c b/target/arm/tcg/sme_helper.c index 296826ffe6..1ee2690ceb 100644 --- a/target/arm/tcg/sme_helper.c +++ b/target/arm/tcg/sme_helper.c @@ -1037,10 +1037,9 @@ void HELPER(sme_fmopa_h)(void *vza, void *vzn, void *vzm, void *vpn, m = f16mop_adj_pair(m, pcol, 0); *a = f16_dotadd(*a, n, m, &fpst_std, &fpst_odd); - - col += 4; - pcol >>= 4; } + col += 4; + pcol >>= 4; } while (col & 15); } row += 4; @@ -1073,10 +1072,9 @@ void HELPER(sme_bfmopa)(void *vza, void *vzn, void *vzm, void *vpn, m = f16mop_adj_pair(m, pcol, 0); *a = bfdotadd(*a, n, m); - - col += 4; - pcol >>= 4; } + col += 4; + pcol >>= 4; } while (col & 15); } row += 4;
Perform the loop increment unconditionally, not nested within the predication. Cc: qemu-stable@nongnu.org Fixes: 3916841ac75 ("target/arm: Implement FMOPA, FMOPS (widening)") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1985 Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- target/arm/tcg/sme_helper.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)