| Message ID | 20231031135949.1064581-3-Syed.SabaKareem@amd.com |
|---|---|
| State | Accepted |
| Commit | ed2232d49187cebc007ecf4e6374069b11ab3219 |
| Headers | show |
| Series | [1/3] ASoC: amd: acp: Fix for indentation issue | expand |
On Tue, Oct 31, 2023 at 07:29:34PM +0530, Syed Saba Kareem wrote: > I2S mode register field will be set to 1 when tdm mode is enabled. > Update the I2S mode field based on tdm_mode flag check. > > This will fix below smatch checker warning. > > sound/soc/amd/acp/acp-i2s.c:59 acp_set_i2s_clk() > warn: odd binop '0x0 & 0x2' > > Fixes: 40f74d5f09d7 ("ASoC: amd: acp: refactor acp i2s clock > generation code") I saw this yesterday but didn't comment because I didn't want you to have to redo the patch. Mark, of course, also saw it and didn't ask you to redo it. And now it's applied. But for the future, these Fixes tags should be on one line and in the tags section of the commit message. (It's in chronological order). Fixes: 40f74d5f09d7 ("ASoC: amd: acp: refactor acp i2s clock generation code") Reported-By: Dan Carpenter <dan.carpenter@linaro.org> Signed-off-by: Syed Saba Kareem <Syed.SabaKareem@amd.com> Signed-off-by: Mark Brown regards, dan carpenter
diff --git a/sound/soc/amd/acp/acp-i2s.c b/sound/soc/amd/acp/acp-i2s.c index 1185e5aac523..60cbc881be6e 100644 --- a/sound/soc/amd/acp/acp-i2s.c +++ b/sound/soc/amd/acp/acp-i2s.c @@ -26,7 +26,6 @@ #define DRV_NAME "acp_i2s_playcap" #define I2S_MASTER_MODE_ENABLE 1 -#define I2S_MODE_ENABLE 0 #define LRCLK_DIV_FIELD GENMASK(10, 2) #define BCLK_DIV_FIELD GENMASK(23, 11) #define ACP63_LRCLK_DIV_FIELD GENMASK(12, 2) @@ -56,7 +55,8 @@ static inline void acp_set_i2s_clk(struct acp_dev_data *adata, int dai_id) } val = I2S_MASTER_MODE_ENABLE; - val |= I2S_MODE_ENABLE & BIT(1); + if (adata->tdm_mode) + val |= BIT(1); switch (chip->acp_rev) { case ACP63_DEV:
I2S mode register field will be set to 1 when tdm mode is enabled. Update the I2S mode field based on tdm_mode flag check. This will fix below smatch checker warning. sound/soc/amd/acp/acp-i2s.c:59 acp_set_i2s_clk() warn: odd binop '0x0 & 0x2' Fixes: 40f74d5f09d7 ("ASoC: amd: acp: refactor acp i2s clock generation code") Reported-By: Dan Carpenter <dan.carpenter@linaro.org> Signed-off-by: Syed Saba Kareem <Syed.SabaKareem@amd.com> --- sound/soc/amd/acp/acp-i2s.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)