| Message ID | 20231029111807.19261-2-balejk@matfyz.cz |
|---|---|
| State | New |
| Headers | show |
| Series | net: mwifiex: add support for the SD8777 chipset | expand |
On 29/10/2023 12:08, Karel Balej wrote: > Document the corresponding compatible string for the use of this driver > with the Marvell SD8777 wireless chipset. > > Signed-off-by: Karel Balej <balejk@matfyz.cz> > --- Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- This is an automated instruction, just in case, because many review tags are being ignored. If you know the process, you can skip it (please do not feel offended by me posting it here - no bad intentions intended). If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 Best regards, Krzysztof
On Sun, Oct 29, 2023 at 12:08:16PM +0100, Karel Balej wrote: > Document the corresponding compatible string for the use of this driver > with the Marvell SD8777 wireless chipset. > > Signed-off-by: Karel Balej <balejk@matfyz.cz> FWIW, the binding looks fine from mwifiex point of view, so: Acked-by: Brian Norris <briannorris@chromium.org> But see cover letter. We can't merge driver support without a linux-firmware-compatible (or otherwise redistributable) firmware, so NAK for the series.
diff --git a/Documentation/devicetree/bindings/net/wireless/marvell-8xxx.txt b/Documentation/devicetree/bindings/net/wireless/marvell-8xxx.txt index cdc303caf5f4..4f374ea029ed 100644 --- a/Documentation/devicetree/bindings/net/wireless/marvell-8xxx.txt +++ b/Documentation/devicetree/bindings/net/wireless/marvell-8xxx.txt @@ -1,4 +1,4 @@ -Marvell 8787/8897/8978/8997 (sd8787/sd8897/sd8978/sd8997/pcie8997) SDIO/PCIE devices +Marvell 8777/8787/8897/8978/8997 (sd8777/sd8787/sd8897/sd8978/sd8997/pcie8997) SDIO/PCIE devices ------ This node provides properties for controlling the Marvell SDIO/PCIE wireless device. @@ -8,6 +8,7 @@ connects the device to the system. Required properties: - compatible : should be one of the following: + * "marvell,sd8777" * "marvell,sd8787" * "marvell,sd8897" * "marvell,sd8978"
Document the corresponding compatible string for the use of this driver with the Marvell SD8777 wireless chipset. Signed-off-by: Karel Balej <balejk@matfyz.cz> --- .../devicetree/bindings/net/wireless/marvell-8xxx.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)