| Message ID | 20231027-aspire1-sound-v1-1-5ff3cf8b5701@trvn.ru |
|---|---|
| State | Accepted |
| Commit | 04fe8f0a68a346048f2432380a74a5e393d59a4c |
| Headers | show |
| Series | [1/3] arm64: dts: qcom: acer-aspire1: Enable RTC | expand |
On 27.10.2023 16:42, Nikita Travkin wrote: > pm6150 has a read-only RTC that can be used to keep the time with some > extra userspace tools. Enable it. > > Signed-off-by: Nikita Travkin <nikita@trvn.ru> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> kinda unsure why it'd ever be disabled Konrad
Hi, On Mon, Oct 30, 2023 at 2:47 PM Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > > On 27.10.2023 16:42, Nikita Travkin wrote: > > pm6150 has a read-only RTC that can be used to keep the time with some > > extra userspace tools. Enable it. > > > > Signed-off-by: Nikita Travkin <nikita@trvn.ru> > > --- > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> > > kinda unsure why it'd ever be disabled > > Konrad FWIW we don't use the PMIC RTC in Chrome boards. I can't quite remember why, but I _think_ that the power lines aren't hooked up to the PMIC to keep power on for the board's lowest power states. Instead we use the RTC that's on the EC (Embedded Controller). -Doug
Doug Anderson писал(а) 31.10.2023 02:55: > Hi, > > On Mon, Oct 30, 2023 at 2:47 PM Konrad Dybcio <konrad.dybcio@linaro.org> wrote: >> >> On 27.10.2023 16:42, Nikita Travkin wrote: >> > pm6150 has a read-only RTC that can be used to keep the time with some >> > extra userspace tools. Enable it. >> > >> > Signed-off-by: Nikita Travkin <nikita@trvn.ru> >> > --- >> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> >> >> kinda unsure why it'd ever be disabled >> >> Konrad > > FWIW we don't use the PMIC RTC in Chrome boards. I can't quite > remember why, but I _think_ that the power lines aren't hooked up to > the PMIC to keep power on for the board's lowest power states. > Instead we use the RTC that's on the EC (Embedded Controller). > When it was submitted, I suggested to keep it disabled by default because of the firmware mess qcom has - the rtc is set to read-only and if one enables it on cros without allow-set-time; and validating that qtiseclib doesn't block it too, it would likely cause issues by taking devices back to 1970s :D Nikita > -Doug
diff --git a/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts b/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts index dbb48934d499..cfde8cd47107 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts +++ b/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts @@ -351,6 +351,10 @@ &pm6150_pon { status = "disabled"; }; +&pm6150_rtc { + status = "okay"; +}; + &qupv3_id_0 { status = "okay"; };
pm6150 has a read-only RTC that can be used to keep the time with some extra userspace tools. Enable it. Signed-off-by: Nikita Travkin <nikita@trvn.ru> --- arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts | 4 ++++ 1 file changed, 4 insertions(+)