| Message ID | 20231030-arm-psci-system_reset2-vendor-reboots-v1-1-dcdd63352ad1@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | Implement vendor resets for PSCI SYSTEM_RESET2 | expand |
On Mon, Oct 30, 2023 at 02:31:33PM -0700, Elliot Berman wrote: > Add bindings to describe vendor-specific reboot modes. Values here > correspond to valid parameters to vendor-specific reset types in PSCI > SYSTEM_RESET2 call. > > Signed-off-by: Elliot Berman <quic_eberman@quicinc.com> > --- > Documentation/devicetree/bindings/arm/psci.yaml | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/psci.yaml b/Documentation/devicetree/bindings/arm/psci.yaml > index 0c5381e081bd..dc23e901bd0a 100644 > --- a/Documentation/devicetree/bindings/arm/psci.yaml > +++ b/Documentation/devicetree/bindings/arm/psci.yaml > @@ -122,6 +122,19 @@ patternProperties: > [3] Documentation/devicetree/bindings/power/power-domain.yaml > [4] Documentation/devicetree/bindings/power/domain-idle-state.yaml > > + "^reboot-mode-.*$": > + $ref: /schemas/types.yaml#/definitions/uint32-array > + minItems: 1 > + maxItems: 2 > + description: | > + Describes a vendor-specific reset type. The string after "reboot-mode-" > + maps a reboot mode to the parameters in the PSCI SYSTEM_RESET2 call. > + > + Parameters are named reboot-mode-xxx = <type[, cookie]>, where xxx > + is the name of the magic reboot mode, type is the lower 31 bits > + of the reset_type, and, optionally, the cookie value. If the cookie > + is not provided, it is defaulted to zero. Please use and possibly extend the existing reboot-mode binding. > + > required: > - compatible > - method > > -- > 2.41.0 >
On 10/31/2023 10:48 AM, Rob Herring wrote: > On Mon, Oct 30, 2023 at 02:31:33PM -0700, Elliot Berman wrote: >> Add bindings to describe vendor-specific reboot modes. Values here >> correspond to valid parameters to vendor-specific reset types in PSCI >> SYSTEM_RESET2 call. >> >> Signed-off-by: Elliot Berman <quic_eberman@quicinc.com> >> --- >> Documentation/devicetree/bindings/arm/psci.yaml | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/psci.yaml b/Documentation/devicetree/bindings/arm/psci.yaml >> index 0c5381e081bd..dc23e901bd0a 100644 >> --- a/Documentation/devicetree/bindings/arm/psci.yaml >> +++ b/Documentation/devicetree/bindings/arm/psci.yaml >> @@ -122,6 +122,19 @@ patternProperties: >> [3] Documentation/devicetree/bindings/power/power-domain.yaml >> [4] Documentation/devicetree/bindings/power/domain-idle-state.yaml >> >> + "^reboot-mode-.*$": >> + $ref: /schemas/types.yaml#/definitions/uint32-array >> + minItems: 1 >> + maxItems: 2 >> + description: | >> + Describes a vendor-specific reset type. The string after "reboot-mode-" >> + maps a reboot mode to the parameters in the PSCI SYSTEM_RESET2 call. >> + >> + Parameters are named reboot-mode-xxx = <type[, cookie]>, where xxx >> + is the name of the magic reboot mode, type is the lower 31 bits >> + of the reset_type, and, optionally, the cookie value. If the cookie >> + is not provided, it is defaulted to zero. > > Please use and possibly extend the existing reboot-mode binding. > Sure, I can do that. I noticed most of the reboot-mode devices not doing that, but they probably should. I've sent patches to fix that: https://lore.kernel.org/all/20231031-ref-reboot-mode-v1-1-18dde4faf7e8@quicinc.com/ https://lore.kernel.org/all/20231031-ref-nvmem-reboot-mode-v1-1-c1af9070ce52@quicinc.com/ >> + >> required: >> - compatible >> - method >> >> -- >> 2.41.0 >>
diff --git a/Documentation/devicetree/bindings/arm/psci.yaml b/Documentation/devicetree/bindings/arm/psci.yaml index 0c5381e081bd..dc23e901bd0a 100644 --- a/Documentation/devicetree/bindings/arm/psci.yaml +++ b/Documentation/devicetree/bindings/arm/psci.yaml @@ -122,6 +122,19 @@ patternProperties: [3] Documentation/devicetree/bindings/power/power-domain.yaml [4] Documentation/devicetree/bindings/power/domain-idle-state.yaml + "^reboot-mode-.*$": + $ref: /schemas/types.yaml#/definitions/uint32-array + minItems: 1 + maxItems: 2 + description: | + Describes a vendor-specific reset type. The string after "reboot-mode-" + maps a reboot mode to the parameters in the PSCI SYSTEM_RESET2 call. + + Parameters are named reboot-mode-xxx = <type[, cookie]>, where xxx + is the name of the magic reboot mode, type is the lower 31 bits + of the reset_type, and, optionally, the cookie value. If the cookie + is not provided, it is defaulted to zero. + required: - compatible - method
Add bindings to describe vendor-specific reboot modes. Values here correspond to valid parameters to vendor-specific reset types in PSCI SYSTEM_RESET2 call. Signed-off-by: Elliot Berman <quic_eberman@quicinc.com> --- Documentation/devicetree/bindings/arm/psci.yaml | 13 +++++++++++++ 1 file changed, 13 insertions(+)