diff mbox series

[1/8] dt-bindings: input: fsl,scu-key: Document wakeup-source

Message ID 20230926122957.341094-1-festevam@gmail.com
State New
Headers show
Series [1/8] dt-bindings: input: fsl,scu-key: Document wakeup-source | expand

Commit Message

Fabio Estevam Sept. 26, 2023, 12:29 p.m. UTC 
From: Fabio Estevam <festevam@denx.de>

The SCU Key controller can be used as a system wakeup source.

Document the 'wakeup-source' property.

This fixes the following schema warning:

system-controller: keys: 'wakeup-source' does not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/firmware/fsl,scu.yaml#

Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 Documentation/devicetree/bindings/input/fsl,scu-key.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Rob Herring (Arm) Sept. 28, 2023, 4:47 p.m. UTC | #1 
On Tue, 26 Sep 2023 09:29:50 -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> The SCU Key controller can be used as a system wakeup source.
> 
> Document the 'wakeup-source' property.
> 
> This fixes the following schema warning:
> 
> system-controller: keys: 'wakeup-source' does not match any of the regexes: 'pinctrl-[0-9]+'
> 	from schema $id: http://devicetree.org/schemas/firmware/fsl,scu.yaml#
> 
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  Documentation/devicetree/bindings/input/fsl,scu-key.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>
Shawn Guo Oct. 10, 2023, 1:05 a.m. UTC | #2 
On Tue, Sep 26, 2023 at 09:29:52AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Pass 'fsl,imx8dl-scu-pd' to fix the following schema warning:
> 
> system-controller: power-controller:compatible:0: 'fsl,scu-pd' is not one of ['fsl,imx8qm-scu-pd', 'fsl,imx8qxp-scu-pd']
> 	from schema $id: http://devicetree.org/schemas/firmware/fsl,scu.yaml#
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied all 4 dts changes, thanks!
Fabio Estevam Oct. 25, 2023, 8:07 p.m. UTC | #3 
Hi Dmitry,

On Thu, Sep 28, 2023 at 1:48 PM Rob Herring <robh@kernel.org> wrote:
>
>
> On Tue, 26 Sep 2023 09:29:50 -0300, Fabio Estevam wrote:
> > From: Fabio Estevam <festevam@denx.de>
> >
> > The SCU Key controller can be used as a system wakeup source.
> >
> > Document the 'wakeup-source' property.
> >
> > This fixes the following schema warning:
> >
> > system-controller: keys: 'wakeup-source' does not match any of the regexes: 'pinctrl-[0-9]+'
> >       from schema $id: http://devicetree.org/schemas/firmware/fsl,scu.yaml#
> >
> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > Signed-off-by: Fabio Estevam <festevam@denx.de>
> > ---
> >  Documentation/devicetree/bindings/input/fsl,scu-key.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> >
>
> Acked-by: Rob Herring <robh@kernel.org>

Could you please take this one?
Dmitry Torokhov Oct. 29, 2023, 1:51 a.m. UTC | #4 
Hi Fabio,

On Wed, Oct 25, 2023 at 05:07:39PM -0300, Fabio Estevam wrote:
> Hi Dmitry,
> 
> On Thu, Sep 28, 2023 at 1:48 PM Rob Herring <robh@kernel.org> wrote:
> >
> >
> > On Tue, 26 Sep 2023 09:29:50 -0300, Fabio Estevam wrote:
> > > From: Fabio Estevam <festevam@denx.de>
> > >
> > > The SCU Key controller can be used as a system wakeup source.
> > >
> > > Document the 'wakeup-source' property.
> > >
> > > This fixes the following schema warning:
> > >
> > > system-controller: keys: 'wakeup-source' does not match any of the regexes: 'pinctrl-[0-9]+'
> > >       from schema $id: http://devicetree.org/schemas/firmware/fsl,scu.yaml#
> > >
> > > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > > Signed-off-by: Fabio Estevam <festevam@denx.de>
> > > ---
> > >  Documentation/devicetree/bindings/input/fsl,scu-key.yaml | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> >
> > Acked-by: Rob Herring <robh@kernel.org>
> 
> Could you please take this one?

Applied, thank you.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/input/fsl,scu-key.yaml b/Documentation/devicetree/bindings/input/fsl,scu-key.yaml
index e5a3c355ee1f..29921aab9d97 100644
--- a/Documentation/devicetree/bindings/input/fsl,scu-key.yaml
+++ b/Documentation/devicetree/bindings/input/fsl,scu-key.yaml
@@ -24,6 +24,8 @@  properties:
   linux,keycodes:
     maxItems: 1
 
+  wakeup-source: true
+
 required:
   - compatible
   - linux,keycodes