| Message ID | 20231018235944.1860717-1-markhas@chromium.org |
|---|---|
| State | Accepted |
| Commit | 7c05b44e1a50d9cbfc4f731dddc436a24ddc129a |
| Headers | show |
| Series | [v1] ALSA: hda: intel-dsp-config: Fix JSL Chromebook quirk detection | expand |
> I would assume that platform that has DMI_SYS_VENDOR set to "Google", > also has DMI_BIOS_VERSION set to "Google", so perhaps just replace > DMI_SYS_VENDOR match with DMI_BIOS_VERSION, to keep table small? Or is > that not a case? That is the case. But I'm inclined to keep it for two reasons: 1. There is precedent in the kernel to use DMI_SYS_VENDOR=="Google" for Chromebook detection. 2. If the coreboot version schema for Chromebooks were to change, this check would fail for all JSL Chromebooks instead of just a few models.
> FWIW we use this other quirk: > DMI_MATCH(DMI_PRODUCT_FAMILY, "Google"), Unfortunately DMI_PRODUCT_FAMILY is empty on these particular devices. The coreboot version field is the only entry that has "Google" in it. > How many engineers does it take to identify a Chromebook, eh? Ha! There has been some discussion about this: to come up with a canonical way for Chromebook identification throughout the kernel. But nothing has been settled on AFAIK.
On Thu, 19 Oct 2023 01:59:31 +0200, Mark Hasemeyer wrote: > > Some Jasperlake Chromebooks overwrite the system vendor DMI value to the > name of the OEM that manufactured the device. This breaks Chromebook > quirk detection as it expects the system vendor to be "Google". > > Add another quirk detection entry that looks for "Google" in the BIOS > version. > > Cc: stable@vger.kernel.org > Signed-off-by: Mark Hasemeyer <markhas@chromium.org> Applied now. Thanks. Takashi
diff --git a/sound/hda/intel-dsp-config.c b/sound/hda/intel-dsp-config.c index 24a948baf1bc..756fa0aa69bb 100644 --- a/sound/hda/intel-dsp-config.c +++ b/sound/hda/intel-dsp-config.c @@ -336,6 +336,12 @@ static const struct config_entry config_table[] = { DMI_MATCH(DMI_SYS_VENDOR, "Google"), } }, + { + .ident = "Google firmware", + .matches = { + DMI_MATCH(DMI_BIOS_VERSION, "Google"), + } + }, {} } },
Some Jasperlake Chromebooks overwrite the system vendor DMI value to the name of the OEM that manufactured the device. This breaks Chromebook quirk detection as it expects the system vendor to be "Google". Add another quirk detection entry that looks for "Google" in the BIOS version. Cc: stable@vger.kernel.org Signed-off-by: Mark Hasemeyer <markhas@chromium.org> --- sound/hda/intel-dsp-config.c | 6 ++++++ 1 file changed, 6 insertions(+)