diff mbox series

[v1] thermal: ACPI: Include the right header file

Message ID 2721589.mvXUDI8C0e@kreacher
State New
Headers show
Series [v1] thermal: ACPI: Include the right header file | expand

Commit Message

Rafael J. Wysocki Oct. 13, 2023, 3:14 p.m. UTC 
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

It is not necessary to include thermal_core.h into thermal_acpi.c,
because none of the code in there depends on anything in the former,
except for the linux/thermal.h, but it is better to include that one
directly instead of including the entire thermal_core.h, so make that
change.

No functional impact.

Fixes: 7a0e39748861 ("thermal: ACPI: Add ACPI trip point routines")
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 drivers/thermal/thermal_acpi.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Daniel Lezcano Oct. 13, 2023, 3:25 p.m. UTC | #1 
On 13/10/2023 17:14, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> It is not necessary to include thermal_core.h into thermal_acpi.c,
> because none of the code in there depends on anything in the former,
> except for the linux/thermal.h, but it is better to include that one
> directly instead of including the entire thermal_core.h, so make that
> change.
> 
> No functional impact.
> 
> Fixes: 7a0e39748861 ("thermal: ACPI: Add ACPI trip point routines")
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---

Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
diff mbox series

Patch

Index: linux-pm/drivers/thermal/thermal_acpi.c
===================================================================
--- linux-pm.orig/drivers/thermal/thermal_acpi.c
+++ linux-pm/drivers/thermal/thermal_acpi.c
@@ -8,8 +8,7 @@ 
  */
 #include <linux/acpi.h>
 #include <linux/units.h>
-
-#include "thermal_core.h"
+#include <linux/thermal.h>
 
 /*
  * Minimum temperature for full military grade is 218°K (-55°C) and