mbox series

[net,v2,0/4] selftests: openvswitch: Minor fixes for some systems

Message ID 20231011194939.704565-1-aconole@redhat.com
Headers show
Series selftests: openvswitch: Minor fixes for some systems | expand

Message

Aaron Conole Oct. 11, 2023, 7:49 p.m. UTC
A number of corner cases were caught when trying to run the selftests on
older systems.  Missed skip conditions, some error cases, and outdated
python setups would all report failures but the issue would actually be
related to some other condition rather than the selftest suite.

Address these individual cases.

Aaron Conole (4):
  selftests: openvswitch: Add version check for pyroute2
  selftests: openvswitch: Catch cases where the tests are killed
  selftests: openvswitch: Skip drop testing on older kernels
  selftests: openvswitch: Fix the ct_tuple for v4

 .../selftests/net/openvswitch/openvswitch.sh  | 21 +++++++-
 .../selftests/net/openvswitch/ovs-dpctl.py    | 48 ++++++++++++++++++-
 2 files changed, 66 insertions(+), 3 deletions(-)

Comments

Simon Horman Oct. 13, 2023, 8:06 p.m. UTC | #1
On Wed, Oct 11, 2023 at 03:49:35PM -0400, Aaron Conole wrote:
> A number of corner cases were caught when trying to run the selftests on
> older systems.  Missed skip conditions, some error cases, and outdated
> python setups would all report failures but the issue would actually be
> related to some other condition rather than the selftest suite.
> 
> Address these individual cases.
> 
> Aaron Conole (4):
>   selftests: openvswitch: Add version check for pyroute2
>   selftests: openvswitch: Catch cases where the tests are killed
>   selftests: openvswitch: Skip drop testing on older kernels
>   selftests: openvswitch: Fix the ct_tuple for v4
> 
>  .../selftests/net/openvswitch/openvswitch.sh  | 21 +++++++-
>  .../selftests/net/openvswitch/ovs-dpctl.py    | 48 ++++++++++++++++++-
>  2 files changed, 66 insertions(+), 3 deletions(-)

Thanks Aaron,

this looks like a good incremental improvement to me.

For series,

Reviewed-by: Simon Horman <horms@kernel.org>
patchwork-bot+netdevbpf@kernel.org Oct. 15, 2023, 7:10 p.m. UTC | #2
Hello:

This series was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:

On Wed, 11 Oct 2023 15:49:35 -0400 you wrote:
> A number of corner cases were caught when trying to run the selftests on
> older systems.  Missed skip conditions, some error cases, and outdated
> python setups would all report failures but the issue would actually be
> related to some other condition rather than the selftest suite.
> 
> Address these individual cases.
> 
> [...]

Here is the summary with links:
  - [net,v2,1/4] selftests: openvswitch: Add version check for pyroute2
    https://git.kernel.org/netdev/net/c/92e37f20f20a
  - [net,v2,2/4] selftests: openvswitch: Catch cases where the tests are killed
    https://git.kernel.org/netdev/net/c/af846afad5ca
  - [net,v2,3/4] selftests: openvswitch: Skip drop testing on older kernels
    https://git.kernel.org/netdev/net/c/76035fd12cb9
  - [net,v2,4/4] selftests: openvswitch: Fix the ct_tuple for v4
    https://git.kernel.org/netdev/net/c/8eff0e062201

You are awesome, thank you!