Message ID | 20231010133738.35274-1-sarah.walker@imgtec.com |
---|---|
Headers | show |
Series | Imagination Technologies PowerVR DRM driver | expand |
Hi Danilo, Thanks for the feedback. The change has been made and will be in the next version. Thanks, Donald On Tue, 2023-10-10 at 18:31 +0200, Danilo Krummrich wrote: > *** CAUTION: This email originates from a source not known to Imagination Technologies. Think before you click a link or open an attachment *** > > On 10/10/23 15:37, Sarah Walker wrote: > > From: Donald Robson <donald.robson@imgtec.com> > > > > Determining the start and range of the unmap stage of a remap op is a > > common piece of code currently implemented by multiple drivers. Add a > > helper for this. > > > > Changes since v6: > > - Remove use of __always_inline > > > > Signed-off-by: Donald Robson <donald.robson@imgtec.com> > > Signed-off-by: Sarah Walker <sarah.walker@imgtec.com> > > --- > > include/drm/drm_gpuvm.h | 27 +++++++++++++++++++++++++++ > > 1 file changed, 27 insertions(+) > > > > diff --git a/include/drm/drm_gpuvm.h b/include/drm/drm_gpuvm.h > > index c7ed6bf441d4..932e942da921 100644 > > --- a/include/drm/drm_gpuvm.h > > +++ b/include/drm/drm_gpuvm.h > > @@ -702,4 +702,31 @@ void drm_gpuva_remap(struct drm_gpuva *prev, > > > > void drm_gpuva_unmap(struct drm_gpuva_op_unmap *op); > > > > +/** > > + * drm_gpuva_op_remap_get_unmap_range() - Helper to get the start and range of > > Not a strong opinion on that, but maybe drm_gpuva_op_remap_to_unmap_range() would > be a bit better. > > > + * the unmap stage of a remap op. > > + * @op: Remap op. > > + * @start_addr: Output pointer for the start of the required unmap. > > + * @range: Output pointer for the length of the required unmap. > > + * > > + * These parameters can then be used by the caller to unmap memory pages that > > + * are no longer required. > > I think we should be a bit more precise on what this is good for. Maybe something > like: "The given start address and range will be set such that they represent the > range of the address space that was previously covered by the mapping getting > re-mapped, but is empty now." > > > + */ > > +static inline void > > +drm_gpuva_op_remap_get_unmap_range(const struct drm_gpuva_op_remap *op, > > + u64 *start_addr, u64 *range) > > +{ > > + const u64 va_start = op->prev ? > > + op->prev->va.addr + op->prev->va.range : > > + op->unmap->va->va.addr; > > + const u64 va_end = op->next ? > > + op->next->va.addr : > > + op->unmap->va->va.addr + op->unmap->va->va.range; > > + > > + if (start_addr) > > + *start_addr = va_start; > > + if (range) > > + *range = va_end - va_start; > > +} > > + > > #endif /* __DRM_GPUVM_H__ */
On 10.10.2023 16:37, Sarah Walker wrote: > This patch series adds the initial DRM driver for Imagination Technologies PowerVR > GPUs, starting with those based on our Rogue architecture. It's worth pointing > out that this is a new driver, written from the ground up, rather than a > refactored version of our existing downstream driver (pvrsrvkm). > > This new DRM driver supports: > - GEM shmem allocations > - dma-buf / PRIME > - Per-context userspace managed virtual address space > - DRM sync objects (binary and timeline) > - Power management suspend / resume > - GPU job submission (geometry, fragment, compute, transfer) > - META firmware processor > - MIPS firmware processor > - GPU hang detection and recovery > > Currently our main focus is on the AXE-1-16M GPU. Testing so far has been done > using a TI SK-AM62 board (AXE-1-16M GPU). Firmware for the AXE-1-16M can be > found here: > https://gitlab.freedesktop.org/frankbinns/linux-firmware/-/tree/powervr And what about another PowerVR (rogue-based) GPU? There are a lot of different models of rogue GPU in existed SoCs. New driver uses v3 firmware, but vendors uses v1/v2 firmwares. Who will provide firmware/source code v3 for all the others models?