diff mbox series

[v1] thermal: Remove Amit Kucheria from MAINTAINERS

Message ID 5716404.DvuYhMxLoT@kreacher
State New
Headers show
Series [v1] thermal: Remove Amit Kucheria from MAINTAINERS | expand

Commit Message

Rafael J. Wysocki Oct. 6, 2023, 11:21 a.m. UTC 
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Amit Kucheria has not been participating in kernel development in any
way or form for quite some time, so it is not useful to list him as a
designated reviewer for the thermal subsystem or as the maintainer of
the thermal zone device bindings.

Remove him from those two places accordingly.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 Documentation/devicetree/bindings/thermal/thermal-zones.yaml |    3 ---
 MAINTAINERS                                                  |    1 -
 2 files changed, 4 deletions(-)

Comments

Rob Herring (Arm) Oct. 6, 2023, 1:18 p.m. UTC | #1 
On Fri, 06 Oct 2023 13:21:14 +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Amit Kucheria has not been participating in kernel development in any
> way or form for quite some time, so it is not useful to list him as a
> designated reviewer for the thermal subsystem or as the maintainer of
> the thermal zone device bindings.
> 
> Remove him from those two places accordingly.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
>  Documentation/devicetree/bindings/thermal/thermal-zones.yaml |    3 ---
>  MAINTAINERS                                                  |    1 -
>  2 files changed, 4 deletions(-)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/thermal/thermal-zones.yaml: 'maintainers' is a required property
	hint: Metaschema for devicetree binding documentation
	from schema $id: http://devicetree.org/meta-schemas/base.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/5716404.DvuYhMxLoT@kreacher

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
Krzysztof Kozlowski Oct. 6, 2023, 1:43 p.m. UTC | #2 
On 06/10/2023 13:21, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Amit Kucheria has not been participating in kernel development in any
> way or form for quite some time, so it is not useful to list him as a
> designated reviewer for the thermal subsystem or as the maintainer of
> the thermal zone device bindings.
> 
> Remove him from those two places accordingly.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
>  Documentation/devicetree/bindings/thermal/thermal-zones.yaml |    3 ---

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Lukasz Luba Oct. 6, 2023, 1:48 p.m. UTC | #3 
On 10/6/23 14:43, Krzysztof Kozlowski wrote:
> On 06/10/2023 15:43, Krzysztof Kozlowski wrote:
>> On 06/10/2023 13:21, Rafael J. Wysocki wrote:
>>> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>>>
>>> Amit Kucheria has not been participating in kernel development in any
>>> way or form for quite some time, so it is not useful to list him as a
>>> designated reviewer for the thermal subsystem or as the maintainer of
>>> the thermal zone device bindings.
>>>
>>> Remove him from those two places accordingly.
>>>
>>> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>>> ---
>>>   Documentation/devicetree/bindings/thermal/thermal-zones.yaml |    3 ---
>>
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> and unAcked. We need a maintainer for the bindings. Someone else from
> thermal?
> 

I'm going to handle the review in thermal subsystem. Although,
I forgot about this 'binding' thing...

Daniel, what do you think?
Daniel Lezcano Oct. 6, 2023, 9:44 p.m. UTC | #4 
On 06/10/2023 15:48, Lukasz Luba wrote:
> 
> 
> On 10/6/23 14:43, Krzysztof Kozlowski wrote:
>> On 06/10/2023 15:43, Krzysztof Kozlowski wrote:
>>> On 06/10/2023 13:21, Rafael J. Wysocki wrote:
>>>> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>>>>
>>>> Amit Kucheria has not been participating in kernel development in any
>>>> way or form for quite some time, so it is not useful to list him as a
>>>> designated reviewer for the thermal subsystem or as the maintainer of
>>>> the thermal zone device bindings.
>>>>
>>>> Remove him from those two places accordingly.
>>>>
>>>> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>>>> ---
>>>>   Documentation/devicetree/bindings/thermal/thermal-zones.yaml |    
>>>> 3 ---
>>>
>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> and unAcked. We need a maintainer for the bindings. Someone else from
>> thermal?
>>
> 
> I'm going to handle the review in thermal subsystem. Although,
> I forgot about this 'binding' thing...
> 
> Daniel, what do you think?

I can handle the bindings, I rewrote the thermal-of code and worked with 
Amit on the txt to yaml conversion.
Rafael J. Wysocki Oct. 7, 2023, 10:44 a.m. UTC | #5 
On Fri, Oct 6, 2023 at 11:44 PM Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
>
> On 06/10/2023 15:48, Lukasz Luba wrote:
> >
> >
> > On 10/6/23 14:43, Krzysztof Kozlowski wrote:
> >> On 06/10/2023 15:43, Krzysztof Kozlowski wrote:
> >>> On 06/10/2023 13:21, Rafael J. Wysocki wrote:
> >>>> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >>>>
> >>>> Amit Kucheria has not been participating in kernel development in any
> >>>> way or form for quite some time, so it is not useful to list him as a
> >>>> designated reviewer for the thermal subsystem or as the maintainer of
> >>>> the thermal zone device bindings.
> >>>>
> >>>> Remove him from those two places accordingly.
> >>>>
> >>>> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >>>> ---
> >>>>   Documentation/devicetree/bindings/thermal/thermal-zones.yaml |
> >>>> 3 ---
> >>>
> >>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >>
> >> and unAcked. We need a maintainer for the bindings. Someone else from
> >> thermal?
> >>
> >
> > I'm going to handle the review in thermal subsystem. Although,
> > I forgot about this 'binding' thing...
> >
> > Daniel, what do you think?
>
> I can handle the bindings, I rewrote the thermal-of code and worked with
> Amit on the txt to yaml conversion.

Sounds good!

I'll send a v3 of the patch then with this change included, please ACK it.
diff mbox series

Patch

Index: linux-pm/Documentation/devicetree/bindings/thermal/thermal-zones.yaml
===================================================================
--- linux-pm.orig/Documentation/devicetree/bindings/thermal/thermal-zones.yaml
+++ linux-pm/Documentation/devicetree/bindings/thermal/thermal-zones.yaml
@@ -7,9 +7,6 @@  $schema: http://devicetree.org/meta-sche
 
 title: Thermal zone
 
-maintainers:
-  - Amit Kucheria <amitk@kernel.org>
-
 description: |
   Thermal management is achieved in devicetree by describing the sensor hardware
   and the software abstraction of cooling devices and thermal zones required to
Index: linux-pm/MAINTAINERS
===================================================================
--- linux-pm.orig/MAINTAINERS
+++ linux-pm/MAINTAINERS
@@ -21363,7 +21363,6 @@  F:	drivers/media/radio/radio-raremono.c
 THERMAL
 M:	Rafael J. Wysocki <rafael@kernel.org>
 M:	Daniel Lezcano <daniel.lezcano@linaro.org>
-R:	Amit Kucheria <amitk@kernel.org>
 R:	Zhang Rui <rui.zhang@intel.com>
 L:	linux-pm@vger.kernel.org
 S:	Supported