| Message ID | 20231006-pxa-gpio-v6-0-981b4910d599@skole.hr |
|---|---|
| Headers | show |
| Series | ARM: pxa: GPIO descriptor conversions | expand |
On Fri, Oct 6, 2023 at 3:45 PM Duje Mihanović <duje.mihanovic@skole.hr> wrote: > > Sharp's Spitz board still uses the legacy GPIO interface for configuring > its two onboard LEDs. > > Convert them to use the GPIO descriptor interface. > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr> > --- > arch/arm/mach-pxa/spitz.c | 20 ++++++++++++++++++-- > 1 file changed, 18 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-pxa/spitz.c b/arch/arm/mach-pxa/spitz.c > index 535e2b2e997b..1fb4102ea39e 100644 > --- a/arch/arm/mach-pxa/spitz.c > +++ b/arch/arm/mach-pxa/spitz.c > @@ -452,16 +452,25 @@ static inline void spitz_keys_init(void) {} > * LEDs > ******************************************************************************/ > #if defined(CONFIG_LEDS_GPIO) || defined(CONFIG_LEDS_GPIO_MODULE) > +static struct gpiod_lookup_table spitz_led_gpio_table = { > + .dev_id = "leds-gpio", > + .table = { > + GPIO_LOOKUP_IDX("pxa-gpio", SPITZ_GPIO_LED_ORANGE, NULL, 0, > + GPIO_ACTIVE_HIGH), > + GPIO_LOOKUP_IDX("pxa-gpio", SPITZ_GPIO_LED_GREEN, NULL, 1, > + GPIO_ACTIVE_HIGH), > + { } > + } > +}; > + > static struct gpio_led spitz_gpio_leds[] = { > { > .name = "spitz:amber:charge", > .default_trigger = "sharpsl-charge", > - .gpio = SPITZ_GPIO_LED_ORANGE, > }, > { > .name = "spitz:green:hddactivity", > .default_trigger = "disk-activity", > - .gpio = SPITZ_GPIO_LED_GREEN, > }, > }; > > @@ -480,7 +489,14 @@ static struct platform_device spitz_led_device = { > > static void __init spitz_leds_init(void) > { > + struct gpio_descs *leds; This should be global, otherwise KASAN will complain. Bart > + > + gpiod_add_lookup_table(&spitz_led_gpio_table); > platform_device_register(&spitz_led_device); > + leds = gpiod_get_array_optional(&spitz_led_device.dev, > + NULL, GPIOD_ASIS); > + spitz_gpio_leds[0].gpiod = leds->desc[0]; > + spitz_gpio_leds[1].gpiod = leds->desc[1]; > } > #else > static inline void spitz_leds_init(void) {} > > -- > 2.42.0 > >
Hello, Small series to convert some of the board files in the mach-pxa directory to use the new GPIO descriptor interface. Most notably, the am200epd, am300epd and Spitz matrix keypad among others are not converted in this series. Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr> --- Changes in v6: - Address maintainer comments: - Use devm_gpiod_get_optional() in OHCI - Use gpiod_get_array() in Spitz LEDs - Update trailers - Link to v5: https://lore.kernel.org/r/20231004-pxa-gpio-v5-0-d99ae6fceea8@skole.hr Changes in v5: - Address maintainer comments: - Rename "reset generator" GPIO to "reset" - Rename ads7846_wait_for_sync() to ads7846_wait_for_sync_gpio() - Properly bail out when requesting USB host GPIO fails - Use dev_err_probe() when requesting touchscreen sync GPIO fails - Use static gpio_desc for gumstix bluetooth reset - Pulse gumstix bluetooth reset line correctly (assert, then deassert) - Fix style issue in ads7846_wait_for_sync_gpio() - Update trailers - Link to v4: https://lore.kernel.org/r/20231001-pxa-gpio-v4-0-0f3b975e6ed5@skole.hr Changes in v4: - Address maintainer comments: - Move wait_for_sync() from spitz.c to driver - Register LED platform device before getting its gpiod-s - Add Linus' Reviewed-by - Link to v3: https://lore.kernel.org/r/20230929-pxa-gpio-v3-0-af8d5e5d1f34@skole.hr Changes in v3: - Address maintainer comments: - Use GPIO_LOOKUP_IDX for LEDs - Drop unnecessary NULL assignments - Don't give up on *all* SPI devices if hsync cannot be set up - Add Linus' Acked-by - Link to v2: https://lore.kernel.org/r/20230926-pxa-gpio-v2-0-984464d165dd@skole.hr Changes in v2: - Address maintainer comments: - Change mentions of function to function() - Drop cast in OHCI driver dev_warn() call - Use %pe in OHCI and reset drivers - Use GPIO _optional() API in OHCI driver - Drop unnecessary not-null check in OHCI driver - Use pr_err() instead of printk() in reset driver - Rebase on v6.6-rc3 - Link to v1: https://lore.kernel.org/r/20230924-pxa-gpio-v1-0-2805b87d8894@skole.hr --- Duje Mihanović (6): ARM: pxa: Convert Spitz OHCI to GPIO descriptors ARM: pxa: Convert Spitz LEDs to GPIO descriptors ARM: pxa: Convert Spitz CF power control to GPIO descriptors ARM: pxa: Convert reset driver to GPIO descriptors ARM: pxa: Convert gumstix Bluetooth to GPIO descriptors input: ads7846: Move wait_for_sync() logic to driver arch/arm/mach-pxa/gumstix.c | 22 ++++++------ arch/arm/mach-pxa/reset.c | 39 +++++++------------- arch/arm/mach-pxa/reset.h | 3 +- arch/arm/mach-pxa/spitz.c | 71 +++++++++++++++++++++++++------------ drivers/input/touchscreen/ads7846.c | 22 ++++++++---- drivers/usb/host/ohci-pxa27x.c | 7 ++++ include/linux/spi/ads7846.h | 1 - 7 files changed, 96 insertions(+), 69 deletions(-) --- base-commit: 8a749fd1a8720d4619c91c8b6e7528c0a355c0aa change-id: 20230807-pxa-gpio-3ce25d574814 Best regards,