diff mbox series

ALSA: usb-audio: Fix microphone sound on Opencomm2 Headset

Message ID 20231006044852.4181022-1-whalechang@google.com
State Accepted
Commit 6a83d6f3bb3c329a73e3483651fb77b78bac1878
Headers show
Series ALSA: usb-audio: Fix microphone sound on Opencomm2 Headset | expand

Commit Message

Whale Chang Oct. 6, 2023, 4:48 a.m. UTC 
From: WhaleChang <whalechang@google.com>

When a Opencomm2 Headset is connected to a Bluetooth USB dongle,
the audio playback functions properly, but the microphone does not work.

In the dmesg logs, there are messages indicating that the init_pitch
function fails when the capture process begins.

The microphone only functions when the ep pitch control is not set.

Toggling the pitch control off bypasses the init_piatch function
and allows the microphone to work.

Signed-off-by: WhaleChang <whalechang@google.com>
---

 sound/usb/quirks.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Takashi Iwai Oct. 6, 2023, 9:09 a.m. UTC | #1 
On Fri, 06 Oct 2023 06:48:49 +0200,
Whale Chang wrote:
> 
> From: WhaleChang <whalechang@google.com>
> 
> When a Opencomm2 Headset is connected to a Bluetooth USB dongle,
> the audio playback functions properly, but the microphone does not work.
> 
> In the dmesg logs, there are messages indicating that the init_pitch
> function fails when the capture process begins.
> 
> The microphone only functions when the ep pitch control is not set.
> 
> Toggling the pitch control off bypasses the init_piatch function
> and allows the microphone to work.
> 
> Signed-off-by: WhaleChang <whalechang@google.com>

Thanks, applied now.


Takashi
diff mbox series

Patch

diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index 598659d761cc..d4bbef70d2f7 100644
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -1994,7 +1994,11 @@  void snd_usb_audioformat_attributes_quirk(struct snd_usb_audio *chip,
 		/* mic works only when ep packet size is set to wMaxPacketSize */
 		fp->attributes |= UAC_EP_CS_ATTR_FILL_MAX;
 		break;
-
+	case USB_ID(0x3511, 0x2b1e): /* Opencomm2 UC USB Bluetooth dongle */
+		/* mic works only when ep pitch control is not set */
+		if (stream == SNDRV_PCM_STREAM_CAPTURE)
+			fp->attributes &= ~UAC_EP_CS_ATTR_PITCH_CONTROL;
+		break;
 	}
 }