| Message ID | 20230905174324.25296-1-quic_alokad@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | wifi: ath12k: call ath12k_mac_fils_discovery() without condition | expand |
On 9/5/2023 10:43 AM, Aloka Dixit wrote: > Mac80211 does not set flags BSS_CHANGED_FILS_DISCOVERY and > BSS_CHANGED_UNSOL_BCAST_PROBE_RESP if there are no updates to > FILS discovery and unsolicited broadcast probe response transmission > configurations respectively. For BSS change operations such as channel > switch, this results in the transmissions getting stopped because the > driver does not send WMI command to firmware if the flags are not set. > Remove the checks for the flags to always send the existing > configuration to firmware. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Aloka Dixit <quic_alokad@quicinc.com> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com> > --- > drivers/net/wireless/ath/ath12k/mac.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c > index 88346e66bb75..94967f810093 100644 > --- a/drivers/net/wireless/ath/ath12k/mac.c > +++ b/drivers/net/wireless/ath/ath12k/mac.c > @@ -2761,9 +2761,7 @@ static void ath12k_mac_op_bss_info_changed(struct ieee80211_hw *hw, > } > } > > - if (changed & BSS_CHANGED_FILS_DISCOVERY || > - changed & BSS_CHANGED_UNSOL_BCAST_PROBE_RESP) > - ath12k_mac_fils_discovery(arvif, info); > + ath12k_mac_fils_discovery(arvif, info); > > if (changed & BSS_CHANGED_EHT_PUNCTURING) > arvif->punct_bitmap = info->eht_puncturing; > > base-commit: 0263687f4441d5a5eab8074d56b4693c8f0acf85
Aloka Dixit <quic_alokad@quicinc.com> wrote: > Mac80211 does not set flags BSS_CHANGED_FILS_DISCOVERY and > BSS_CHANGED_UNSOL_BCAST_PROBE_RESP if there are no updates to > FILS discovery and unsolicited broadcast probe response transmission > configurations respectively. For BSS change operations such as channel > switch, this results in the transmissions getting stopped because the > driver does not send WMI command to firmware if the flags are not set. > Remove the checks for the flags to always send the existing > configuration to firmware. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Aloka Dixit <quic_alokad@quicinc.com> > Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com> > Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com> Patch applied to ath-next branch of ath.git, thanks. 43a10990404f wifi: ath12k: call ath12k_mac_fils_discovery() without condition
diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c index 88346e66bb75..94967f810093 100644 --- a/drivers/net/wireless/ath/ath12k/mac.c +++ b/drivers/net/wireless/ath/ath12k/mac.c @@ -2761,9 +2761,7 @@ static void ath12k_mac_op_bss_info_changed(struct ieee80211_hw *hw, } } - if (changed & BSS_CHANGED_FILS_DISCOVERY || - changed & BSS_CHANGED_UNSOL_BCAST_PROBE_RESP) - ath12k_mac_fils_discovery(arvif, info); + ath12k_mac_fils_discovery(arvif, info); if (changed & BSS_CHANGED_EHT_PUNCTURING) arvif->punct_bitmap = info->eht_puncturing;
Mac80211 does not set flags BSS_CHANGED_FILS_DISCOVERY and BSS_CHANGED_UNSOL_BCAST_PROBE_RESP if there are no updates to FILS discovery and unsolicited broadcast probe response transmission configurations respectively. For BSS change operations such as channel switch, this results in the transmissions getting stopped because the driver does not send WMI command to firmware if the flags are not set. Remove the checks for the flags to always send the existing configuration to firmware. Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 Signed-off-by: Aloka Dixit <quic_alokad@quicinc.com> --- drivers/net/wireless/ath/ath12k/mac.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) base-commit: 0263687f4441d5a5eab8074d56b4693c8f0acf85