mbox series

[GIT,PULL,FOR,v6.7] RC fixes

Message ID ZQAK1UxQlcx2ExWr@gofer.mess.org
State New
Headers show
Series [GIT,PULL,FOR,v6.7] RC fixes | expand

Pull-request

git://linuxtv.org/syoung/media_tree.git tags/v6.7a

Message

Sean Young Sept. 12, 2023, 6:53 a.m. UTC 
The following changes since commit f32b68cd3604a824769ffeb02d2adea492a9d221:

  media: cx231xx: Add EP5_BUF_SIZE and EP5_TIMEOUT_MS macros (2023-09-06 12:29:09 +0200)

are available in the Git repository at:

  git://linuxtv.org/syoung/media_tree.git tags/v6.7a

for you to fetch changes up to c6ab671c3b08b7b5231346ec7a7f06ff2b22bf07:

  arm64: dts: meson: add IR controller for Meson-S4 SoC (2023-09-11 11:49:43 +0100)

----------------------------------------------------------------
v6.7a

----------------------------------------------------------------
Sean Young (2):
      dt-bindings: media: remove nokia,n900-ir as pwm-ir-tx is compatible
      media: rc: remove ir-rx51 in favour of generic pwm-ir-tx

Zelong Dong (2):
      media: rc: meson-ir: support rc driver type RC_DRIVER_SCANCODE
      arm64: dts: meson: add IR controller for Meson-S4 SoC

 .../devicetree/bindings/leds/irled/pwm-ir-tx.yaml  |   5 +-
 .../devicetree/bindings/media/nokia,n900-ir        |  20 -
 arch/arm/configs/omap2plus_defconfig               |   1 -
 .../boot/dts/amlogic/meson-s4-s805x2-aq222.dts     |   6 +
 arch/arm64/boot/dts/amlogic/meson-s4.dtsi          |  15 +
 drivers/media/rc/Kconfig                           |  10 -
 drivers/media/rc/Makefile                          |   1 -
 drivers/media/rc/ir-rx51.c                         | 285 -----------
 drivers/media/rc/meson-ir.c                        | 522 ++++++++++++++++++---
 drivers/media/rc/pwm-ir-tx.c                       |   1 +
 10 files changed, 477 insertions(+), 389 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/media/nokia,n900-ir
 delete mode 100644 drivers/media/rc/ir-rx51.c

Comments

Hans Verkuil Sept. 21, 2023, 12:55 p.m. UTC | #1 
Hi Sean,

On 12/09/2023 08:53, Sean Young wrote:
> The following changes since commit f32b68cd3604a824769ffeb02d2adea492a9d221:
> 
>   media: cx231xx: Add EP5_BUF_SIZE and EP5_TIMEOUT_MS macros (2023-09-06 12:29:09 +0200)
> 
> are available in the Git repository at:
> 
>   git://linuxtv.org/syoung/media_tree.git tags/v6.7a
> 
> for you to fetch changes up to c6ab671c3b08b7b5231346ec7a7f06ff2b22bf07:
> 
>   arm64: dts: meson: add IR controller for Meson-S4 SoC (2023-09-11 11:49:43 +0100)
> 
> ----------------------------------------------------------------
> v6.7a
> 
> ----------------------------------------------------------------
> Sean Young (2):
>       dt-bindings: media: remove nokia,n900-ir as pwm-ir-tx is compatible
>       media: rc: remove ir-rx51 in favour of generic pwm-ir-tx
> 
> Zelong Dong (2):
>       media: rc: meson-ir: support rc driver type RC_DRIVER_SCANCODE
>       arm64: dts: meson: add IR controller for Meson-S4 SoC

I think you accidentally picked the dts patch instead of the bindings
patch (1), since that one is missing, leading to a checkpatch warning:

WARNING: DT compatible string "amlogic,meson-s4-ir" appears un-documented -- check ./Documentation/devicetree/bindings/
#56: FILE: arch/arm64/boot/dts/amlogic/meson-s4.dtsi:146:
+                               compatible = "amlogic,meson-s4-ir";

I'll mark this PR as 'Changes Requested', since this can't be right.

Regards,

	Hans

(1) https://patchwork.linuxtv.org/project/linux-media/patch/20230825115310.39993-3-zelong.dong@amlogic.com/

> 
>  .../devicetree/bindings/leds/irled/pwm-ir-tx.yaml  |   5 +-
>  .../devicetree/bindings/media/nokia,n900-ir        |  20 -
>  arch/arm/configs/omap2plus_defconfig               |   1 -
>  .../boot/dts/amlogic/meson-s4-s805x2-aq222.dts     |   6 +
>  arch/arm64/boot/dts/amlogic/meson-s4.dtsi          |  15 +
>  drivers/media/rc/Kconfig                           |  10 -
>  drivers/media/rc/Makefile                          |   1 -
>  drivers/media/rc/ir-rx51.c                         | 285 -----------
>  drivers/media/rc/meson-ir.c                        | 522 ++++++++++++++++++---
>  drivers/media/rc/pwm-ir-tx.c                       |   1 +
>  10 files changed, 477 insertions(+), 389 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/media/nokia,n900-ir
>  delete mode 100644 drivers/media/rc/ir-rx51.c
Sean Young Sept. 21, 2023, 2:58 p.m. UTC | #2 
On Thu, Sep 21, 2023 at 02:55:32PM +0200, Hans Verkuil wrote:
> Hi Sean,
> 
> On 12/09/2023 08:53, Sean Young wrote:
> > The following changes since commit f32b68cd3604a824769ffeb02d2adea492a9d221:
> > 
> >   media: cx231xx: Add EP5_BUF_SIZE and EP5_TIMEOUT_MS macros (2023-09-06 12:29:09 +0200)
> > 
> > are available in the Git repository at:
> > 
> >   git://linuxtv.org/syoung/media_tree.git tags/v6.7a
> > 
> > for you to fetch changes up to c6ab671c3b08b7b5231346ec7a7f06ff2b22bf07:
> > 
> >   arm64: dts: meson: add IR controller for Meson-S4 SoC (2023-09-11 11:49:43 +0100)
> > 
> > ----------------------------------------------------------------
> > v6.7a
> > 
> > ----------------------------------------------------------------
> > Sean Young (2):
> >       dt-bindings: media: remove nokia,n900-ir as pwm-ir-tx is compatible
> >       media: rc: remove ir-rx51 in favour of generic pwm-ir-tx
> > 
> > Zelong Dong (2):
> >       media: rc: meson-ir: support rc driver type RC_DRIVER_SCANCODE
> >       arm64: dts: meson: add IR controller for Meson-S4 SoC
> 
> I think you accidentally picked the dts patch instead of the bindings
> patch (1), since that one is missing, leading to a checkpatch warning:
> 
> WARNING: DT compatible string "amlogic,meson-s4-ir" appears un-documented -- check ./Documentation/devicetree/bindings/
> #56: FILE: arch/arm64/boot/dts/amlogic/meson-s4.dtsi:146:
> +                               compatible = "amlogic,meson-s4-ir";
> 
> I'll mark this PR as 'Changes Requested', since this can't be right.

Yes, you're right, that's my bad. Thanks for catching that early. 

I'll respin.

Thanks,

Sean