diff mbox series

[v3,36/39] accel: Introduce accel_cpu_unrealize() stub

Message ID 20230916214123.525796-37-richard.henderson@linaro.org
State New
Headers show
Series target agnostic cleanups | expand

Commit Message

Richard Henderson Sept. 16, 2023, 9:41 p.m. UTC 
From: Philippe Mathieu-Daudé <philmd@linaro.org>

Prepare the stub for parity with accel_cpu_realize().

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20230915190009.68404-3-philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 include/qemu/accel.h | 6 ++++++
 accel/accel-target.c | 4 ++++
 cpu-target.c         | 3 ++-
 3 files changed, 12 insertions(+), 1 deletion(-)

Comments

Philippe Mathieu-Daudé Sept. 18, 2023, 8:12 a.m. UTC | #1 
On 16/9/23 23:41, Richard Henderson wrote:
> From: Philippe Mathieu-Daudé <philmd@linaro.org>
> 
> Prepare the stub for parity with accel_cpu_realize().
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Message-Id: <20230915190009.68404-3-philmd@linaro.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   include/qemu/accel.h | 6 ++++++
>   accel/accel-target.c | 4 ++++
>   cpu-target.c         | 3 ++-
>   3 files changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/include/qemu/accel.h b/include/qemu/accel.h
> index cb64a07b84..7b02cb40e5 100644
> --- a/include/qemu/accel.h
> +++ b/include/qemu/accel.h
> @@ -96,6 +96,12 @@ void accel_cpu_instance_init(CPUState *cpu);
>    */
>   bool accel_cpu_realize(CPUState *cpu, Error **errp);
>   
> +/**
> + * accel_cpu_unrealize:

Thanks for fixing the typo :)

> + * @cpu: The CPU that needs to call accel-specific cpu unrealization.
> + */
> +void accel_cpu_unrealize(CPUState *cpu);
> +
diff mbox series

Patch

diff --git a/include/qemu/accel.h b/include/qemu/accel.h
index cb64a07b84..7b02cb40e5 100644
--- a/include/qemu/accel.h
+++ b/include/qemu/accel.h
@@ -96,6 +96,12 @@  void accel_cpu_instance_init(CPUState *cpu);
  */
 bool accel_cpu_realize(CPUState *cpu, Error **errp);
 
+/**
+ * accel_cpu_unrealize:
+ * @cpu: The CPU that needs to call accel-specific cpu unrealization.
+ */
+void accel_cpu_unrealize(CPUState *cpu);
+
 /**
  * accel_supported_gdbstub_sstep_flags:
  *
diff --git a/accel/accel-target.c b/accel/accel-target.c
index b953855e8b..cc3a45e663 100644
--- a/accel/accel-target.c
+++ b/accel/accel-target.c
@@ -129,6 +129,10 @@  bool accel_cpu_realize(CPUState *cpu, Error **errp)
     return true;
 }
 
+void accel_cpu_unrealize(CPUState *cpu)
+{
+}
+
 int accel_supported_gdbstub_sstep_flags(void)
 {
     AccelState *accel = current_accel();
diff --git a/cpu-target.c b/cpu-target.c
index 61c9760e62..b928bbed50 100644
--- a/cpu-target.c
+++ b/cpu-target.c
@@ -187,8 +187,9 @@  void cpu_exec_unrealizefn(CPUState *cpu)
     cpu_list_remove(cpu);
     /*
      * Now that the vCPU has been removed from the RCU list, we can call
-     * tcg_exec_unrealizefn, which may free fields using call_rcu.
+     * accel_cpu_unrealize, which may free fields using call_rcu.
      */
+    accel_cpu_unrealize(cpu);
     if (tcg_enabled()) {
         tcg_exec_unrealizefn(cpu);
     }