mbox series

[v4,0/1] Patch History

Message ID PA4PR04MB9638B8753EFD81E174E55BC3D114A@PA4PR04MB9638.eurprd04.prod.outlook.com
Headers show
Series Patch History | expand

Message

David Lin Aug. 15, 2023, 7:09 a.m. UTC 
Patch v4:

1. Correct one bad code segment.
2. Add code to check firmware key api version for host_mlme.

Patch v3:

Clean and clear commit message.

Patch v2:

1. Checkpatch error: pwe[1] -> pwe[0].
2. Remove module parameter 'host_mlme'.
3. Won't advertise NL80211_FEATURE_SAE if host mlme is disabled.

David Lin (1):
  wifi: mwifiex: added code to support host mlme.

 .../net/wireless/marvell/mwifiex/cfg80211.c   | 327 ++++++++++++++++++
 drivers/net/wireless/marvell/mwifiex/cmdevt.c |  14 +-
 drivers/net/wireless/marvell/mwifiex/decl.h   |  12 +
 drivers/net/wireless/marvell/mwifiex/fw.h     |  15 +
 drivers/net/wireless/marvell/mwifiex/init.c   |   3 +
 drivers/net/wireless/marvell/mwifiex/join.c   |  64 +++-
 drivers/net/wireless/marvell/mwifiex/main.h   |  10 +
 drivers/net/wireless/marvell/mwifiex/scan.c   |   6 +
 drivers/net/wireless/marvell/mwifiex/sdio.c   |  13 +
 drivers/net/wireless/marvell/mwifiex/sdio.h   |   2 +
 .../net/wireless/marvell/mwifiex/sta_event.c  |  18 +-
 .../net/wireless/marvell/mwifiex/sta_ioctl.c  |   3 +-
 drivers/net/wireless/marvell/mwifiex/sta_tx.c |  10 +-
 .../net/wireless/marvell/mwifiex/uap_cmd.c    |  26 ++
 drivers/net/wireless/marvell/mwifiex/util.c   |  73 ++++
 15 files changed, 583 insertions(+), 13 deletions(-)

Comments

David Lin Sept. 14, 2023, 6:42 a.m. UTC | #1 
Hi Kalle,

        Patch v4 (https://patchwork.kernel.org/project/linux-wireless/patch/PA4PR04MB963838F12BADC1B9FD377CB7D114A@PA4PR04MB9638.eurprd04.prod.outlook.com/) for host mlme had been submitted for a while.

        Current state of this patch is "Deferred". I wonder when can this patch be reviewed and merged.

        Is there anything I can do to speed up the acceptance of this patch by upstream?

Best Regards,
David

> From: David Lin
> Sent: Tuesday, August 15, 2023 3:09 PM
> To: 'linux-wireless@vger.kernel.org' <linux-wireless@vger.kernel.org>
> Cc: 'linux-kernel@vger.kernel.org' <linux-kernel@vger.kernel.org>;
> 'sharvari.harisangam@nxp.com' <sharvari.harisangam@nxp.com>;
> 'yu-hao.lin@nxp.com' <yu-hao.lin@nxp.com>; 'tsung-hsien.hsieh@nxp.com'
> <tsung-hsien.hsieh@nxp.com>; 'kvalo@kernel.org' <kvalo@kernel.org>;
> 'amitkarwar@gmail.com' <amitkarwar@gmail.com>;
> 'ganapathi017@gmail.com' <ganapathi017@gmail.com>;
> 'huxinming820@gmail.com' <huxinming820@gmail.com>;
> 'davem@davemloft.net' <davem@davemloft.net>; 'edumazet@google.com'
> <edumazet@google.com>; 'kuba@kernelorg' <kuba@kernelorg>;
> 'pabeni@redhat.com' <pabeni@redhat.com>
> Subject: [PATCH v4 0/1] Patch History
> 
> Patch v4:
> 
> 1. Correct one bad code segment.
> 2. Add code to check firmware key api version for host_mlme.
> 
> Patch v3:
> 
> Clean and clear commit message.
> 
> Patch v2:
> 
> 1. Checkpatch error: pwe[1] -> pwe[0].
> 2. Remove module parameter 'host_mlme'.
> 3. Won't advertise NL80211_FEATURE_SAE if host mlme is disabled.
> 
> David Lin (1):
>   wifi: mwifiex: added code to support host mlme.
> 
>  .../net/wireless/marvell/mwifiex/cfg80211.c   | 327 ++++++++++++++++++
>  drivers/net/wireless/marvell/mwifiex/cmdevt.c |  14 +-
>  drivers/net/wireless/marvell/mwifiex/decl.h   |  12 +
>  drivers/net/wireless/marvell/mwifiex/fw.h     |  15 +
>  drivers/net/wireless/marvell/mwifiex/init.c   |   3 +
>  drivers/net/wireless/marvell/mwifiex/join.c   |  64 +++-
>  drivers/net/wireless/marvell/mwifiex/main.h   |  10 +
>  drivers/net/wireless/marvell/mwifiex/scan.c   |   6 +
>  drivers/net/wireless/marvell/mwifiex/sdio.c   |  13 +
>  drivers/net/wireless/marvell/mwifiex/sdio.h   |   2 +
>  .../net/wireless/marvell/mwifiex/sta_event.c  |  18 +-
>  .../net/wireless/marvell/mwifiex/sta_ioctl.c  |   3 +-
>  drivers/net/wireless/marvell/mwifiex/sta_tx.c |  10 +-
>  .../net/wireless/marvell/mwifiex/uap_cmd.c    |  26 ++
>  drivers/net/wireless/marvell/mwifiex/util.c   |  73 ++++
>  15 files changed, 583 insertions(+), 13 deletions(-)
> 
> --
> 2.25.1
Brian Norris Sept. 15, 2023, 1:28 a.m. UTC | #2 
On Wed, Sep 13, 2023 at 11:42 PM David Lin <yu-hao.lin@nxp.com> wrote:
>
> Hi Kalle,
>
>         Patch v4 (https://patchwork.kernel.org/project/linux-wireless/patch/PA4PR04MB963838F12BADC1B9FD377CB7D114A@PA4PR04MB9638.eurprd04.prod.outlook.com/) for host mlme had been submitted for a while.
>
>         Current state of this patch is "Deferred". I wonder when can this patch be reviewed and merged.
>
>         Is there anything I can do to speed up the acceptance of this patch by upstream?

You still haven't sent this to the correct maintainers (i.e., me) for
one. I also thought there were outstanding unaddressed comments from
Francesco. And given how much Francesco looked, I'd appreciate getting
his Reviewed-by when he's actually happy with it.

(Like I said earlier, I'm not exactly happy that y'all are failing to
maintain this driver, but then insisting the community review and
accept new features. At least if your paying customers will help out
this process, the bargain is less-bad...)

Brian
Francesco Dolcini Sept. 15, 2023, 1:56 p.m. UTC | #3 
On Thu, Sep 14, 2023 at 06:28:31PM -0700, Brian Norris wrote:
> On Wed, Sep 13, 2023 at 11:42 PM David Lin <yu-hao.lin@nxp.com> wrote:
>>
>> Current state of this patch is "Deferred". I wonder when can this patch be reviewed and merged.
>>
>> Is there anything I can do to speed up the acceptance of this patch by upstream?
> 
> You still haven't sent this to the correct maintainers (i.e., me) for
> one. I also thought there were outstanding unaddressed comments from
> Francesco. And given how much Francesco looked, I'd appreciate getting
> his Reviewed-by when he's actually happy with it.

Ack, this fell off my radar.

Francesco
David Lin Sept. 15, 2023, 2:19 p.m. UTC | #4 
> From: Brian Norris <briannorris@chromium.org>
> Sent: Friday, September 15, 2023 9:29 AM
> To: David Lin <yu-hao.lin@nxp.com>
> Cc: linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org; Sharvari
> Harisangam <sharvari.harisangam@nxp.com>; Pete Hsieh
> <tsung-hsien.hsieh@nxp.com>; kvalo@kernel.org; amitkarwar@gmail.com;
> ganapathi017@gmail.com; huxinming820@gmail.com;
> davem@davemloft.net; edumazet@google.com; pabeni@redhat.com;
> Francesco Dolcini <francesco@dolcini.it>
> Subject: [EXT] Re: [PATCH v4 0/1] Patch History
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> On Wed, Sep 13, 2023 at 11:42 PM David Lin <yu-hao.lin@nxp.com> wrote:
> >
> > Hi Kalle,
> >
> >         Patch v4
> (https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatch
> work.kernel.org%2Fproject%2Flinux-wireless%2Fpatch%2FPA4PR04MB963838
> F12BADC1B9FD377CB7D114A%40PA4PR04MB9638.eurprd04.prod.outlook.co
> m%2F&data=05%7C01%7Cyu-hao.lin%40nxp.com%7C75430d6f96b24d35e2e3
> 08dbb58b1ce5%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6383
> 03381314463578%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiL
> CJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sd
> ata=RqbGAO0rATokTQI76roRAPl3Dr6OQKrhvesU%2FG6cEBU%3D&reserved=0)
> for host mlme had been submitted for a while.
> >
> >         Current state of this patch is "Deferred". I wonder when can this
> patch be reviewed and merged.
> >
> >         Is there anything I can do to speed up the acceptance of this
> patch by upstream?
> 
> You still haven't sent this to the correct maintainers (i.e., me) for one. I also
> thought there were outstanding unaddressed comments from Francesco.
> And given how much Francesco looked, I'd appreciate getting his
> Reviewed-by when he's actually happy with it.

I think I already replied Francesco's feedbacks. For example, patch history and correct maintainers I followed the way described by him to figure out maintainers.
I will add you to the maintainer list.

Following is the mailing list I collected until now. If I still miss someone, please let me know.

<<mwifiex mailing list>>
linux-wireless@vger.kernel.org
linux-kernel@vger.kernel.org;sharvari.harisangam@nxp.com;yu-hao.lin@nxp.com;tsung-hsien.hsieh@nxp.com;kvalo@kernel.org;amitkarwar@gmail.com;ganapathi017@gmail.com;huxinming820@gmail.com;davem@davemloft.net;edumazet@google.com;kuba@kernel.org;pabeni@redhat.com;francesco@dolcini.it;briannorris@chromium.org

> 
> (Like I said earlier, I'm not exactly happy that y'all are failing to maintain this
> driver, but then insisting the community review and accept new features. At
> least if your paying customers will help out this process, the bargain is
> less-bad...)
> 

I think we will commit to the code we submitted. In fact, we will have QA to verify patches we submitted and we will continue to submit patches to fix issues reported by our QA or customers to use the code we submitted.

> Brian
Brian Norris Sept. 15, 2023, 4:55 p.m. UTC | #5 
On Fri, Sep 15, 2023 at 7:19 AM David Lin <yu-hao.lin@nxp.com> wrote:
> Following is the mailing list I collected until now. If I still miss someone, please let me know.
>
> <<mwifiex mailing list>>
> linux-wireless@vger.kernel.org
> linux-kernel@vger.kernel.org;sharvari.harisangam@nxp.com;yu-hao.lin@nxp.com;tsung-hsien.hsieh@nxp.com;kvalo@kernel.org;amitkarwar@gmail.com;ganapathi017@gmail.com;huxinming820@gmail.com;davem@davemloft.net;edumazet@google.com;kuba@kernel.org;pabeni@redhat.com;francesco@dolcini.it;briannorris@chromium.org

AFAICT, you didn't actually fix anything. That's a months-old list
(plus manually adding me). Did you run scripts/get_maintainer.pl on a
recent wireless-next tree? Mine looks like this:

$ scripts/get_maintainer.pl -f drivers/net/wireless/marvell/mwifiex/main.c
Brian Norris <briannorris@chromium.org> (odd fixer:MARVELL MWIFIEX
WIRELESS DRIVER)
Kalle Valo <kvalo@kernel.org> (maintainer:NETWORKING DRIVERS (WIRELESS))
linux-wireless@vger.kernel.org (open list:MARVELL MWIFIEX WIRELESS DRIVER)
linux-kernel@vger.kernel.org (open list)
David Lin Sept. 17, 2023, 2:04 p.m. UTC | #6 
> From: Brian Norris <briannorris@chromium.org>
> Sent: Saturday, September 16, 2023 12:55 AM
> To: David Lin <yu-hao.lin@nxp.com>
> Cc: linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org; Sharvari
> Harisangam <sharvari.harisangam@nxp.com>; Pete Hsieh
> <tsung-hsien.hsieh@nxp.com>; kvalo@kernel.org; amitkarwar@gmail.com;
> ganapathi017@gmail.com; huxinming820@gmail.com;
> davem@davemloft.net; edumazet@google.com; pabeni@redhat.com;
> Francesco Dolcini <francesco@dolcini.it>
> Subject: Re: [EXT] Re: [PATCH v4 0/1] Patch History
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> On Fri, Sep 15, 2023 at 7:19 AM David Lin <yu-hao.lin@nxp.com> wrote:
> > Following is the mailing list I collected until now. If I still miss someone,
> please let me know.
> >
> > <<mwifiex mailing list>>
> > linux-wireless@vger.kernel.org
> > linux-kernel@vger.kernel.org;sharvari.harisangam@nxp.com;yu-hao.lin@nx
> >
> p.com;tsung-hsien.hsieh@nxp.com;kvalo@kernel.org;amitkarwar@gmail.co
> m;
> >
> ganapathi017@gmail.com;huxinming820@gmail.com;davem@davemloft.net
> ;edum
> >
> azet@google.com;kuba@kernel.org;pabeni@redhat.com;francesco@dolcini.i
> t
> > ;briannorris@chromium.org
> 
> AFAICT, you didn't actually fix anything. That's a months-old list (plus
> manually adding me). Did you run scripts/get_maintainer.pl on a recent
> wireless-next tree? Mine looks like this:
> 
> $ scripts/get_maintainer.pl -f drivers/net/wireless/marvell/mwifiex/main.c
> Brian Norris <briannorris@chromium.org> (odd fixer:MARVELL MWIFIEX
> WIRELESS DRIVER) Kalle Valo <kvalo@kernel.org> (maintainer:NETWORKING
> DRIVERS (WIRELESS)) linux-wireless@vger.kernel.org (open list:MARVELL
> MWIFIEX WIRELESS DRIVER) linux-kernel@vger.kernel.org (open list)

dlin@dlin-Aspire-A514-54G:~/projects/nxp/LinuxWireless/working/wireless-testing$ ./scripts/get_maintainer.pl --no-git-fallback --no-roles --no-rolestats drivers/net/wireless/marvell/mwifiex/
Brian Norris <briannorris@chromium.org>
Kalle Valo <kvalo@kernel.org>
linux-wireless@vger.kernel.org
linux-kernel@vger.kernel.org

I updated my mailing list as follows and I will use it for future mwifiex patches:

<<mwifiex mailing list>>
linux-wireless@vger.kernel.org
linux-kernel@vger.kernel.org;briannorris@chromium.org;kvalo@kernel.org;francesco@dolcini.it;sharvari.harisangam@nxp.com;yu-hao.lin@nxp.com;tsung-hsien.hsieh@nxp.com

Thanks for your help.