mbox series

[0/3] Add support for GPMC NAND

Message ID 20230913114711.2937844-1-n-yadav@ti.com
Headers show
Series Add support for GPMC NAND | expand

Message

Nitin Yadav Sept. 13, 2023, 11:47 a.m. UTC 
This series adds support for GPMC NAND on AM62x LP SK
board.

Nitin Yadav (3):
  arm64: dts: ti: Add GPMC NAND support
  arm64: dts: ti: Add GPMC NAND overlay
  arm64: defconfig: Enable GPMC NAND support

 arch/arm64/boot/dts/ti/Makefile               |   1 +
 .../arm64/boot/dts/ti/k3-am62-lp-sk-nand.dtso | 119 ++++++++++++++++++
 arch/arm64/boot/dts/ti/k3-am62-main.dtsi      |  29 +++++
 arch/arm64/boot/dts/ti/k3-am62.dtsi           |   2 +
 arch/arm64/configs/defconfig                  |   3 +
 5 files changed, 154 insertions(+)
 create mode 100644 arch/arm64/boot/dts/ti/k3-am62-lp-sk-nand.dtso

Comments

Nishanth Menon Sept. 14, 2023, 4:04 p.m. UTC | #1 
On 14:56-20230914, Nitin Yadav wrote:
> Hi Krzysztof,
> 
> On 14/09/23 11:57, Krzysztof Kozlowski wrote:
> > On 13/09/2023 13:47, Nitin Yadav wrote:
> >> Add support for AM62Q NAND card: X8 NAND EXPANSION
> >> BOARD card (PROC143E1) for AM62x LP SK board.

Commit message is all too wrong as well. Sigh.

> >>
> >> Signed-off-by: Nitin Yadav <n-yadav@ti.com>
> >> ---
> >>  arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 29 ++++++++++++++++++++++++
> >>  arch/arm64/boot/dts/ti/k3-am62.dtsi      |  2 ++
> >>  2 files changed, 31 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> >> index 284b90c94da8..e93e79d8083f 100644
> >> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> >> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> >> @@ -955,4 +955,33 @@ mcasp2: audio-controller@2b20000 {
> >>  		power-domains = <&k3_pds 192 TI_SCI_PD_EXCLUSIVE>;
> >>  		status = "disabled";
> >>  	};
> >> +	gpmc0: memory-controller@3b000000 {
> >> +		status = "disabled";
> > 
> > status is never first in DTSI. Really, where did you see such code?
> Thank for pointing out, Will send a revised version.

GPMC is not functional without board specific interface configuration
such as pinmux. this approach, in fact is all over the place now and
discussed in the mailing list multiple times now.

What is missing here is the documentation of the constraints as to why
it is set as disabled by default.


> > 
> >> +		compatible = "ti,am64-gpmc";
> >> +		power-domains = <&k3_pds 80 TI_SCI_PD_EXCLUSIVE>;
> > 
> > First is compatible, second is reg/reg-names/ranges.
> > 
> > 
> > Best regards,
> > Krzysztof
> > 
> 
> -- 
> Regards,
> Nitin