| Message ID | 20230828102329.20867-1-aboutphysycs@gmail.com |
|---|---|
| State | Accepted |
| Commit | 4ff6244696eed0f08398ca500758c85d4b935094 |
| Headers | show |
| Series | char: hw_random: xgene-rng: removed unneeded call to platform_set_drvdata() | expand |
On Mon, Aug 28, 2023 at 2:48 PM Martin Kaiser <lists@kaiser.cx> wrote: > > Andrei Coardos (aboutphysycs@gmail.com) wrote: > > > This function call was found to be unnecessary as there is no equivalent > > platform_get_drvdata() call to access the private data of the driver. Also, > > the private data is defined in this driver, so there is no risk of it being > > accessed outside of this driver file. > > > Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com> > > --- > > drivers/char/hw_random/xgene-rng.c | 1 - > > 1 file changed, 1 deletion(-) > > > diff --git a/drivers/char/hw_random/xgene-rng.c b/drivers/char/hw_random/xgene-rng.c > > index 7c8f3cb7c6af..9d64b5931a27 100644 > > --- a/drivers/char/hw_random/xgene-rng.c > > +++ b/drivers/char/hw_random/xgene-rng.c > > @@ -321,7 +321,6 @@ static int xgene_rng_probe(struct platform_device *pdev) > > return -ENOMEM; > > > ctx->dev = &pdev->dev; > > - platform_set_drvdata(pdev, ctx); > > > ctx->csr_base = devm_platform_ioremap_resource(pdev, 0); > > if (IS_ERR(ctx->csr_base)) > > -- > > 2.34.1 > > This one's ok, too. 67fb1e295839 ("hwrng: xgene - Simplify using > devm_clk_get_optional_enabled()") removed the platform_get_drvdata call. > Reviewed-by: Alexandru Ardelean <alex@shruggie.ro> > Reviewed-by: Martin Kaiser <martin@kaiser.cx>
On Mon, Aug 28, 2023 at 01:23:29PM +0300, Andrei Coardos wrote: > This function call was found to be unnecessary as there is no equivalent > platform_get_drvdata() call to access the private data of the driver. Also, > the private data is defined in this driver, so there is no risk of it being > accessed outside of this driver file. > > Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com> > --- > drivers/char/hw_random/xgene-rng.c | 1 - > 1 file changed, 1 deletion(-) Patch applied. Thanks.
diff --git a/drivers/char/hw_random/xgene-rng.c b/drivers/char/hw_random/xgene-rng.c index 7c8f3cb7c6af..9d64b5931a27 100644 --- a/drivers/char/hw_random/xgene-rng.c +++ b/drivers/char/hw_random/xgene-rng.c @@ -321,7 +321,6 @@ static int xgene_rng_probe(struct platform_device *pdev) return -ENOMEM; ctx->dev = &pdev->dev; - platform_set_drvdata(pdev, ctx); ctx->csr_base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(ctx->csr_base))
This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file. Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com> --- drivers/char/hw_random/xgene-rng.c | 1 - 1 file changed, 1 deletion(-)