diff mbox series

wifi: rtlwifi: Fix spelling mistake "nerver" -> "never"

Message ID 20230902090808.67926-1-shubhisroking@gmail.com
State New
Headers show
Series wifi: rtlwifi: Fix spelling mistake "nerver" -> "never" | expand

Commit Message

Shubh Sept. 2, 2023, 9:08 a.m. UTC
Signed-off-by: Shubh <shubhisroking@gmail.com>
---
 drivers/net/wireless/realtek/rtlwifi/base.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ping-Ke Shih Sept. 4, 2023, 1:34 a.m. UTC | #1
> -----Original Message-----
> From: Shubh <shubhisroking@gmail.com>
> Sent: Saturday, September 2, 2023 5:08 PM
> To: Ping-Ke Shih <pkshih@realtek.com>
> Cc: linux-wireless@vger.kernel.org; Shubh <shubhisroking@gmail.com>
> Subject: [PATCH] wifi: rtlwifi: Fix spelling mistake "nerver" -> "never"
> 

I think any patch needs commit message. Even, a simple patch like this.

Others look good to me. 


> Signed-off-by: Shubh <shubhisroking@gmail.com>
> ---
>  drivers/net/wireless/realtek/rtlwifi/base.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c b/drivers/net/wireless/realtek/rtlwifi/base.c
> index 807a53a97..679bdc46d 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/base.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/base.c
> @@ -1265,7 +1265,7 @@ void rtl_get_tcb_desc(struct ieee80211_hw *hw,
>                         tcb_desc->disable_ratefallback = 1;
>                 } else {
>                         /*
> -                        *because hw will nerver use hw_rate
> +                        *because hw will never use hw_rate
>                          *when tcb_desc->use_driver_rate = false
>                          *so we never set highest N rate here,
>                          *and N rate will all be controlled by FW
> --
> 2.42.0
Ping-Ke Shih Sept. 4, 2023, 5:36 a.m. UTC | #2
On Mon, 2023-09-04 at 10:29 +0530, Shubh wrote:
> 
> So, is it accepted, right? Also, what do you mean by 'I think any patch needs a commit message,
> even a simple patch like this'? Am I missing something? Like, I didn't include a commit message?
> Because as I can see, I have commit message in the subject of the email. Please feel free to
> correct me.
> 

Not only include a subject but some description that I meant before. 

By the way, no top posting and should reply in plain text mode.
diff mbox series

Patch

diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c b/drivers/net/wireless/realtek/rtlwifi/base.c
index 807a53a97..679bdc46d 100644
--- a/drivers/net/wireless/realtek/rtlwifi/base.c
+++ b/drivers/net/wireless/realtek/rtlwifi/base.c
@@ -1265,7 +1265,7 @@  void rtl_get_tcb_desc(struct ieee80211_hw *hw,
 			tcb_desc->disable_ratefallback = 1;
 		} else {
 			/*
-			 *because hw will nerver use hw_rate
+			 *because hw will never use hw_rate
 			 *when tcb_desc->use_driver_rate = false
 			 *so we never set highest N rate here,
 			 *and N rate will all be controlled by FW