| Message ID | 1689751218-24492-1-git-send-email-quic_krichai@quicinc.com |
|---|---|
| Headers | show |
| Series | PCI: qcom: ep: Add basic interconnect support | expand |
On Wed, Jul 19, 2023 at 12:50:14PM +0530, Krishna chaitanya chundru wrote: > Add basic support for managing "pcie-mem" interconnect path by setting > a low constraint before enabling clocks and updating it after the link > is up based on link speed and width the device got enumerated. > Krzysztof, can this series be merged for 6.6? Bjorn A will pick the dts patches. - Mani > changes from v9: > - addressed the comments by mani. > changes from v8: > - Added cpu to pcie path in dtsi and in dtsi binding. > changes from v7: > - setting icc bw to '0' in disable resources as suggested by mani. > changes from v6: > - addressed the comments as suggested by mani. > changes from v5: > - addressed the comments by mani. > changes from v4: > - rebased with linux-next. > - Added comments as suggested by mani. > - removed the arm: dts: qcom: sdx55: Add interconnect path > as that patch is already applied. > changes from v3: > - ran make DT_CHECKER_FLAGS=-m dt_binding_check and fixed > errors. > - Added macros in the qcom ep driver patch as suggested by Dmitry > changes from v2: > - changed the logic for getting speed and width as suggested > by bjorn. > - fixed compilation errors. > > > Krishna chaitanya chundru (4): > PCI: qcom-ep: Add ICC bandwidth voting support > arm: dts: qcom: sdx65: Add PCIe EP interconnect path > arm: dts: qcom: sdx55: Add CPU PCIe EP interconnect path > dt-bindings: PCI: qcom: ep: Add interconnects path > > .../devicetree/bindings/pci/qcom,pcie-ep.yaml | 15 +++++ > arch/arm/boot/dts/qcom/qcom-sdx55.dtsi | 5 +- > arch/arm/boot/dts/qcom/qcom-sdx65.dtsi | 4 ++ > drivers/pci/controller/dwc/pcie-qcom-ep.c | 71 ++++++++++++++++++++++ > 4 files changed, 93 insertions(+), 2 deletions(-) > > -- > 2.7.4 >
On 7/28/2023 8:26 AM, Manivannan Sadhasivam wrote: > On Wed, Jul 19, 2023 at 12:50:14PM +0530, Krishna chaitanya chundru wrote: >> Add basic support for managing "pcie-mem" interconnect path by setting >> a low constraint before enabling clocks and updating it after the link >> is up based on link speed and width the device got enumerated. >> > Krzysztof, can this series be merged for 6.6? Bjorn A will pick the dts patches. > > - Mani A Gentle ping - KC >> changes from v9: >> - addressed the comments by mani. >> changes from v8: >> - Added cpu to pcie path in dtsi and in dtsi binding. >> changes from v7: >> - setting icc bw to '0' in disable resources as suggested by mani. >> changes from v6: >> - addressed the comments as suggested by mani. >> changes from v5: >> - addressed the comments by mani. >> changes from v4: >> - rebased with linux-next. >> - Added comments as suggested by mani. >> - removed the arm: dts: qcom: sdx55: Add interconnect path >> as that patch is already applied. >> changes from v3: >> - ran make DT_CHECKER_FLAGS=-m dt_binding_check and fixed >> errors. >> - Added macros in the qcom ep driver patch as suggested by Dmitry >> changes from v2: >> - changed the logic for getting speed and width as suggested >> by bjorn. >> - fixed compilation errors. >> >> >> Krishna chaitanya chundru (4): >> PCI: qcom-ep: Add ICC bandwidth voting support >> arm: dts: qcom: sdx65: Add PCIe EP interconnect path >> arm: dts: qcom: sdx55: Add CPU PCIe EP interconnect path >> dt-bindings: PCI: qcom: ep: Add interconnects path >> >> .../devicetree/bindings/pci/qcom,pcie-ep.yaml | 15 +++++ >> arch/arm/boot/dts/qcom/qcom-sdx55.dtsi | 5 +- >> arch/arm/boot/dts/qcom/qcom-sdx65.dtsi | 4 ++ >> drivers/pci/controller/dwc/pcie-qcom-ep.c | 71 ++++++++++++++++++++++ >> 4 files changed, 93 insertions(+), 2 deletions(-) >> >> -- >> 2.7.4 >>
On 29/08/2023 13:41, Krishna Chaitanya Chundru wrote: > > On 7/28/2023 8:26 AM, Manivannan Sadhasivam wrote: >> On Wed, Jul 19, 2023 at 12:50:14PM +0530, Krishna chaitanya chundru wrote: >>> Add basic support for managing "pcie-mem" interconnect path by setting >>> a low constraint before enabling clocks and updating it after the link >>> is up based on link speed and width the device got enumerated. >>> >> Krzysztof, can this series be merged for 6.6? Bjorn A will pick the dts patches. >> >> - Mani > > A Gentle ping > Whom do you ping and why me? If you choose not to use scripts/get_maintainers.pl, it's your right, but then you might get maintainers wrong and no surprise patches got not accepted... Plus, it's merge window, so why pinging now? Best regards, Krzysztof
On 29/08/2023 14:10, Krishna Chaitanya Chundru wrote: >>>> Krzysztof, can this series be merged for 6.6? Bjorn A will pick the dts patches. >>>> >>>> - Mani >>> A Gentle ping >>> >> Whom do you ping and why me? If you choose not to use >> scripts/get_maintainers.pl, it's your right, but then you might get >> maintainers wrong and no surprise patches got not accepted... >> >> Plus, it's merge window, so why pinging now? >> >> Best regards, >> Krzysztof > > Krzyszto, > > The series is already reviewed and there are some patches which is > reviewed by you also. > > I am using this command to send patches it looks like this script is > fetching based upon the source file where there was change due to that > only I was seeing the problem of all patches are not going to all the > maintainers. > > --cc-cmd=scripts/get_maintainer.pl ./patch-series > > I was trying to install b4 and make sure to send all patches to all the > maintainers next time on wards. This looks good. > > we pinged it now so that as this is already reviewed and no comments on > this series so that this can picked up. And what is has anything to do with me? You got everything needed from me, don't you? Anyway, do not ping during merge window. Best regards, Krzysztof
On 29/08/2023 14:13, Krishna Chaitanya Chundru wrote: > > On 8/29/2023 5:26 PM, Krzysztof Kozlowski wrote: >> On 29/08/2023 13:41, Krishna Chaitanya Chundru wrote: >>> On 7/28/2023 8:26 AM, Manivannan Sadhasivam wrote: >>>> On Wed, Jul 19, 2023 at 12:50:14PM +0530, Krishna chaitanya chundru wrote: >>>>> Add basic support for managing "pcie-mem" interconnect path by setting >>>>> a low constraint before enabling clocks and updating it after the link >>>>> is up based on link speed and width the device got enumerated. >>>>> >>>> Krzysztof, can this series be merged for 6.6? Bjorn A will pick the dts patches. >>>> >>>> - Mani >>> A Gentle ping >>> >> Whom do you ping and why me? If you choose not to use >> scripts/get_maintainers.pl, it's your right, but then you might get >> maintainers wrong and no surprise patches got not accepted... >> >> Plus, it's merge window, so why pinging now? >> >> Best regards, >> Krzysztof > > Krzyszto, > > The series is already reviewed and there are some patches which is > reviewed by you also. > > I am using the same command to send patches it looks like this script is > fetching based upon the source file where there was change due to that > only I was seeing the problem of all patches are not going to all the > maintainers. > > I was trying to install b4 and make sure to send all patches to all the > maintainers next time on wards. > > we pinged it now so that as this is already reviewed and no comments on > this series so that this can picked up. It is the fifth same email from you. With just few differences. Please stop. Please fix your email client. Best regards, Krzysztof
On 8/29/2023 5:42 PM, Krzysztof Kozlowski wrote: > On 29/08/2023 14:10, Krishna Chaitanya Chundru wrote: >>>>> Krzysztof, can this series be merged for 6.6? Bjorn A will pick the dts patches. >>>>> >>>>> - Mani >>>> A Gentle ping >>>> >>> Whom do you ping and why me? If you choose not to use >>> scripts/get_maintainers.pl, it's your right, but then you might get >>> maintainers wrong and no surprise patches got not accepted... >>> >>> Plus, it's merge window, so why pinging now? >>> >>> Best regards, >>> Krzysztof >> Krzyszto, >> >> The series is already reviewed and there are some patches which is >> reviewed by you also. >> >> I am using this command to send patches it looks like this script is >> fetching based upon the source file where there was change due to that >> only I was seeing the problem of all patches are not going to all the >> maintainers. >> >> --cc-cmd=scripts/get_maintainer.pl ./patch-series >> >> I was trying to install b4 and make sure to send all patches to all the >> maintainers next time on wards. > This looks good. > >> we pinged it now so that as this is already reviewed and no comments on >> this series so that this can picked up. > And what is has anything to do with me? You got everything needed from > me, don't you? > > Anyway, do not ping during merge window. > > > Best regards, > Krzysztof I meant to ping all maintainers I should pinged as new reply to cover message instead of replying back to mani's comment. sure Krzysztof we will make sure we don't ping in merge window. - KC I >
On 8/29/2023 5:44 PM, Krzysztof Kozlowski wrote: > On 29/08/2023 14:13, Krishna Chaitanya Chundru wrote: >> On 8/29/2023 5:26 PM, Krzysztof Kozlowski wrote: >>> On 29/08/2023 13:41, Krishna Chaitanya Chundru wrote: >>>> On 7/28/2023 8:26 AM, Manivannan Sadhasivam wrote: >>>>> On Wed, Jul 19, 2023 at 12:50:14PM +0530, Krishna chaitanya chundru wrote: >>>>>> Add basic support for managing "pcie-mem" interconnect path by setting >>>>>> a low constraint before enabling clocks and updating it after the link >>>>>> is up based on link speed and width the device got enumerated. >>>>>> >>>>> Krzysztof, can this series be merged for 6.6? Bjorn A will pick the dts patches. >>>>> >>>>> - Mani >>>> A Gentle ping >>>> >>> Whom do you ping and why me? If you choose not to use >>> scripts/get_maintainers.pl, it's your right, but then you might get >>> maintainers wrong and no surprise patches got not accepted... >>> >>> Plus, it's merge window, so why pinging now? >>> >>> Best regards, >>> Krzysztof >> Krzyszto, >> >> The series is already reviewed and there are some patches which is >> reviewed by you also. >> >> I am using the same command to send patches it looks like this script is >> fetching based upon the source file where there was change due to that >> only I was seeing the problem of all patches are not going to all the >> maintainers. >> >> I was trying to install b4 and make sure to send all patches to all the >> maintainers next time on wards. >> >> we pinged it now so that as this is already reviewed and no comments on >> this series so that this can picked up. > It is the fifth same email from you. With just few differences. Please > stop. Please fix your email client. > > Best regards, > Krzysztof I got a mail saying message was not delivered saying there is some html code, I taught it didn't send and trying to send again few changes. Please ignore other mails, sorry for the trouble. - KC
Hello, > Add basic support for managing "pcie-mem" interconnect path by setting > a low constraint before enabling clocks and updating it after the link > is up based on link speed and width the device got enumerated. Applied to controller/qcom-ep, thank you! [1/4] dt-bindings: PCI: qcom: ep: Add interconnects path https://git.kernel.org/pci/pci/c/e590ad240ff0 [4/4] PCI: qcom-ep: Add ICC bandwidth voting support https://git.kernel.org/pci/pci/c/0c104996e6a8 Krzysztof
On Tue, Aug 29, 2023 at 05:40:10PM +0530, Krishna Chaitanya Chundru wrote: > > On 8/29/2023 5:26 PM, Krzysztof Kozlowski wrote: > > On 29/08/2023 13:41, Krishna Chaitanya Chundru wrote: > > > On 7/28/2023 8:26 AM, Manivannan Sadhasivam wrote: > > > > On Wed, Jul 19, 2023 at 12:50:14PM +0530, Krishna chaitanya chundru wrote: > > > > > Add basic support for managing "pcie-mem" interconnect path by setting > > > > > a low constraint before enabling clocks and updating it after the link > > > > > is up based on link speed and width the device got enumerated. > > > > > > > > > Krzysztof, can this series be merged for 6.6? Bjorn A will pick the dts patches. > > > > > > > > - Mani > > > A Gentle ping > > > > > Whom do you ping and why me? If you choose not to use > > scripts/get_maintainers.pl, it's your right, but then you might get > > maintainers wrong and no surprise patches got not accepted... > > > > Plus, it's merge window, so why pinging now? > > > > Best regards, > > Krzysztof > > Krzyszto, > > The series is already reviewed and there are some patches which is reviewed > by you also. > > I am using this command to send patches it looks like this script is > fetching based upon the source file where there was change due to that only > I was seeing the problem of all patches are not going to all the > maintainers. > > --cc-cmd=scripts/get_maintainer.pl ./patch-series > > I was trying to install b4 and make sure to send all patches to all the > maintainers next time on wards. > > we pinged it now so that as this is already reviewed and no comments on this > series so that this can picked up. > FWIW, it was me who pinged Krzysztof first. But I was referring to Krzysztof Wilczyński, who is the PCI controller drivers maintainer. I thought you CCed all the relevant people, but just noticed that you didn't :/ Please fix it as you promised. Anyway, since the merge window is now open, this series has to wait for 6.7. - Mani > > - KC
Hello, > > Add basic support for managing "pcie-mem" interconnect path by setting > > a low constraint before enabling clocks and updating it after the link > > is up based on link speed and width the device got enumerated. > > > > Krzysztof, can this series be merged for 6.6? Bjorn A will pick the dts patches. Applied. Sorry for the delay. That said, it's now up to Bjorn (Bjorn Helgaas) to take it, or let it slide for 6.7, depending on how far he has got with his Pull Request. Krzysztof
Add basic support for managing "pcie-mem" interconnect path by setting a low constraint before enabling clocks and updating it after the link is up based on link speed and width the device got enumerated. changes from v9: - addressed the comments by mani. changes from v8: - Added cpu to pcie path in dtsi and in dtsi binding. changes from v7: - setting icc bw to '0' in disable resources as suggested by mani. changes from v6: - addressed the comments as suggested by mani. changes from v5: - addressed the comments by mani. changes from v4: - rebased with linux-next. - Added comments as suggested by mani. - removed the arm: dts: qcom: sdx55: Add interconnect path as that patch is already applied. changes from v3: - ran make DT_CHECKER_FLAGS=-m dt_binding_check and fixed errors. - Added macros in the qcom ep driver patch as suggested by Dmitry changes from v2: - changed the logic for getting speed and width as suggested by bjorn. - fixed compilation errors. Krishna chaitanya chundru (4): PCI: qcom-ep: Add ICC bandwidth voting support arm: dts: qcom: sdx65: Add PCIe EP interconnect path arm: dts: qcom: sdx55: Add CPU PCIe EP interconnect path dt-bindings: PCI: qcom: ep: Add interconnects path .../devicetree/bindings/pci/qcom,pcie-ep.yaml | 15 +++++ arch/arm/boot/dts/qcom/qcom-sdx55.dtsi | 5 +- arch/arm/boot/dts/qcom/qcom-sdx65.dtsi | 4 ++ drivers/pci/controller/dwc/pcie-qcom-ep.c | 71 ++++++++++++++++++++++ 4 files changed, 93 insertions(+), 2 deletions(-)