| Message ID | 20230825220854.1655162-3-dmitry.baryshkov@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/5] arm64: dts: qcom: sdm845-mtp: fix WiFi configuration | expand |
On 26.08.2023 00:08, Dmitry Baryshkov wrote: > We have switched most of devices to use mbn (squashed) firmware files > instead of spit mdt+bNN. Even this DT uses modem.mbn and a630_zap.mbn. > Let's switch adsp and cdsp firmware files to use .mbn format too. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- Looks like 845 was mbn from the start https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/log/qcom/sdm845?qt=grep&q= > arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts > index 56f5bf52d9bd..7579ba66c6d8 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts > @@ -114,7 +114,7 @@ trip-point { > > &adsp_pas { > status = "okay"; > - firmware-name = "qcom/sdm845/adsp.mdt"; > + firmware-name = "qcom/sdm845/adsp.mbn"; > }; > > &apps_rsc { > @@ -415,7 +415,7 @@ vreg_s3c_0p6: smps3 { > > &cdsp_pas { > status = "okay"; > - firmware-name = "qcom/sdm845/cdsp.mdt"; > + firmware-name = "qcom/sdm845/cdsp.mbn"; > }; > > &gcc {
On Sat, 26 Aug 2023 at 12:00, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > > On 26.08.2023 00:08, Dmitry Baryshkov wrote: > > We have switched most of devices to use mbn (squashed) firmware files > > instead of spit mdt+bNN. Even this DT uses modem.mbn and a630_zap.mbn. > > Let's switch adsp and cdsp firmware files to use .mbn format too. > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > --- > Looks like 845 was mbn from the start > > https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/log/qcom/sdm845?qt=grep&q= sdm845-mtp predates these files. So is there an r-b? > > arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts > > index 56f5bf52d9bd..7579ba66c6d8 100644 > > --- a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts > > +++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts > > @@ -114,7 +114,7 @@ trip-point { > > > > &adsp_pas { > > status = "okay"; > > - firmware-name = "qcom/sdm845/adsp.mdt"; > > + firmware-name = "qcom/sdm845/adsp.mbn"; > > }; > > > > &apps_rsc { > > @@ -415,7 +415,7 @@ vreg_s3c_0p6: smps3 { > > > > &cdsp_pas { > > status = "okay"; > > - firmware-name = "qcom/sdm845/cdsp.mdt"; > > + firmware-name = "qcom/sdm845/cdsp.mbn"; > > }; > > > > &gcc {
On 26.08.2023 15:57, Dmitry Baryshkov wrote: > On Sat, 26 Aug 2023 at 12:00, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: >> >> On 26.08.2023 00:08, Dmitry Baryshkov wrote: >>> We have switched most of devices to use mbn (squashed) firmware files >>> instead of spit mdt+bNN. Even this DT uses modem.mbn and a630_zap.mbn. >>> Let's switch adsp and cdsp firmware files to use .mbn format too. >>> >>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >>> --- >> Looks like 845 was mbn from the start >> >> https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/log/qcom/sdm845?qt=grep&q= > > sdm845-mtp predates these files. So is there an r-b? Yes, I hit enter too fast Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts index 56f5bf52d9bd..7579ba66c6d8 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts +++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts @@ -114,7 +114,7 @@ trip-point { &adsp_pas { status = "okay"; - firmware-name = "qcom/sdm845/adsp.mdt"; + firmware-name = "qcom/sdm845/adsp.mbn"; }; &apps_rsc { @@ -415,7 +415,7 @@ vreg_s3c_0p6: smps3 { &cdsp_pas { status = "okay"; - firmware-name = "qcom/sdm845/cdsp.mdt"; + firmware-name = "qcom/sdm845/cdsp.mbn"; }; &gcc {
We have switched most of devices to use mbn (squashed) firmware files instead of spit mdt+bNN. Even this DT uses modem.mbn and a630_zap.mbn. Let's switch adsp and cdsp firmware files to use .mbn format too. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)