| Message ID | 20230823111555.3734-1-aboutphysycs@gmail.com |
|---|---|
| State | Accepted |
| Commit | 75b2d50d0d7ffae34eefa5a31d8c6ae84496dfd0 |
| Headers | show |
| Series | char: hw_random: bcm2835-rng: removed call to platform_set_drvdata() | expand |
Andrei Coardos (aboutphysycs@gmail.com) wrote: > This function call was found to be unnecessary as there is no equivalent > platform_get_drvdata() call to access the private data of the driver. Also, > the private data is defined in this driver, so there is no risk of it being > accessed outside of this driver file. You're right. The platform_get_drvdata call was removed in 4c04b3729 ("hwrng: bcm2835 - Use device managed helpers"). Reviewed-by: Martin Kaiser <martin@kaiser.cx>
On Wed, Aug 23, 2023 at 2:59 PM Martin Kaiser <lists@kaiser.cx> wrote: > > Andrei Coardos (aboutphysycs@gmail.com) wrote: > > > This function call was found to be unnecessary as there is no equivalent > > platform_get_drvdata() call to access the private data of the driver. Also, > > the private data is defined in this driver, so there is no risk of it being > > accessed outside of this driver file. > > You're right. The platform_get_drvdata call was removed in > 4c04b3729 ("hwrng: bcm2835 - Use device managed helpers"). > Reviewed-by: Alexandru Ardelean <alex@shruggie.ro> > Reviewed-by: Martin Kaiser <martin@kaiser.cx>
On Wed, Aug 23, 2023 at 02:15:55PM +0300, Andrei Coardos wrote: > This function call was found to be unnecessary as there is no equivalent > platform_get_drvdata() call to access the private data of the driver. Also, > the private data is defined in this driver, so there is no risk of it being > accessed outside of this driver file. > > Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com> > --- > drivers/char/hw_random/bcm2835-rng.c | 2 -- > 1 file changed, 2 deletions(-) Patch applied. Thanks.
diff --git a/drivers/char/hw_random/bcm2835-rng.c b/drivers/char/hw_random/bcm2835-rng.c index e98fcac578d6..0238f487f9ab 100644 --- a/drivers/char/hw_random/bcm2835-rng.c +++ b/drivers/char/hw_random/bcm2835-rng.c @@ -150,8 +150,6 @@ static int bcm2835_rng_probe(struct platform_device *pdev) if (!priv) return -ENOMEM; - platform_set_drvdata(pdev, priv); - /* map peripheral */ priv->base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(priv->base))
This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file. Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com> --- drivers/char/hw_random/bcm2835-rng.c | 2 -- 1 file changed, 2 deletions(-)