mbox series

[v3,0/9] Use dev_err_probe in i2c probe function

Message ID 20230808012954.1643834-1-liaochang1@huawei.com
Headers show
Series Use dev_err_probe in i2c probe function | expand

Message

Liao Chang Aug. 8, 2023, 1:29 a.m. UTC 
Use the dev_err_probe function instead of dev_err in the probe function
so that the printed messge includes the return value and also handles
-EPROBE_DEFER nicely.

NOTICE: dev_err_probe always print the second parameter that happens to
be the return value, hence the return errno will be removed from the
third parameter to avoid a redundant error message.

v3:
Convert all dev_err() in synquacer_i2c_probe() to dev_err_probe()
even if the return value is known to never be -EPROBE_DEFER.

v2:
1. Convert all dev_err() in lpi2c_imx_probe(), synquacer_i2c_probe(),
   mlxbf_i2c_probe() to dev_err_probe().
2. Add Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
3. Add Reviewed-by: Yicong Yang <yangyicong@hisilicon.com>
4. Add Reviewed-by: Andi Shyti <andi.shyti@kernel.com>

Liao Chang (9):
  i2c: bcm2835: Use dev_err_probe in probe function
  i2c: mlxbf: Use dev_err_probe in probe function
  i2c: xlp9xx: Use dev_err_probe in probe function
  i2c: hisi: Use dev_err_probe in probe function
  i2c: qcom-cci: Use dev_err_probe in probe function
  i2c: pxa: Use dev_err_probe in probe function
  i2c: dln2: Use dev_err_probe in probe function
  i2c: imx-lpi2c: Use dev_err_probe in probe function
  i2c: synquacer: Use dev_err_probe in probe function

 drivers/i2c/busses/i2c-bcm2835.c   | 14 ++++-----
 drivers/i2c/busses/i2c-dln2.c      |  6 ++--
 drivers/i2c/busses/i2c-hisi.c      | 12 +++----
 drivers/i2c/busses/i2c-imx-lpi2c.c | 12 +++----
 drivers/i2c/busses/i2c-mlxbf.c     | 50 ++++++++++--------------------
 drivers/i2c/busses/i2c-pxa.c       |  7 ++---
 drivers/i2c/busses/i2c-qcom-cci.c  |  6 ++--
 drivers/i2c/busses/i2c-synquacer.c | 28 ++++++-----------
 drivers/i2c/busses/i2c-xlp9xx.c    |  6 ++--
 9 files changed, 50 insertions(+), 91 deletions(-)

Comments

Wolfram Sang Aug. 14, 2023, 3:16 p.m. UTC | #1 
On Thu, Aug 10, 2023 at 10:19:35AM +0200, Andi Shyti wrote:
> Hi
> 
> On Tue, 08 Aug 2023 09:29:45 +0800, Liao Chang wrote:
> > Use the dev_err_probe function instead of dev_err in the probe function
> > so that the printed messge includes the return value and also handles
> > -EPROBE_DEFER nicely.
> > 
> > NOTICE: dev_err_probe always print the second parameter that happens to
> > be the return value, hence the return errno will be removed from the
> > third parameter to avoid a redundant error message.
> > 
> > [...]

Applied to for-next (via Andi's branch), thanks!