mbox series

[v3,0/3] Add no-esim sku for sc7180-lazor family and new board version

Message ID 20230809064908.193739-1-sheng-liang.pan@quanta.corp-partner.google.com
Headers show
Series Add no-esim sku for sc7180-lazor family and new board version | expand

Message

Sheng-Liang Pan Aug. 9, 2023, 6:49 a.m. UTC 
for audio codec ALC5682i-VS.

Changes in v3:
- correct corresponding of new board and new sku
- sort out the node order alphabetically

Changes in v2:
- add new entry rev9 with Parade bridge chip
- correct newly create dts files

Sheng-Liang Pan (3):
  dt-bindings: arm: qcom: add sc7180-lazor board bindings
  arm64: dts: qcom: sc7180: Add sku_id for lazor/limozeen
  arm64: dts: qcom: sc7180: Add board id for lazor/limozeen

 .../devicetree/bindings/arm/qcom.yaml         | 31 ++++++++++
 arch/arm64/boot/dts/qcom/Makefile             |  5 ++
 ...sc7180-trogdor-lazor-limozeen-nots-r10.dts | 40 +++++++++++++
 .../sc7180-trogdor-lazor-limozeen-nots-r9.dts |  4 +-
 .../sc7180-trogdor-lazor-limozeen-r10.dts     | 56 +++++++++++++++++++
 .../qcom/sc7180-trogdor-lazor-limozeen-r9.dts |  4 +-
 .../dts/qcom/sc7180-trogdor-lazor-r10-kb.dts  | 34 +++++++++++
 .../dts/qcom/sc7180-trogdor-lazor-r10-lte.dts | 38 +++++++++++++
 .../dts/qcom/sc7180-trogdor-lazor-r10.dts     | 30 ++++++++++
 .../dts/qcom/sc7180-trogdor-lazor-r9-kb.dts   |  4 +-
 .../dts/qcom/sc7180-trogdor-lazor-r9-lte.dts  |  4 +-
 .../boot/dts/qcom/sc7180-trogdor-lazor-r9.dts |  4 +-
 12 files changed, 244 insertions(+), 10 deletions(-)
 create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r10.dts
 create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-r10.dts
 create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r10-kb.dts
 create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r10-lte.dts
 create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r10.dts

Comments

Krzysztof Kozlowski Aug. 10, 2023, 11:27 a.m. UTC | #1 
On 10/08/2023 11:30, Sheng-Liang Pan wrote:
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
>> Isn't this duplicated with r9? Probably other places as well... or....
>> separate r10 add rt5682s node which different with r9.
> we separate r10 add rt5682s which differentwith r9
> 
> 
>>> -	model = "Google Lazor Limozeen without Touchscreen (rev9+)";
>>> -	compatible = "google,lazor-sku6", "google,lazor-sku18", "qcom,sc7180";
>>> +	model = "Google Lazor Limozeen without Touchscreen (rev9)";
>>> +	compatible = "google,lazor-rev9-sku6", "google,lazor-rev9-sku18", "qcom,sc7180";
> 
>> Your patch 2 does not make any sense. Didn't you touch it in patch 2?
>> Really, what is happening here?
> patch 2 explain why we added new sku for no-eSIM.

So which commit explain why you touch the same line twice? Sorry, this
does not make sense.

Best regards,
Krzysztof
Krzysztof Kozlowski Aug. 14, 2023, 8:01 a.m. UTC | #2 
On 11/08/2023 05:46, Sheng-Liang Pan wrote:
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> On 10/08/2023 11:30, Sheng-Liang Pan wrote:
>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>
>>>> Isn't this duplicated with r9? Probably other places as well... or....
>>>> separate r10 add rt5682s node which different with r9.
>>> we separate r10 add rt5682s which differentwith r9
>>>
>>>
>>>>> -	model = "Google Lazor Limozeen without Touchscreen (rev9+)";
>>>>> -	compatible = "google,lazor-sku6", "google,lazor-sku18", "qcom,sc7180";
>>>>> +	model = "Google Lazor Limozeen without Touchscreen (rev9)";
>>>>> +	compatible = "google,lazor-rev9-sku6", "google,lazor-rev9-sku18", "qcom,sc7180";
>>>
>>>> Your patch 2 does not make any sense. Didn't you touch it in patch 2?
>>>> Really, what is happening here?
>>> patch 2 explain why we added new sku for no-eSIM.
>>
>> So which commit explain why you touch the same line twice? Sorry, this
>> does not make sense.
>>
>> Best regards,
>> Krzysztof
> 
> We sort patch by change order,
> fist request for non-eSIM, patch2 add new sku 10, 15 for non-eSIM, and 18, but keep the newset reversion is r9,
> after add non-eSIM SKU, a sencond request for ALC5682i-VS, 
> so continue patch2 we upreversion r10 which include rt5682s node.

I barely can parse it, but anyway does not look right. You explained
what you are doing but it does not explain why touching the same line
twice. There is no point in making one board new SKU, but then
immediately change it to something else. The previous commit is just no-op.

Best regards,
Krzysztof
Doug Anderson Aug. 15, 2023, 9:12 p.m. UTC | #3 
Hi,

On Mon, Aug 14, 2023 at 2:49 AM Sheng-Liang Pan
<sheng-liang.pan@quanta.corp-partner.google.com> wrote:
>
> >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >>
> >> On 10/08/2023 11:30, Sheng-Liang Pan wrote:
> >>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >>>>
> >>>>> Isn't this duplicated with r9? Probably other places as well... or....
> >>>>> separate r10 add rt5682s node which different with r9.
> >>>> we separate r10 add rt5682s which differentwith r9
> >>>>
> >>>>
> >>>>>> -        model = "Google Lazor Limozeen without Touchscreen (rev9+)";
> >>>>>> -        compatible = "google,lazor-sku6", "google,lazor-sku18", "qcom,sc7180";
> >>>>>> +        model = "Google Lazor Limozeen without Touchscreen (rev9)";
> >>>>>> +        compatible = "google,lazor-rev9-sku6", "google,lazor-rev9-sku18", "qcom,sc7180";
> >>>>
> >>>>> Your patch 2 does not make any sense. Didn't you touch it in patch 2?
> >>>>> Really, what is happening here?
> >>>> patch 2 explain why we added new sku for no-eSIM.
> >>>
> >>> So which commit explain why you touch the same line twice? Sorry, this
> >>> does not make sense.
> >>>
> >>> Best regards,
> >>> Krzysztof
> >>
> >> We sort patch by change order,
> >> fist request for non-eSIM, patch2 add new sku 10, 15 for non-eSIM, and 18, but keep the newset reversion is r9,
> >> after add non-eSIM SKU, a sencond request for ALC5682i-VS,
> >> so continue patch2 we upreversion r10 which include rt5682s node.
> >
> > I barely can parse it, but anyway does not look right. You explained
> > what you are doing but it does not explain why touching the same line
> > twice. There is no point in making one board new SKU, but then
> > immediately change it to something else. The previous commit is just no-op.
> >
> > Best regards,
> > Krzysztof
>
> Thanks Krzysztof.
>
> Hi Douglas,
> May I consult with you if you can accept we merge patch2 and patch3 together?

I have no objection to merging patch #2 and patch #3 into one patch if
that makes it better for Krzysztof.

-Doug