mbox series

[BlueZ,v2,0/5] Additional tests for ISO and hci_sync

Message ID cover.1690907478.git.pav@iki.fi
Headers show
Series Additional tests for ISO and hci_sync | expand

Message

Pauli Virtanen Aug. 1, 2023, 4:38 p.m. UTC
This adds a few tests checking ISO socket handling of invalid input
parameters and cleanup in some race conditions:

    ISO QoS CIG 0xF0 - Invalid
    ISO QoS CIS 0xF0 - Invalid
    ISO Connect2 CIG 0x01 - Success/Invalid
    ISO AC 6(ii) CIS 0xEF/auto - Success
    ISO AC 6(ii) CIS 0xEF/0xEF - Invalid
    ISO Defer Close - Success
    ISO Connect Close - Success
    ISO Defer Wait Close - Success
    ISO Connect Wait Close - Success

There's also one for a hci_sync race condition that triggers GPF:

    eSCO Simultaneous Disconnect - Failure

I have a patch series fixing these, but we'll revisit the
HCI_CONN_DELETED flag there, so maybe discussion needed.

These fail on current bluetooth-next/master, so it could make most sense
to wait for the fixes first.

v2:
- emit correct event from HCI_Create_Connection_Cancel + fix compile

Pauli Virtanen (5):
  btdev: check error conditions for HCI_Create_Connection_Cancel
  btdev: fix Command Status command opcodes for Setup Sync Conn
  sco-tester: test local and remote disconnecting simultaneously
  iso-tester: test with large CIS_ID and invalid CIG_ID/CIS_ID
  iso-tester: add tests checking Remove CIG is emitted

 emulator/btdev.c   |  90 ++++++++++++++++++++----
 monitor/bt.h       |   4 ++
 tools/iso-tester.c | 168 +++++++++++++++++++++++++++++++++++++++++++++
 tools/sco-tester.c |  59 ++++++++++++++++
 4 files changed, 308 insertions(+), 13 deletions(-)

Comments

patchwork-bot+bluetooth@kernel.org Aug. 4, 2023, 6:30 p.m. UTC | #1
Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Tue,  1 Aug 2023 19:38:37 +0300 you wrote:
> This adds a few tests checking ISO socket handling of invalid input
> parameters and cleanup in some race conditions:
> 
>     ISO QoS CIG 0xF0 - Invalid
>     ISO QoS CIS 0xF0 - Invalid
>     ISO Connect2 CIG 0x01 - Success/Invalid
>     ISO AC 6(ii) CIS 0xEF/auto - Success
>     ISO AC 6(ii) CIS 0xEF/0xEF - Invalid
>     ISO Defer Close - Success
>     ISO Connect Close - Success
>     ISO Defer Wait Close - Success
>     ISO Connect Wait Close - Success
> 
> [...]

Here is the summary with links:
  - [BlueZ,v2,1/5] btdev: check error conditions for HCI_Create_Connection_Cancel
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=5815a92423c3
  - [BlueZ,v2,2/5] btdev: fix Command Status command opcodes for Setup Sync Conn
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=23a7d4003064
  - [BlueZ,v2,3/5] sco-tester: test local and remote disconnecting simultaneously
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=80c8266ae20a
  - [BlueZ,v2,4/5] iso-tester: test with large CIS_ID and invalid CIG_ID/CIS_ID
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=10d83e3423bb
  - [BlueZ,v2,5/5] iso-tester: add tests checking Remove CIG is emitted
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=033b68cbb1bf

You are awesome, thank you!