mbox series

[GIT,PULL,FOR,6.6] Ds90ub9xx driver fixes and improvements

Message ID ZMj7Dbg8iLAznZyi@valkosipuli.retiisi.eu
State New
Headers show
Series [GIT,PULL,FOR,6.6] Ds90ub9xx driver fixes and improvements | expand

Pull-request

git://linuxtv.org/sailus/media_tree.git tags/ds90ub9xx-6.6-1-signed

Message

Sakari Ailus Aug. 1, 2023, 12:31 p.m. UTC 
Hi Mauro,

Here's a fix for ds90ub9xx driver introduced by the V4L2 async improvements
patchset. Basically the ds90ub9xx driver was merged after the patch that
converted notifier drivers not do fwnode matching with endpoints was
written and this was missed when the series was merged.

The first patch of the series fixes it. The rest of the set adds new
features.

Please pull.


The following changes since commit 38d6a03d2511bee97455b2ea0314c918537ef1ec:

  media: go7007: Remove redundant if statement (2023-07-28 12:45:55 +0200)

are available in the Git repository at:

  git://linuxtv.org/sailus/media_tree.git tags/ds90ub9xx-6.6-1-signed

for you to fetch changes up to 986bb91315431771994205ba237018de73fa3b1f:

  media: i2c: ds90ub960: Rename RXPORT_MODE_CSI2_ASYNC to RXPORT_MODE_CSI2_NONSYNC (2023-08-01 01:28:54 +0300)

----------------------------------------------------------------
DS90UB9xx driver async fix plus more, for 6.6

----------------------------------------------------------------
Tomi Valkeinen (9):
      media: i2c: ds90ub9x3: Fix sub-device matching
      media: i2c: ds90ub960: Configure CSI-2 continuous clock
      media: i2c: ds90ub953: Use v4l2_fwnode_endpoint_parse()
      media: i2c: ds90ub913: Use v4l2_fwnode_endpoint_parse()
      media: i2c: ds90ub953: Handle V4L2_MBUS_CSI2_NONCONTINUOUS_CLOCK
      media: i2c: ds90ub960: Allow FPD-Link async mode
      media: i2c: ds90ub953: Restructure clkout management
      media: i2c: ds90ub953: Support non-sync mode
      media: i2c: ds90ub960: Rename RXPORT_MODE_CSI2_ASYNC to RXPORT_MODE_CSI2_NONSYNC

 drivers/media/i2c/ds90ub913.c |  47 +++++----
 drivers/media/i2c/ds90ub953.c | 215 ++++++++++++++++++++++++------------------
 drivers/media/i2c/ds90ub960.c |  31 +++---
 3 files changed, 164 insertions(+), 129 deletions(-)

Comments

Jenkins Aug. 1, 2023, 1:13 p.m. UTC | #1 
From: builder@linuxtv.org

Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/ZMj7Dbg8iLAznZyi@valkosipuli.retiisi.eu/
Build log: https://builder.linuxtv.org/job/patchwork/327062/
Build time: 00:30:22
Link: https://lore.kernel.org/linux-media/ZMj7Dbg8iLAznZyi@valkosipuli.retiisi.eu

gpg: Signature made Tue 01 Aug 2023 12:25:24 PM UTC
gpg:                using DSA key 53AC58A5F5948636C04A1BF8141DFA54A1EC8DEA
gpg:                issuer "sakari.ailus@linux.intel.com"
gpg: Good signature from "Sakari Ailus <sakari.ailus@linux.intel.com>" [full]

Summary: got 9/9 patches with issues, being 9 at build time

Error/warnings:

patches/0001-media-i2c-ds90ub9x3-Fix-sub-device-matching.patch:

    allyesconfig: return code #0:
	../scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
	../scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
	../scripts/genksyms/parse.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples
	../drivers/staging/media/atomisp/i2c/atomisp-ov2680.c: ../drivers/staging/media/atomisp/i2c/atomisp-ov2680.c:476 ov2680_init_cfg() error: we previously assumed 'sd_state' could be null (see line 468)
	../drivers/staging/media/atomisp/i2c/atomisp-ov2680.c:524 ov2680_s_stream() warn: missing error code 'ret'
	../drivers/staging/media/atomisp/i2c/atomisp-gc0310.c:447 gc0310_s_stream() warn: missing error code 'ret'
	../drivers/staging/media/atomisp/pci/atomisp_fops.c: ../drivers/staging/media/atomisp/pci/atomisp_fops.c:517 atomisp_open() warn: missing unwind goto?
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:2801 atomisp_cp_dvs_6axis_config() warn: missing unwind goto?
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:2900 atomisp_cp_morph_table() warn: missing unwind goto?

    allyesconfig: return code #0:
	../drivers/media/i2c/adp1653.c: ../drivers/media/i2c/adp1653.c:444 adp1653_of_init() warn: missing unwind goto?
	../drivers/media/usb/dvb-usb-v2/af9035.c: ../drivers/media/usb/dvb-usb-v2/af9035.c:467 af9035_i2c_master_xfer() warn: inconsistent returns '&d->i2c_mutex'.
	  Locked on  : 326,387
	  Unlocked on: 465,467
	../drivers/media/i2c/ds90ub913.c: ../drivers/media/i2c/ds90ub913.c:479 ub913_log_status() error: uninitialized symbol 'v1'.
	../drivers/media/i2c/ds90ub913.c: ../drivers/media/i2c/ds90ub913.c:479 ub913_log_status() error: uninitialized symbol 'v2'.
	../drivers/media/i2c/ds90ub953.c: ../drivers/media/i2c/ds90ub953.c:642 ub953_log_status() error: uninitialized symbol 'gpio_local_data'.
	../drivers/media/i2c/ds90ub953.c: ../drivers/media/i2c/ds90ub953.c:642 ub953_log_status() error: uninitialized symbol 'gpio_input_ctrl'.
	../drivers/media/i2c/ds90ub953.c: ../drivers/media/i2c/ds90ub953.c:642 ub953_log_status() error: uninitialized symbol 'gpio_pin_sts'.
	../drivers/media/i2c/ds90ub960.c: ../drivers/media/i2c/ds90ub960.c:1780 ub960_init_tx_ports() error: uninitialized symbol 'pll_div'.
	../drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c: ../drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c:2772 mxc_jpeg_probe() warn: missing unwind goto?
	SMATCH:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: :warning: array of flexible structures
	../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2558 dvb_register() parse error: OOM: 3000008Kb sm_state_count = 1971102
	../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2558 dvb_register() warn: Function too hairy.  No more merges.
	../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2558 dvb_register() parse error: __split_smt: function too hairy.  Giving up after 58 seconds
	../drivers/media/i2c/ov5645.c: ../drivers/media/i2c/ov5645.c:687 ov5645_set_power_on() warn: 'ov5645->xclk' from clk_prepare_enable() not released on lines: 687.
	../drivers/media/pci/ivtv/ivtvfb.c: note: in included file (through ../arch/x86/include/asm/uaccess.h, ../include/linux/uaccess.h, ../include/linux/sched/task.h, ../include/linux/sched/signal.h, ../drivers/media/pci/ivtv/ivtv-driver.h):
	SPARSE:../drivers/media/pci/ivtv/ivtvfb.c ../arch/x86/include/asm/uaccess_64.h:88:24: warning: cast removes address space '__user' of expression
	../drivers/media/usb/uvc/uvc_v4l2.c: note: in included file (through ../arch/x86/include/asm/uaccess.h, ../include/linux/uaccess.h, ../include/linux/sched/task.h, ../include/linux/sched/signal.h, ../include/linux/rcuwait.h, ...):
	SPARSE:../drivers/media/usb/uvc/uvc_v4l2.c ../arch/x86/include/asm/uaccess_64.h:88:24: warning: cast removes address space '__user' of expression
	../drivers/media/usb/pvrusb2/pvrusb2-hdw.c: ../drivers/media/usb/pvrusb2/pvrusb2-hdw.c:3293 pvr2_hdw_get_tuner_status() warn: inconsistent indenting
	../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2890 em28xx_v4l2_init() parse error: turning off implications after 60 seconds

   checkpatch.pl:
	$ cat patches/0001-media-i2c-ds90ub9x3-Fix-sub-device-matching.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
	-:6: ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 1029939b3782 ("media: v4l: async: Simplify async sub-device fwnode matching")'

patches/0002-media-i2c-ds90ub960-Configure-CSI-2-continuous-clock.patch:

    allyesconfig: return code #0:
	../drivers/media/i2c/ds90ub960.c: ../drivers/media/i2c/ds90ub960.c:1788 ub960_init_tx_ports() error: uninitialized symbol 'pll_div'.

patches/0003-media-i2c-ds90ub953-Use-v4l2_fwnode_endpoint_parse.patch:

    allyesconfig: return code #0:
	../drivers/media/i2c/ds90ub953.c: ../drivers/media/i2c/ds90ub953.c:644 ub953_log_status() error: uninitialized symbol 'gpio_local_data'.
	../drivers/media/i2c/ds90ub953.c: ../drivers/media/i2c/ds90ub953.c:644 ub953_log_status() error: uninitialized symbol 'gpio_input_ctrl'.
	../drivers/media/i2c/ds90ub953.c: ../drivers/media/i2c/ds90ub953.c:644 ub953_log_status() error: uninitialized symbol 'gpio_pin_sts'.

patches/0004-media-i2c-ds90ub913-Use-v4l2_fwnode_endpoint_parse.patch:

    allyesconfig: return code #0:
	../drivers/media/i2c/ds90ub913.c: ../drivers/media/i2c/ds90ub913.c:481 ub913_log_status() error: uninitialized symbol 'v1'.
	../drivers/media/i2c/ds90ub913.c: ../drivers/media/i2c/ds90ub913.c:481 ub913_log_status() error: uninitialized symbol 'v2'.

patches/0005-media-i2c-ds90ub953-Handle-V4L2_MBUS_CSI2_NONCONTINU.patch:

    allyesconfig: return code #0:
	../drivers/media/i2c/ds90ub953.c: ../drivers/media/i2c/ds90ub953.c:645 ub953_log_status() error: uninitialized symbol 'gpio_local_data'.
	../drivers/media/i2c/ds90ub953.c: ../drivers/media/i2c/ds90ub953.c:645 ub953_log_status() error: uninitialized symbol 'gpio_input_ctrl'.
	../drivers/media/i2c/ds90ub953.c: ../drivers/media/i2c/ds90ub953.c:645 ub953_log_status() error: uninitialized symbol 'gpio_pin_sts'.

patches/0006-media-i2c-ds90ub960-Allow-FPD-Link-async-mode.patch:

    allyesconfig: return code #0:
	../drivers/media/i2c/ds90ub960.c: ../drivers/media/i2c/ds90ub960.c:1788 ub960_init_tx_ports() error: uninitialized symbol 'pll_div'.

patches/0007-media-i2c-ds90ub953-Restructure-clkout-management.patch:

    allyesconfig: return code #0:
	../drivers/media/i2c/ds90ub953.c: ../drivers/media/i2c/ds90ub953.c:654 ub953_log_status() error: uninitialized symbol 'gpio_local_data'.
	../drivers/media/i2c/ds90ub953.c: ../drivers/media/i2c/ds90ub953.c:654 ub953_log_status() error: uninitialized symbol 'gpio_input_ctrl'.
	../drivers/media/i2c/ds90ub953.c: ../drivers/media/i2c/ds90ub953.c:654 ub953_log_status() error: uninitialized symbol 'gpio_pin_sts'.

patches/0008-media-i2c-ds90ub953-Support-non-sync-mode.patch:

    allyesconfig: return code #0:
	../drivers/media/i2c/ds90ub953.c: ../drivers/media/i2c/ds90ub953.c:655 ub953_log_status() error: uninitialized symbol 'gpio_local_data'.
	../drivers/media/i2c/ds90ub953.c: ../drivers/media/i2c/ds90ub953.c:655 ub953_log_status() error: uninitialized symbol 'gpio_input_ctrl'.
	../drivers/media/i2c/ds90ub953.c: ../drivers/media/i2c/ds90ub953.c:655 ub953_log_status() error: uninitialized symbol 'gpio_pin_sts'.

patches/0009-media-i2c-ds90ub960-Rename-RXPORT_MODE_CSI2_ASYNC-to.patch:

    allyesconfig: return code #0:
	../drivers/media/i2c/ds90ub960.c: ../drivers/media/i2c/ds90ub960.c:1788 ub960_init_tx_ports() error: uninitialized symbol 'pll_div'.