| Message ID | 20230725054216.45696-1-tony@atomide.com |
|---|---|
| Headers | show |
| Series | Serial core controller port device name fixes | expand |
On Mon, Jul 31, 2023 at 05:14:15PM +0200, Greg Kroah-Hartman wrote: > On Tue, Jul 25, 2023 at 12:07:04PM +0300, Andy Shevchenko wrote: > > On Tue, Jul 25, 2023 at 08:42:12AM +0300, Tony Lindgren wrote: > > > We are missing the serial core controller id for the serial core port > > > name. Let's fix the issue for sane sysfs output, and to avoid issues > > > addressing serial ports later on. > > > > > > And as we're now showing the controller id, the "ctrl" and "port" prefix > > > for the DEVNAME become useless, we can just drop them. Let's standardize on > > > DEVNAME:0 for controller name, where 0 is the controller id. And > > > DEVNAME:0.0 for port name, where 0.0 are the controller id and port id. > > > > > > This makes the sysfs output nicer, on qemu for example: > > > > > > $ ls /sys/bus/serial-base/devices > > > 00:04:0 serial8250:0 serial8250:0.2 > > > 00:04:0.0 serial8250:0.1 serial8250:0.3 > > > > Hmm... Why 0.0 is absent for serial8250? > > Btw, what was before this patch there? > > And maybe ls -l will look more informative? > > > > > Fixes: 84a9582fd203 ("serial: core: Start managing serial controllers to enable runtime PM") > > > Reported-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > Signed-off-by: Tony Lindgren <tony@atomide.com> > > > --- > > > > > > Andy, I kept your Reviewed-by although I updated the device naming and > > > description, does the patch still look OK to you? > > > > Looks okay, but I have a question above. > > Can I get an ack for this if you are ok with these fixes? Sure, Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
On Tue, Jul 25, 2023 at 08:42:12AM +0300, Tony Lindgren wrote: > We are missing the serial core controller id for the serial core port > name. Let's fix the issue for sane sysfs output, and to avoid issues > addressing serial ports later on. > > And as we're now showing the controller id, the "ctrl" and "port" prefix > for the DEVNAME become useless, we can just drop them. Let's standardize on > DEVNAME:0 for controller name, where 0 is the controller id. And > DEVNAME:0.0 for port name, where 0.0 are the controller id and port id. > > This makes the sysfs output nicer, on qemu for example: > > $ ls /sys/bus/serial-base/devices > 00:04:0 serial8250:0 serial8250:0.2 > 00:04:0.0 serial8250:0.1 serial8250:0.3 > > Fixes: 84a9582fd203 ("serial: core: Start managing serial controllers to enable runtime PM") > Reported-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Signed-off-by: Tony Lindgren <tony@atomide.com> This patch causes about 50% of my boot tests to fail because the console is no longer recognized. Reverting this patch fixes the problem. Bisect log attached. Guenter --- # bad: [35245ef82c5b8206d97d0296017df658fd8ea3d2] Merge branch 'for-linux-next-fixes' of git://anongit.freedesktop.org/drm/drm-misc # good: [5d0c230f1de8c7515b6567d9afba1f196fb4e2f4] Linux 6.5-rc4 git bisect start 'HEAD' 'v6.5-rc4' # good: [ec0f64d0666ce02114b11efd3df3234f7a3497d8] Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git git bisect good ec0f64d0666ce02114b11efd3df3234f7a3497d8 # bad: [8eb8b701a263abed01d3fd7e7f1984ef37b02149] Merge branch 'fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git git bisect bad 8eb8b701a263abed01d3fd7e7f1984ef37b02149 # good: [f29c3a80b329fbfbf92278c29fdcaafb736e3d01] Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git git bisect good f29c3a80b329fbfbf92278c29fdcaafb736e3d01 # bad: [eddb92c4c656a669c30e17ce934e5eba8c261392] Merge branch 'fixes-togreg' of git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git git bisect bad eddb92c4c656a669c30e17ce934e5eba8c261392 # good: [6811694eb2f6b7a4e97be2029edc7dd6a39460f8] iio: imu: lsm6dsx: Fix mount matrix retrieval git bisect good 6811694eb2f6b7a4e97be2029edc7dd6a39460f8 # bad: [1ef2c2df11997b8135f34adcf2c200d3b4aacbe9] serial: core: Fix serial core controller port name to show controller id git bisect bad 1ef2c2df11997b8135f34adcf2c200d3b4aacbe9 # good: [83c35180abfdfb22f3d7703b0c85ad2d442ed2c5] serial: core: Controller id cannot be negative git bisect good 83c35180abfdfb22f3d7703b0c85ad2d442ed2c5 # good: [d962de6ae51f9b76ad736220077cda83084090b1] serial: core: Fix serial core port id to not use port->line git bisect good d962de6ae51f9b76ad736220077cda83084090b1 # first bad commit: [1ef2c2df11997b8135f34adcf2c200d3b4aacbe9] serial: core: Fix serial core controller port name to show controller id
On Thu, Aug 03, 2023 at 03:18:42PM -0700, Guenter Roeck wrote: > On Tue, Jul 25, 2023 at 08:42:12AM +0300, Tony Lindgren wrote: > > We are missing the serial core controller id for the serial core port > > name. Let's fix the issue for sane sysfs output, and to avoid issues > > addressing serial ports later on. > > > > And as we're now showing the controller id, the "ctrl" and "port" prefix > > for the DEVNAME become useless, we can just drop them. Let's standardize on > > DEVNAME:0 for controller name, where 0 is the controller id. And > > DEVNAME:0.0 for port name, where 0.0 are the controller id and port id. > > > > This makes the sysfs output nicer, on qemu for example: > > > > $ ls /sys/bus/serial-base/devices > > 00:04:0 serial8250:0 serial8250:0.2 > > 00:04:0.0 serial8250:0.1 serial8250:0.3 > > > > Fixes: 84a9582fd203 ("serial: core: Start managing serial controllers to enable runtime PM") > > Reported-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Signed-off-by: Tony Lindgren <tony@atomide.com> > > This patch causes about 50% of my boot tests to fail because the console > is no longer recognized. Reverting this patch fixes the problem. > Bisect log attached. Isn't fix already available? 7d695d83767c ("serial: core: Fix serial_base_match() after fixing controller port name") (in tty/tty-linus)
On 8/3/23 21:20, Andy Shevchenko wrote: > On Thu, Aug 03, 2023 at 03:18:42PM -0700, Guenter Roeck wrote: >> On Tue, Jul 25, 2023 at 08:42:12AM +0300, Tony Lindgren wrote: >>> We are missing the serial core controller id for the serial core port >>> name. Let's fix the issue for sane sysfs output, and to avoid issues >>> addressing serial ports later on. >>> >>> And as we're now showing the controller id, the "ctrl" and "port" prefix >>> for the DEVNAME become useless, we can just drop them. Let's standardize on >>> DEVNAME:0 for controller name, where 0 is the controller id. And >>> DEVNAME:0.0 for port name, where 0.0 are the controller id and port id. >>> >>> This makes the sysfs output nicer, on qemu for example: >>> >>> $ ls /sys/bus/serial-base/devices >>> 00:04:0 serial8250:0 serial8250:0.2 >>> 00:04:0.0 serial8250:0.1 serial8250:0.3 >>> >>> Fixes: 84a9582fd203 ("serial: core: Start managing serial controllers to enable runtime PM") >>> Reported-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> >>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> >>> Signed-off-by: Tony Lindgren <tony@atomide.com> >> >> This patch causes about 50% of my boot tests to fail because the console >> is no longer recognized. Reverting this patch fixes the problem. >> Bisect log attached. > > Isn't fix already available? > 7d695d83767c ("serial: core: Fix serial_base_match() after fixing controller port name") > Yes, hopefully that should fix it. We'll see tonight, when my test bed builds it again. Guenter
A few issues have been found with device naming for the serial core controller port device. These issues currently mostly affect the output for /sys/bus/serial-base/devices, but need to be also fixed to avoid port addressing issues later on. Changes since v4: - Make the sysfs device names nicer with DEVNAME:0.0 naming, the "ctrl" and "port" prefixes are not needed with the controller id in the name - Fix Andy's Reviewed-by as noted by Andy - Generate patches with --patience to make the last patch more readable Changes since v3: - Drop unnecessary else on the return path in serial_base_device_init() as noted by Andy - Add Andy's Reviewed-by - Update patch description for port_id instead of port port_id for the first patch Changes since v2: - Fix my email script as it had started to drop linux-serial as noted by Greg - Explain why we're changing ctrl_id as requested by Greg Changes since v1: - Port id cannot be negative as noted by Jiri - Controller id cannot be negative as noted by Andy - Port name is missing the controller instance as noted by Andy Tony Lindgren (3): serial: core: Controller id cannot be negative serial: core: Fix serial core port id to not use port->line serial: core: Fix serial core controller port name to show controller id drivers/tty/serial/8250/8250_core.c | 2 ++ drivers/tty/serial/serial_base_bus.c | 32 +++++++++++++++++----------- include/linux/serial_core.h | 3 ++- 3 files changed, 24 insertions(+), 13 deletions(-)