| Message ID | 20230714175152.4068286-1-robh@kernel.org |
|---|---|
| State | Accepted |
| Commit | 23e9bf8e78ba2ed32e9bf5a37c5074b9dfc29110 |
| Headers | show |
| Series | soc: sunxi: Explicitly include correct DT includes | expand |
Dne petek, 14. julij 2023 ob 19:51:51 CEST je Rob Herring napisal(a): > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > drivers/soc/sunxi/sun20i-ppu.c | 2 +- Sorry, ppu driver was moved. Please rebase on top of: git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/linux-pm.git genpd_create_dir Best regards, Jernej > drivers/soc/sunxi/sunxi_sram.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/soc/sunxi/sun20i-ppu.c b/drivers/soc/sunxi/sun20i-ppu.c > index 98cb41d36560..8700f9dd5f75 100644 > --- a/drivers/soc/sunxi/sun20i-ppu.c > +++ b/drivers/soc/sunxi/sun20i-ppu.c > @@ -5,7 +5,7 @@ > #include <linux/io.h> > #include <linux/iopoll.h> > #include <linux/module.h> > -#include <linux/of_device.h> > +#include <linux/of.h> > #include <linux/platform_device.h> > #include <linux/pm_domain.h> > #include <linux/reset.h> > diff --git a/drivers/soc/sunxi/sunxi_sram.c b/drivers/soc/sunxi/sunxi_sram.c > index 4c4864cd2342..4458b2e0562b 100644 > --- a/drivers/soc/sunxi/sunxi_sram.c > +++ b/drivers/soc/sunxi/sunxi_sram.c > @@ -15,7 +15,7 @@ > #include <linux/module.h> > #include <linux/of.h> > #include <linux/of_address.h> > -#include <linux/of_device.h> > +#include <linux/of_platform.h> > #include <linux/platform_device.h> > #include <linux/regmap.h>
diff --git a/drivers/soc/sunxi/sun20i-ppu.c b/drivers/soc/sunxi/sun20i-ppu.c index 98cb41d36560..8700f9dd5f75 100644 --- a/drivers/soc/sunxi/sun20i-ppu.c +++ b/drivers/soc/sunxi/sun20i-ppu.c @@ -5,7 +5,7 @@ #include <linux/io.h> #include <linux/iopoll.h> #include <linux/module.h> -#include <linux/of_device.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <linux/pm_domain.h> #include <linux/reset.h> diff --git a/drivers/soc/sunxi/sunxi_sram.c b/drivers/soc/sunxi/sunxi_sram.c index 4c4864cd2342..4458b2e0562b 100644 --- a/drivers/soc/sunxi/sunxi_sram.c +++ b/drivers/soc/sunxi/sunxi_sram.c @@ -15,7 +15,7 @@ #include <linux/module.h> #include <linux/of.h> #include <linux/of_address.h> -#include <linux/of_device.h> +#include <linux/of_platform.h> #include <linux/platform_device.h> #include <linux/regmap.h>
The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes. Signed-off-by: Rob Herring <robh@kernel.org> --- drivers/soc/sunxi/sun20i-ppu.c | 2 +- drivers/soc/sunxi/sunxi_sram.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)