| Message ID | 20230719060954.14864-1-zelong.dong@amlogic.com |
|---|---|
| Headers | show |
| Series | reset: amlogic-c3: add reset driver | expand |
On Mi, 2023-07-19 at 14:09 +0800, zelong dong wrote: > From: Zelong Dong <zelong.dong@amlogic.com> > > Add new compatible and DT bindings for Amlogic C3 Reset Controller > > Signed-off-by: Zelong Dong <zelong.dong@amlogic.com> > --- > .../bindings/reset/amlogic,meson-reset.yaml | 1 + > include/dt-bindings/reset/amlogic,c3-reset.h | 119 ++++++++++++++++++ > 2 files changed, 120 insertions(+) > create mode 100644 include/dt-bindings/reset/amlogic,c3-reset.h > > diff --git a/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml b/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml > index d3fdee89d4f8..f0c6c0df0ce3 100644 > --- a/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml > +++ b/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml > @@ -18,6 +18,7 @@ properties: > - amlogic,meson-axg-reset # Reset Controller on AXG and compatible SoCs > - amlogic,meson-a1-reset # Reset Controller on A1 and compatible SoCs > - amlogic,meson-s4-reset # Reset Controller on S4 and compatible SoCs > + - amlogic,c3-reset # Reset Controller on C3 and compatible SoCs > > reg: > maxItems: 1 > diff --git a/include/dt-bindings/reset/amlogic,c3-reset.h b/include/dt-bindings/reset/amlogic,c3-reset.h > new file mode 100644 > index 000000000000..d9127863f603 > --- /dev/null > +++ b/include/dt-bindings/reset/amlogic,c3-reset.h Given that this is only included by arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi, should this header be moved to arch/arm64/boot/dts/amlogic ? regards Philipp
On 28/07/2023 17:49, Philipp Zabel wrote: >> maxItems: 1 >> diff --git a/include/dt-bindings/reset/amlogic,c3-reset.h b/include/dt-bindings/reset/amlogic,c3-reset.h >> new file mode 100644 >> index 000000000000..d9127863f603 >> --- /dev/null >> +++ b/include/dt-bindings/reset/amlogic,c3-reset.h > > Given that this is only included by > arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi, should this header be > moved to arch/arm64/boot/dts/amlogic ? I think there is ongoing work or at least plan to use the IDs also in clock/reset drivers for all Amlogic platforms. Do I recall this correctly? Best regards, Krzysztof
From: Zelong Dong <zelong.dong@amlogic.com> This patchset adds Reset controller driver support for Amlogic C3 SoC. The RESET registers count and offset for C3 Soc are same as S4 Soc. Changes since v1: - remove Change-ID - run scripts/checkpatch.pl and fix reported warnings - sort dts node by base reg offset Changes since v2: - replace keyword "meson" with "amlogic" --- v1:https://lore.kernel.org/all/20230630121059.28748-1-zelong.dong@amlogic.com/ v2:https://lore.kernel.org/all/20230718123550.13712-1-zelong.dong@amlogic.com/ Zelong Dong (3): dt-bindings: reset: Add compatible and DT bindings for Amlogic C3 Reset Controller reset: reset-meson: add support for Amlogic C3 SoC Reset Controller arm64: dts: amlogic: add reset controller for Amlogic C3 SoC .../bindings/reset/amlogic,meson-reset.yaml | 1 + arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi | 7 ++ drivers/reset/reset-meson.c | 1 + include/dt-bindings/reset/amlogic,c3-reset.h | 119 ++++++++++++++++++ 4 files changed, 128 insertions(+) create mode 100644 include/dt-bindings/reset/amlogic,c3-reset.h