mbox series

[0/5] soc: qcom: Add support for SM4450

Message ID 20230719100135.21325-1-quic_tengfan@quicinc.com
Headers show
Series soc: qcom: Add support for SM4450 | expand

Message

Tengfei Fan July 19, 2023, 10:01 a.m. UTC 
This series adds CPU, SoC and board compatible support for SM4450.

Tengfei Fan (5):
  arm64: dts: qcom: Add base SM4450 DTSI
  arm64: dts: qcom: Add base SM4450 QRD DTS
  dt-bindings: firmware: scm: Add SM4450
  dt-bindings: arm: qcom: Document SM4450 SoC and boards
  soc: qcom: socinfo: add SM4450 ID

 .../devicetree/bindings/arm/qcom.yaml         |   6 +
 .../bindings/firmware/qcom,scm.yaml           |   1 +
 arch/arm64/boot/dts/qcom/Makefile             |   1 +
 arch/arm64/boot/dts/qcom/sm4450-qrd.dts       |  18 +
 arch/arm64/boot/dts/qcom/sm4450.dtsi          | 435 ++++++++++++++++++
 drivers/soc/qcom/socinfo.c                    |   1 +
 include/dt-bindings/arm/qcom,ids.h            |   2 +
 7 files changed, 464 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/sm4450-qrd.dts
 create mode 100644 arch/arm64/boot/dts/qcom/sm4450.dtsi

Comments

Dmitry Baryshkov July 19, 2023, 10:15 a.m. UTC | #1 
On 19/07/2023 13:01, Tengfei Fan wrote:
> Document the SM8450 SoC binding and also the boards using it.
> 
> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
> ---
>   Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 450f616774e0..691e66612872 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -83,6 +83,7 @@ description: |
>           sm8350
>           sm8450
>           sm8550
> +        sm4450

Please sort properly

>   
>     The 'board' element must be one of the following strings:
>   
> @@ -976,6 +977,11 @@ properties:
>                 - qcom,sm8550-qrd
>             - const: qcom,sm8550
>   
> +      - items:
> +          - enum:
> +              - qcom,sm4450-qrd
> +          - const: qcom,sm4450
> +

And here

>     # Board compatibles go above
>   
>     qcom,msm-id:
Krzysztof Kozlowski July 19, 2023, 10:24 a.m. UTC | #2 
On 19/07/2023 12:01, Tengfei Fan wrote:
> Document the SM8450 SoC binding and also the boards using it.
> 
> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 450f616774e0..691e66612872 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -83,6 +83,7 @@ description: |
>          sm8350
>          sm8450
>          sm8550
> +        sm4450
>  
>    The 'board' element must be one of the following strings:
>  
> @@ -976,6 +977,11 @@ properties:
>                - qcom,sm8550-qrd
>            - const: qcom,sm8550
>  
> +      - items:
> +          - enum:
> +              - qcom,sm4450-qrd
> +          - const: qcom,sm4450

No, really...

Best regards,
Krzysztof
Krzysztof Kozlowski July 19, 2023, 10:26 a.m. UTC | #3 
On 19/07/2023 12:15, Dmitry Baryshkov wrote:
> On 19/07/2023 13:01, Tengfei Fan wrote:
>> Add the ID for the Qualcomm SM4450 SoC.
>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>> ---
>>   drivers/soc/qcom/socinfo.c         | 1 +
>>   include/dt-bindings/arm/qcom,ids.h | 2 ++
>>   2 files changed, 3 insertions(+)
>>
>> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
>> index 4d49945b3a35..fa5e4c54207a 100644
>> --- a/drivers/soc/qcom/socinfo.c
>> +++ b/drivers/soc/qcom/socinfo.c
>> @@ -415,6 +415,7 @@ static const struct soc_id soc_id[] = {
>>   	{ qcom_board_id(IPQ5312) },
>>   	{ qcom_board_id(IPQ5302) },
>>   	{ qcom_board_id(IPQ5300) },
>> +	{ qcom_board_id(SM4450) },
>>   };
>>   
>>   static const char *socinfo_machine(struct device *dev, unsigned int id)
>> diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
>> index bcbe9ee2cdaf..6201bfb1405e 100644
>> --- a/include/dt-bindings/arm/qcom,ids.h
>> +++ b/include/dt-bindings/arm/qcom,ids.h
>> @@ -2,6 +2,7 @@
>>   /*
>>    * Copyright (c) 2015, The Linux Foundation. All rights reserved.
>>    * Copyright (c) 2022 Linaro Ltd
>> + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved.
> 
> I wonder whether a single define is copyrightable.

If you carefully choose a place, like out of order, then probably it is
a creative work. :)

Best regards,
Krzysztof
Tengfei Fan July 21, 2023, 2:19 a.m. UTC | #4 
在 7/19/2023 6:16 PM, Dmitry Baryshkov 写道:
> On 19/07/2023 13:01, Tengfei Fan wrote:
>> Add compatible for SM4450 SoCs.
>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>> ---
>>   Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml 
>> b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
>> index bdbee58a542b..f02f0815bece 100644
>> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
>> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
>> @@ -62,6 +62,7 @@ properties:
>>             - qcom,scm-sm8450
>>             - qcom,scm-sm8550
>>             - qcom,scm-qcs404
>> +          - qcom,scm-sm4450
> 
> Please keep this list sorted.
V2 patch will resort.
> 
>>         - const: qcom,scm
>>     clocks:
>
Tengfei Fan July 21, 2023, 2:19 a.m. UTC | #5 
在 7/19/2023 6:24 PM, Krzysztof Kozlowski 写道:
> On 19/07/2023 12:01, Tengfei Fan wrote:
>> Add compatible for SM4450 SoCs.
>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>> ---
>>   Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
>> index bdbee58a542b..f02f0815bece 100644
>> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
>> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
>> @@ -62,6 +62,7 @@ properties:
>>             - qcom,scm-sm8450
>>             - qcom,scm-sm8550
>>             - qcom,scm-qcs404
>> +          - qcom,scm-sm4450
> 
> Please keep things sorted...
V2 patch will resort.
> 
> Best regards,
> Krzysztof
>
Tengfei Fan July 21, 2023, 2:20 a.m. UTC | #6 
在 7/19/2023 6:15 PM, Dmitry Baryshkov 写道:
> On 19/07/2023 13:01, Tengfei Fan wrote:
>> Document the SM8450 SoC binding and also the boards using it.
>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>> ---
>>   Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml 
>> b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index 450f616774e0..691e66612872 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -83,6 +83,7 @@ description: |
>>           sm8350
>>           sm8450
>>           sm8550
>> +        sm4450
> 
> Please sort properly
V2 patch will resort.
> 
>>     The 'board' element must be one of the following strings:
>> @@ -976,6 +977,11 @@ properties:
>>                 - qcom,sm8550-qrd
>>             - const: qcom,sm8550
>> +      - items:
>> +          - enum:
>> +              - qcom,sm4450-qrd
>> +          - const: qcom,sm4450
>> +
> 
> And here
V2 patch will resort.
> 
>>     # Board compatibles go above
>>     qcom,msm-id:
>
Tengfei Fan July 21, 2023, 2:24 a.m. UTC | #7 
在 7/19/2023 6:24 PM, Krzysztof Kozlowski 写道:
> On 19/07/2023 12:01, Tengfei Fan wrote:
>> Document the SM8450 SoC binding and also the boards using it.
>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>> ---
>>   Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index 450f616774e0..691e66612872 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -83,6 +83,7 @@ description: |
>>           sm8350
>>           sm8450
>>           sm8550
>> +        sm4450
>>   
>>     The 'board' element must be one of the following strings:
>>   
>> @@ -976,6 +977,11 @@ properties:
>>                 - qcom,sm8550-qrd
>>             - const: qcom,sm8550
>>   
>> +      - items:
>> +          - enum:
>> +              - qcom,sm4450-qrd
>> +          - const: qcom,sm4450
> 
> No, really...
V2 patch will resort it.
> 
> Best regards,
> Krzysztof
>
Tengfei Fan July 21, 2023, 2:26 a.m. UTC | #8 
在 7/19/2023 6:26 PM, Krzysztof Kozlowski 写道:
> On 19/07/2023 12:15, Dmitry Baryshkov wrote:
>> On 19/07/2023 13:01, Tengfei Fan wrote:
>>> Add the ID for the Qualcomm SM4450 SoC.
>>>
>>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>>> ---
>>>    drivers/soc/qcom/socinfo.c         | 1 +
>>>    include/dt-bindings/arm/qcom,ids.h | 2 ++
>>>    2 files changed, 3 insertions(+)
>>>
>>> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
>>> index 4d49945b3a35..fa5e4c54207a 100644
>>> --- a/drivers/soc/qcom/socinfo.c
>>> +++ b/drivers/soc/qcom/socinfo.c
>>> @@ -415,6 +415,7 @@ static const struct soc_id soc_id[] = {
>>>    	{ qcom_board_id(IPQ5312) },
>>>    	{ qcom_board_id(IPQ5302) },
>>>    	{ qcom_board_id(IPQ5300) },
>>> +	{ qcom_board_id(SM4450) },
>>>    };
>>>    
>>>    static const char *socinfo_machine(struct device *dev, unsigned int id)
>>> diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
>>> index bcbe9ee2cdaf..6201bfb1405e 100644
>>> --- a/include/dt-bindings/arm/qcom,ids.h
>>> +++ b/include/dt-bindings/arm/qcom,ids.h
>>> @@ -2,6 +2,7 @@
>>>    /*
>>>     * Copyright (c) 2015, The Linux Foundation. All rights reserved.
>>>     * Copyright (c) 2022 Linaro Ltd
>>> + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved.
>>
>> I wonder whether a single define is copyrightable.
> 
> If you carefully choose a place, like out of order, then probably it is
> a creative work. :)
V2 patch will remove this copyrithtable.
> 
> Best regards,
> Krzysztof
>
Tengfei Fan July 21, 2023, 2:27 a.m. UTC | #9 
在 7/19/2023 6:25 PM, Krzysztof Kozlowski 写道:
> On 19/07/2023 12:01, Tengfei Fan wrote:
>> Add the ID for the Qualcomm SM4450 SoC.
>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>> ---
>>   drivers/soc/qcom/socinfo.c         | 1 +
>>   include/dt-bindings/arm/qcom,ids.h | 2 ++
> 
> Bindings are always separate patches.
V2 patch will separate.
> 
>>   2 files changed, 3 insertions(+)
>>
>> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
>> index 4d49945b3a35..fa5e4c54207a 100644
>> --- a/drivers/soc/qcom/socinfo.c
>> +++ b/drivers/soc/qcom/socinfo.c
>> @@ -415,6 +415,7 @@ static const struct soc_id soc_id[] = {
>>   	{ qcom_board_id(IPQ5312) },
>>   	{ qcom_board_id(IPQ5302) },
>>   	{ qcom_board_id(IPQ5300) },
>> +	{ qcom_board_id(SM4450) },
>>   };
>>   
>>   static const char *socinfo_machine(struct device *dev, unsigned int id)
>> diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
>> index bcbe9ee2cdaf..6201bfb1405e 100644
>> --- a/include/dt-bindings/arm/qcom,ids.h
>> +++ b/include/dt-bindings/arm/qcom,ids.h
>> @@ -2,6 +2,7 @@
>>   /*
>>    * Copyright (c) 2015, The Linux Foundation. All rights reserved.
>>    * Copyright (c) 2022 Linaro Ltd
>> + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved.
>>    * Author: Krzysztof Kozlowski <krzk@kernel.org> based on previous work of Kumar Gala.
>>    */
>>   #ifndef _DT_BINDINGS_ARM_QCOM_IDS_H
>> @@ -259,6 +260,7 @@
>>   #define QCOM_ID_IPQ5312			594
>>   #define QCOM_ID_IPQ5302			595
>>   #define QCOM_ID_IPQ5300			624
>> +#define QCOM_ID_SM4450			568
> 
> No, come on...
V2 patch will resort this.
> 
> Best regards,
> Krzysztof
>