| Message ID | 20230715112523.2533742-1-contact@jookia.org |
|---|---|
| Headers | show |
| Series | Add support for Allwinner D1 CAN controllers | expand |
On 15/07/2023 13:25, Jookia wrote: > From: John Watts <contact@jookia.org> > > The Allwinner D1, T113 provide two CAN controllers that are variants > of the R40 controller. > > I have tested support for these controllers on two boards: > Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC (and consider --no-git-fallback argument). It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. > - A Lichee Panel RV 86 Panel running a D1 chip > - A Mango Pi MQ Dual running a T113-s3 chip > > Both of these fully support both CAN controllers. > > Signed-off-by: John Watts <contact@jookia.org> > --- > .../boot/dts/allwinner/sunxi-d1s-t113.dtsi | 30 +++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi b/arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi > index 1bb1e5cae602..b185398334be 100644 > --- a/arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi > +++ b/arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi > @@ -131,6 +131,18 @@ uart3_pb_pins: uart3-pb-pins { > pins = "PB6", "PB7"; > function = "uart3"; > }; > + > + /omit-if-no-ref/ > + can0_pins: can0_pins { Wrong node naming. Underscores are not allowed. It does not look like you tested the DTS against bindings. Please run `make dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ for instructions). Best regards, Krzysztof
From: John Watts <contact@jookia.org> This patch series adds support for the Allwinner D1 CAN controllers. It requires adding a new device tree compatible and driver support to work around some hardware quirks. John Watts (4): dt-bindings: net: can: Add support for Allwinner D1 CAN controller riscv: dts: allwinner: d1: Add CAN controller nodes can: sun4i_can: Add send support for the Allwinner D1 can: sun4i_can: Correctly set acceptance registers on the D1 .../net/can/allwinner,sun4i-a10-can.yaml | 6 ++-- .../boot/dts/allwinner/sunxi-d1s-t113.dtsi | 30 +++++++++++++++++++ drivers/net/can/Kconfig | 4 +-- drivers/net/can/sun4i_can.c | 22 ++++++++++++-- 4 files changed, 55 insertions(+), 7 deletions(-)