| Message ID | 20230713090015.127541-2-william.qiu@starfivetech.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add SPI module for StarFive JH7110 SoC | expand |
On 13/07/2023 11:00, William Qiu wrote: > Add primecell.yaml as a refereence file to YAML. This we see from the diff, but why you are doing it? Please provide rationale and answer to "why" in your commits. Also typo: reference. > > Signed-off-by: William Qiu <william.qiu@starfivetech.com> > --- > Documentation/devicetree/bindings/spi/spi-pl022.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml > index 91e540a92faf..5e5a704a766e 100644 > --- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml > +++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml > @@ -11,6 +11,7 @@ maintainers: > > allOf: > - $ref: spi-controller.yaml# > + - $ref: /schemas/arm/primecell.yaml# > > # We need a select here so we don't match all nodes with 'arm,primecell' > select: Best regards, Krzysztof
On 2023/7/13 18:12, Krzysztof Kozlowski wrote: > On 13/07/2023 11:00, William Qiu wrote: >> Add primecell.yaml as a refereence file to YAML. > > This we see from the diff, but why you are doing it? Please provide > rationale and answer to "why" in your commits. > > Also typo: reference. > >> >> Signed-off-by: William Qiu <william.qiu@starfivetech.com> >> --- >> Documentation/devicetree/bindings/spi/spi-pl022.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml >> index 91e540a92faf..5e5a704a766e 100644 >> --- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml >> +++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml >> @@ -11,6 +11,7 @@ maintainers: >> >> allOf: >> - $ref: spi-controller.yaml# >> + - $ref: /schemas/arm/primecell.yaml# >> >> # We need a select here so we don't match all nodes with 'arm,primecell' >> select: > > Best regards, > Krzysztof > I will explain it in next version. Best regards, William
diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml index 91e540a92faf..5e5a704a766e 100644 --- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml +++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml @@ -11,6 +11,7 @@ maintainers: allOf: - $ref: spi-controller.yaml# + - $ref: /schemas/arm/primecell.yaml# # We need a select here so we don't match all nodes with 'arm,primecell' select:
Add primecell.yaml as a refereence file to YAML. Signed-off-by: William Qiu <william.qiu@starfivetech.com> --- Documentation/devicetree/bindings/spi/spi-pl022.yaml | 1 + 1 file changed, 1 insertion(+)