diff mbox series

dt-bindings: gpio: snps,dw-apb: allow gpio-line-names

Message ID 20230712074553.35907-1-krzysztof.kozlowski@linaro.org
State Accepted
Commit 320630c45e6668c7b9b59489068cd1f85637a6ff
Headers show
Series dt-bindings: gpio: snps,dw-apb: allow gpio-line-names | expand

Commit Message

Krzysztof Kozlowski July 12, 2023, 7:45 a.m. UTC
Allow the GPIO controller subnode to define GPIO names.  Already used in
at least on DTS:

  bitmain/bm1880-sophon-edge.dtb: gpio@50027000: gpio-controller@0: 'gpio-line-names' does not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Krzysztof Kozlowski July 12, 2023, 5:47 p.m. UTC | #1
On 12/07/2023 17:28, Andy Shevchenko wrote:
> On Wed, Jul 12, 2023 at 12:53:00PM +0300, Serge Semin wrote:
>> On Wed, Jul 12, 2023 at 09:45:53AM +0200, Krzysztof Kozlowski wrote:
>>> Allow the GPIO controller subnode to define GPIO names.
> 
> Are we going to do this for each GPIO controller bindings? Can it be done once
> for all please?

No, because sizes differ. Although here the size is anyway flexible, so
not much benefit of it, but in other GPIO controllers it is not flexible.

Best regards,
Krzysztof
Rob Herring (Arm) July 14, 2023, 4:10 p.m. UTC | #2
On Wed, 12 Jul 2023 09:45:53 +0200, Krzysztof Kozlowski wrote:
> Allow the GPIO controller subnode to define GPIO names.  Already used in
> at least on DTS:
> 
>   bitmain/bm1880-sophon-edge.dtb: gpio@50027000: gpio-controller@0: 'gpio-line-names' does not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>
Bartosz Golaszewski July 20, 2023, 3:20 p.m. UTC | #3
On Wed, Jul 12, 2023 at 9:45 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> Allow the GPIO controller subnode to define GPIO names.  Already used in
> at least on DTS:
>
>   bitmain/bm1880-sophon-edge.dtb: gpio@50027000: gpio-controller@0: 'gpio-line-names' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml b/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml
> index b391cc1b4590..209f03bba0a7 100644
> --- a/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml
> @@ -61,6 +61,10 @@ patternProperties:
>        '#gpio-cells':
>          const: 2
>
> +      gpio-line-names:
> +        minItems: 1
> +        maxItems: 32
> +
>        ngpios:
>          default: 32
>          minimum: 1
> --
> 2.34.1
>

Applied, thanks!

Bart
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml b/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml
index b391cc1b4590..209f03bba0a7 100644
--- a/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml
+++ b/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml
@@ -61,6 +61,10 @@  patternProperties:
       '#gpio-cells':
         const: 2
 
+      gpio-line-names:
+        minItems: 1
+        maxItems: 32
+
       ngpios:
         default: 32
         minimum: 1