| Message ID | 20230612011449.10195-1-takahiro.akashi@linaro.org |
|---|---|
| State | Accepted |
| Commit | 45a0052939927fbae35e419a7591877c41a06163 |
| Headers | show |
| Series | clk: scmi: claim the dependency on CONFIG_CLK | expand |
Hi Lukasz, Sean, Can you review this patch, please? -Takahiro Akashi On Mon, Jun 12, 2023 at 10:14:49AM +0900, AKASHI Takahiro wrote: > Without CONFIG_CLK, the build fails with the following message: > LD u-boot > aarch64-none-linux-gnu-ld.bfd: drivers/firmware/scmi/scmi_agent-uclass.o: \ > in function `scmi_bind_protocols': > .../drivers/firmware/scmi/scmi_agent-uclass.c:79: undefined reference to \ > `_u_boot_list_2_driver_2_scmi_clock' > > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org> > --- > drivers/clk/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index 3ad5af964f3f..29859cdfa158 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -160,6 +160,7 @@ config SANDBOX_CLK_CCF > > config CLK_SCMI > bool "Enable SCMI clock driver" > + depends on CLK > depends on SCMI_FIRMWARE > help > Enable this option if you want to support clock devices exposed > -- > 2.41.0 >
On 6/11/23 21:14, AKASHI Takahiro wrote: > Without CONFIG_CLK, the build fails with the following message: > LD u-boot > aarch64-none-linux-gnu-ld.bfd: drivers/firmware/scmi/scmi_agent-uclass.o: \ > in function `scmi_bind_protocols': > .../drivers/firmware/scmi/scmi_agent-uclass.c:79: undefined reference to \ > `_u_boot_list_2_driver_2_scmi_clock' > > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org> > --- > drivers/clk/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index 3ad5af964f3f..29859cdfa158 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -160,6 +160,7 @@ config SANDBOX_CLK_CCF > > config CLK_SCMI > bool "Enable SCMI clock driver" > + depends on CLK > depends on SCMI_FIRMWARE > help > Enable this option if you want to support clock devices exposed Reviewed-by: Sean Anderson <seanga2@gmail.com>
On Mon, Jun 12, 2023 at 10:14:49AM +0900, AKASHI Takahiro wrote: > Without CONFIG_CLK, the build fails with the following message: > LD u-boot > aarch64-none-linux-gnu-ld.bfd: drivers/firmware/scmi/scmi_agent-uclass.o: \ > in function `scmi_bind_protocols': > .../drivers/firmware/scmi/scmi_agent-uclass.c:79: undefined reference to \ > `_u_boot_list_2_driver_2_scmi_clock' > > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org> > Reviewed-by: Sean Anderson <seanga2@gmail.com> Applied to u-boot/master, thanks!
diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig index 3ad5af964f3f..29859cdfa158 100644 --- a/drivers/clk/Kconfig +++ b/drivers/clk/Kconfig @@ -160,6 +160,7 @@ config SANDBOX_CLK_CCF config CLK_SCMI bool "Enable SCMI clock driver" + depends on CLK depends on SCMI_FIRMWARE help Enable this option if you want to support clock devices exposed
Without CONFIG_CLK, the build fails with the following message: LD u-boot aarch64-none-linux-gnu-ld.bfd: drivers/firmware/scmi/scmi_agent-uclass.o: \ in function `scmi_bind_protocols': .../drivers/firmware/scmi/scmi_agent-uclass.c:79: undefined reference to \ `_u_boot_list_2_driver_2_scmi_clock' Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org> --- drivers/clk/Kconfig | 1 + 1 file changed, 1 insertion(+)