| Message ID | 20230706211045.204925-12-robdclark@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | drm/msm/adreno: Move away from legacy revision matching | expand |
On 06/07/2023 23:10, Rob Clark wrote: > From: Rob Clark <robdclark@chromium.org> > > Upcoming GPUs use an opaque chip-id for identifying the GPU. Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. You missed at least DT list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the patch to be tested. Please kindly resend and include all necessary To/Cc entries. Best regards, Krzysztof
On Fri, Jul 7, 2023 at 12:26 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On 06/07/2023 23:10, Rob Clark wrote: > > From: Rob Clark <robdclark@chromium.org> > > > > Upcoming GPUs use an opaque chip-id for identifying the GPU. > > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. Oh, whoops, I'd overlooked that I hadn't configured sendemail.cccmd on the laptop I was sending this from. I'll fix that before resending. BR, -R > You missed at least DT list (maybe more), so this won't be tested by > automated tooling. Performing review on untested code might be a waste > of time, thus I will skip this patch entirely till you follow the > process allowing the patch to be tested. > > Please kindly resend and include all necessary To/Cc entries. > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/display/msm/gpu.yaml b/Documentation/devicetree/bindings/display/msm/gpu.yaml index 58ca8912a8c3..56b9b247e8c2 100644 --- a/Documentation/devicetree/bindings/display/msm/gpu.yaml +++ b/Documentation/devicetree/bindings/display/msm/gpu.yaml @@ -13,6 +13,12 @@ maintainers: properties: compatible: oneOf: + - description: | + The driver is parsing the compat string for Adreno to + figure out the chip-id. + items: + - pattern: '^qcom,adreno-[0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f]$' + - const: qcom,adreno - description: | The driver is parsing the compat string for Adreno to figure out the gpu-id and patch level.