mbox series

[0/3] reset: meson-c3: add reset driver

Message ID 20230630121059.28748-1-zelong.dong@amlogic.com
Headers show
Series reset: meson-c3: add reset driver | expand

Message

zelong dong June 30, 2023, 12:10 p.m. UTC
From: Zelong Dong <zelong.dong@amlogic.com>

This patchset adds Reset controller driver support for Meson-C3 SoC.
The RESET registers count and offset for C3 Soc are same as S4 Soc.


Zelong Dong (3):
  dt-bindings: reset: Add compatible and DT bindings for Meson-C3 Reset
    Controller
  reset: reset-meson: add support for the Meson-C3 SoC Reset Controller
  arm64: dts: meson: add reset controller for Meson-C3 SoC

 .../bindings/reset/amlogic,meson-reset.yaml   |   1 +
 arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi   |   7 ++
 drivers/reset/reset-meson.c                   |   1 +
 .../reset/amlogic,meson-c3-reset.h            | 119 ++++++++++++++++++
 4 files changed, 128 insertions(+)
 create mode 100644 include/dt-bindings/reset/amlogic,meson-c3-reset.h

Comments

Krzysztof Kozlowski July 2, 2023, 9:33 a.m. UTC | #1
On 30/06/2023 14:10, zelong dong wrote:
> From: Zelong Dong <zelong.dong@amlogic.com>
> 
> Add new compatible and DT bindings for Amlogic's Meson-C3 Reset Controller
> 
> Change-Id: Ie8941818bde5b736689e43367f66827c5bc0449e

Please run scripts/checkpatch.pl and fix reported warnings. Some
warnings can be ignored, but the code here looks like it needs a fix.
Feel free to get in touch if the warning is not clear.

> Signed-off-by: Zelong Dong <zelong.dong@amlogic.com>

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC.  It might happen, that command when run on an older
kernel, gives you outdated entries.  Therefore please be sure you base
your patches on recent Linux kernel.

Best regards,
Krzysztof
Martin Blumenstingl July 3, 2023, 7:42 p.m. UTC | #2
On Fri, Jun 30, 2023 at 2:11 PM zelong dong <zelong.dong@amlogic.com> wrote:
>
> From: Zelong Dong <zelong.dong@amlogic.com>
>
> Add a new compatible string to support for the reset controller
> on the C3 SoC. The count and offset for C3 Soc RESET registers are
> same as S4 Soc.
>
> Change-Id: I65113f6a90545cd46015abf60b4bcb63fa148267
with this Change-Id removed (as mentioned for other patches in this series)

> Signed-off-by: Zelong Dong <zelong.dong@amlogic.com>
this patch gets my:
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>