| Message ID | 20230630100321.1951138-1-jstephan@baylibre.com |
|---|---|
| Headers | show |
| Series | Add Mediatek ISP3.0 | expand |
On Fri, 30 Jun 2023 12:01:50 +0200, Julien Stephan wrote: > From: Louis Kuo <louis.kuo@mediatek.com> > > This adds the bindings, for the mediatek ISP3.0 SENINF module embedded in > some Mediatek SoC, such as the mt8365 > > Signed-off-by: Louis Kuo <louis.kuo@mediatek.com> > Signed-off-by: Phi-Bang Nguyen <pnguyen@baylibre.com> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Julien Stephan <jstephan@baylibre.com> > --- > .../media/mediatek,mt8365-seninf.yaml | 295 ++++++++++++++++++ > MAINTAINERS | 7 + > 2 files changed, 302 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/mediatek,mt8365-seninf.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/media/mediatek,mt8365-seninf.example.dts:28:18: fatal error: dt-bindings/power/mediatek,mt8365-power.h: No such file or directory 28 | #include <dt-bindings/power/mediatek,mt8365-power.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[1]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/media/mediatek,mt8365-seninf.example.dtb] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1512: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230630100321.1951138-2-jstephan@baylibre.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Fri, Jun 30, 2023 at 12:01:50PM +0200, Julien Stephan wrote: > From: Louis Kuo <louis.kuo@mediatek.com> > > This adds the bindings, for the mediatek ISP3.0 SENINF module embedded in > some Mediatek SoC, such as the mt8365 > > Signed-off-by: Louis Kuo <louis.kuo@mediatek.com> > Signed-off-by: Phi-Bang Nguyen <pnguyen@baylibre.com> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Julien Stephan <jstephan@baylibre.com> > --- > .../media/mediatek,mt8365-seninf.yaml | 295 ++++++++++++++++++ > MAINTAINERS | 7 + > 2 files changed, 302 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/mediatek,mt8365-seninf.yaml > > diff --git a/Documentation/devicetree/bindings/media/mediatek,mt8365-seninf.yaml b/Documentation/devicetree/bindings/media/mediatek,mt8365-seninf.yaml > new file mode 100644 > index 000000000000..1697e94853f5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/mediatek,mt8365-seninf.yaml > @@ -0,0 +1,295 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (c) 2023 MediaTek, BayLibre > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/mediatek,mt8365-seninf.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek Sensor Interface 3.0 > + > +maintainers: > + - Laurent Pinchart <laurent.pinchart@ideasonboard.com> > + - Julien Stephan <jstephan@baylibre.com> > + - Andy Hsieh <andy.hsieh@mediatek.com> > + > +description: > + The ISP3.0 SENINF is the CSI-2 and parallel camera sensor interface found in > + multiple MediaTek SoCs. It can support up to three physical CSI-2 > + input ports, configured in DPHY (2 or 4 data lanes) or CPHY depending on the SoC. > + On the output side, SENINF can be connected either to CAMSV instance or > + to the internal ISP. CAMSV is used to transfer the sensor data (Raw, YUV) > + to DRAM directly, without internal ISP processing. > + > +properties: > + compatible: > + const: mediatek,mt8365-seninf > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > + clocks: > + items: > + - description: Seninf camsys clock > + - description: Seninf top mux clock > + > + clock-names: > + items: > + - const: camsys > + - const: top_mux > + > + phys: > + minItems: 1 > + maxItems: 4 > + description: > + phandle to the PHYs connected to CSI0/A, CSI1, CSI2 and CSI0B > + > + phy-names: > + minItems: 1 > + items: > + - const: csi0 > + - const: csi1 > + - const: csi2 > + - const: csi0b > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: CSI0 or CSI0A port > + > + properties: > + endpoint: > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + clock-lanes: > + maxItems: 1 > + data-lanes: > + minItems: 1 > + maxItems: 4 > + > + port@1: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: CSI1 port > + > + properties: > + endpoint: > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + clock-lanes: > + maxItems: 1 > + data-lanes: > + minItems: 1 > + maxItems: 4 > + > + port@2: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: CSI2 port > + > + properties: > + endpoint: > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + clock-lanes: > + maxItems: 1 > + data-lanes: > + minItems: 1 > + maxItems: 4 > + > + port@3: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: CSI0B port > + > + properties: > + endpoint: > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + clock-lanes: > + maxItems: 1 > + data-lanes: > + minItems: 1 > + maxItems: 2 > + > + port@4: > + $ref: /schemas/graph.yaml#/$defs/port-base /schemas/graph.yaml#/properties/port > + unevaluatedProperties: false Drop > + description: connection point for cam0 > + > + properties: Drop all this. Don't need to define endpoint as /schemas/graph.yaml#/properties/port already does. Same on other ports. > + endpoint: > + $ref: /schemas/graph.yaml#/$defs/endpoint-base > + unevaluatedProperties: false
Hi, Julien: Julien Stephan <jstephan@baylibre.com> 於 2023年6月30日 週五 下午6:05寫道： > > From: Louis Kuo <louis.kuo@mediatek.com> > > This will add the mediatek ISP3.0 seninf (sensor interface) driver found > on several Mediatek SoCs such as the mt8365. > > Then seninf module has 4 physical CSI-2 inputs. Depending on the soc they > may not be all connected. > > Signed-off-by: Louis Kuo <louis.kuo@mediatek.com> > Signed-off-by: Phi-bang Nguyen <pnguyen@baylibre.com> > Signed-off-by: Florian Sylvestre <fsylvestre@baylibre.com> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Julien Stephan <jstephan@baylibre.com> > --- > MAINTAINERS | 1 + > drivers/media/platform/mediatek/Kconfig | 1 + > drivers/media/platform/mediatek/Makefile | 1 + > drivers/media/platform/mediatek/isp/Kconfig | 2 + > drivers/media/platform/mediatek/isp/Makefile | 3 + > .../platform/mediatek/isp/isp_30/Kconfig | 16 + > .../platform/mediatek/isp/isp_30/Makefile | 3 + > .../mediatek/isp/isp_30/seninf/Makefile | 5 + > .../mediatek/isp/isp_30/seninf/mtk_seninf.c | 1561 +++++++++++++++++ > .../isp/isp_30/seninf/mtk_seninf_reg.h | 99 ++ I think it's not necessary to create a folder isp_30 inside isp and you could just place all file in isp folder because there are only few files. After adding more and more files then we consider to create folder to separate them. Regards, Chun-Kuang. > 10 files changed, 1692 insertions(+) > create mode 100644 drivers/media/platform/mediatek/isp/Kconfig > create mode 100644 drivers/media/platform/mediatek/isp/Makefile > create mode 100644 drivers/media/platform/mediatek/isp/isp_30/Kconfig > create mode 100644 drivers/media/platform/mediatek/isp/isp_30/Makefile > create mode 100644 drivers/media/platform/mediatek/isp/isp_30/seninf/Makefile > create mode 100644 drivers/media/platform/mediatek/isp/isp_30/seninf/mtk_seninf.c > create mode 100644 drivers/media/platform/mediatek/isp/isp_30/seninf/mtk_seninf_reg.h > >
Hi, Julien: Julien Stephan <jstephan@baylibre.com> 於 2023年6月30日 週五 下午6:05寫道： > > From: Louis Kuo <louis.kuo@mediatek.com> > > This will add the mediatek ISP3.0 seninf (sensor interface) driver found > on several Mediatek SoCs such as the mt8365. > > Then seninf module has 4 physical CSI-2 inputs. Depending on the soc they > may not be all connected. > > Signed-off-by: Louis Kuo <louis.kuo@mediatek.com> > Signed-off-by: Phi-bang Nguyen <pnguyen@baylibre.com> > Signed-off-by: Florian Sylvestre <fsylvestre@baylibre.com> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Julien Stephan <jstephan@baylibre.com> > [snip] > + > +static const struct mtk_seninf_conf seninf_8365_conf = { > + .model = "mtk-camsys-3.0", > + .nb_inputs = 4, > + .nb_muxes = 6, > + .nb_outputs = 4, > +}; > + > +static const struct of_device_id mtk_seninf_of_match[] = { > + { > + .compatible = "mediatek,mt8365-seninf", > + .data = &seninf_8365_conf, Now only support one SoC, so it's necessary to select the SoC data and you could directly place the data in the code. After support other SoC, so we could know what should be placed in struct mtg_seninf_conf (Now we have no any information). Regards, Chun-Kuang. > + }, > + { > + }, > +}; > +MODULE_DEVICE_TABLE(of, mtk_seninf_of_match);
Hi, Julien: Chun-Kuang Hu <chunkuang.hu@kernel.org> 於 2023年7月2日 週日 上午7:35寫道： > > Hi, Julien: > > Julien Stephan <jstephan@baylibre.com> 於 2023年6月30日 週五 下午6:05寫道： > > > > From: Louis Kuo <louis.kuo@mediatek.com> > > > > This will add the mediatek ISP3.0 seninf (sensor interface) driver found > > on several Mediatek SoCs such as the mt8365. > > > > Then seninf module has 4 physical CSI-2 inputs. Depending on the soc they > > may not be all connected. > > > > Signed-off-by: Louis Kuo <louis.kuo@mediatek.com> > > Signed-off-by: Phi-bang Nguyen <pnguyen@baylibre.com> > > Signed-off-by: Florian Sylvestre <fsylvestre@baylibre.com> > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Signed-off-by: Julien Stephan <jstephan@baylibre.com> > > > > [snip] > > > + > > +static const struct mtk_seninf_conf seninf_8365_conf = { > > + .model = "mtk-camsys-3.0", > > + .nb_inputs = 4, > > + .nb_muxes = 6, > > + .nb_outputs = 4, > > +}; > > + > > +static const struct of_device_id mtk_seninf_of_match[] = { > > + { > > + .compatible = "mediatek,mt8365-seninf", > > + .data = &seninf_8365_conf, > > Now only support one SoC, so it's necessary to select the SoC data and > you could directly place the data in the code. After support other Typo. Now only support one SoC, so it's not necessary to select the SoC data and you could directly place the data in the code. Regards, Chun-Kuang. > SoC, so we could know what should be placed in struct mtg_seninf_conf > (Now we have no any information). > > Regards, > Chun-Kuang. > > > + }, > > + { > > + }, > > +}; > > +MODULE_DEVICE_TABLE(of, mtk_seninf_of_match);
On Sun, Jul 02, 2023 at 05:20:25PM +0800, Chun-Kuang Hu wrote: > Chun-Kuang Hu <chunkuang.hu@kernel.org> 於 2023年7月2日 週日 上午7:35寫道： > > Julien Stephan <jstephan@baylibre.com> 於 2023年6月30日 週五 下午6:05寫道： > > > > > > From: Louis Kuo <louis.kuo@mediatek.com> > > > > > > This will add the mediatek ISP3.0 seninf (sensor interface) driver found > > > on several Mediatek SoCs such as the mt8365. > > > > > > Then seninf module has 4 physical CSI-2 inputs. Depending on the soc they > > > may not be all connected. > > > > > > Signed-off-by: Louis Kuo <louis.kuo@mediatek.com> > > > Signed-off-by: Phi-bang Nguyen <pnguyen@baylibre.com> > > > Signed-off-by: Florian Sylvestre <fsylvestre@baylibre.com> > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > Signed-off-by: Julien Stephan <jstephan@baylibre.com> > > > > > > > [snip] > > > > > + > > > +static const struct mtk_seninf_conf seninf_8365_conf = { > > > + .model = "mtk-camsys-3.0", > > > + .nb_inputs = 4, > > > + .nb_muxes = 6, > > > + .nb_outputs = 4, > > > +}; > > > + > > > +static const struct of_device_id mtk_seninf_of_match[] = { > > > + { > > > + .compatible = "mediatek,mt8365-seninf", > > > + .data = &seninf_8365_conf, > > > > Now only support one SoC, so it's necessary to select the SoC data and > > you could directly place the data in the code. After support other > > Typo. > > Now only support one SoC, so it's not necessary to select the SoC data > and you could directly place the data in the code. I think Julien has visibility on other SoCs that could use the same driver, and has designed the mtk_seninf_conf structure accordingly. I'll let Julien confirm (or tell I'm wrong). > > SoC, so we could know what should be placed in struct mtg_seninf_conf > > (Now we have no any information). > > > > > + }, > > > + { > > > + }, > > > +}; > > > +MODULE_DEVICE_TABLE(of, mtk_seninf_of_match);
Il 03/07/23 14:18, Laurent Pinchart ha scritto: > On Sun, Jul 02, 2023 at 05:20:25PM +0800, Chun-Kuang Hu wrote: >> Chun-Kuang Hu <chunkuang.hu@kernel.org> 於 2023年7月2日 週日 上午7:35寫道： >>> Julien Stephan <jstephan@baylibre.com> 於 2023年6月30日 週五 下午6:05寫道： >>>> >>>> From: Louis Kuo <louis.kuo@mediatek.com> >>>> >>>> This will add the mediatek ISP3.0 seninf (sensor interface) driver found >>>> on several Mediatek SoCs such as the mt8365. >>>> >>>> Then seninf module has 4 physical CSI-2 inputs. Depending on the soc they >>>> may not be all connected. >>>> >>>> Signed-off-by: Louis Kuo <louis.kuo@mediatek.com> >>>> Signed-off-by: Phi-bang Nguyen <pnguyen@baylibre.com> >>>> Signed-off-by: Florian Sylvestre <fsylvestre@baylibre.com> >>>> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >>>> Signed-off-by: Julien Stephan <jstephan@baylibre.com> >>>> >>> >>> [snip] >>> >>>> + >>>> +static const struct mtk_seninf_conf seninf_8365_conf = { >>>> + .model = "mtk-camsys-3.0", >>>> + .nb_inputs = 4, >>>> + .nb_muxes = 6, >>>> + .nb_outputs = 4, >>>> +}; >>>> + >>>> +static const struct of_device_id mtk_seninf_of_match[] = { >>>> + { >>>> + .compatible = "mediatek,mt8365-seninf", >>>> + .data = &seninf_8365_conf, >>> >>> Now only support one SoC, so it's necessary to select the SoC data and >>> you could directly place the data in the code. After support other >> >> Typo. >> >> Now only support one SoC, so it's not necessary to select the SoC data >> and you could directly place the data in the code. > > I think Julien has visibility on other SoCs that could use the same > driver, and has designed the mtk_seninf_conf structure accordingly. I'll > let Julien confirm (or tell I'm wrong). > You're not wrong. Cheers, Angelo >>> SoC, so we could know what should be placed in struct mtg_seninf_conf >>> (Now we have no any information). >>> >>>> + }, >>>> + { >>>> + }, >>>> +}; >>>> +MODULE_DEVICE_TABLE(of, mtk_seninf_of_match); >
This series add the support of the Mediatek ISP3.0 found on some Mediatek SoCs such as the mt8365. The driver is divided into 2 parts: * SENINF: the sensor interface * CAMSV: this driver provides a path to bypass the SoC ISP so that image data coming from the SENINF can go directly into memory without any image processing. This allows the use of an external ISP or camera sensor directly. The SENINF driver is based on previous work done by Louis Kuo available as an RFC here: https://lore.kernel.org/all/20200708104023.3225-1-louis.kuo@mediatek.com/ This series depends on the following series: [1] for the phy, [2] for power management support Changes in v2: - renamed clock `cam_seninf` to `camsys` - renamed clock `top_mux_seninf` to `top_mux` - moved phy properties from port nodes to top level - remove patternProperties - specify power management dependency in the cover letter description to fix missing include in dt-binding example - change '$ref' properties on some endpoint nodes from '$ref: video-interfaces.yaml#' to '$ref: /schemas/graph.yaml#/$defs/endpoint-base' where applicable Best Julien Stephan [1] : https://lore.kernel.org/all/20230620121928.1231745-1-jstephan@baylibre.com/ [2] : https://lore.kernel.org/lkml/20230627131040.3418538-1-msp@baylibre.com/ Louis Kuo (2): dt-bindings: media: add mediatek ISP3.0 sensor interface media: platform: mediatek: isp_30: add mediatek ISP3.0 sensor interface Phi-bang Nguyen (2): dt-bindings: media: add mediatek ISP3.0 camsv media: platform: mediatek: isp_30: add mediatek ISP3.0 camsv .../bindings/media/mediatek,mt8365-camsv.yaml | 113 ++ .../media/mediatek,mt8365-seninf.yaml | 295 ++++ MAINTAINERS | 10 + drivers/media/platform/mediatek/Kconfig | 1 + drivers/media/platform/mediatek/Makefile | 1 + drivers/media/platform/mediatek/isp/Kconfig | 2 + drivers/media/platform/mediatek/isp/Makefile | 3 + .../platform/mediatek/isp/isp_30/Kconfig | 35 + .../platform/mediatek/isp/isp_30/Makefile | 4 + .../mediatek/isp/isp_30/camsv/Makefile | 7 + .../mediatek/isp/isp_30/camsv/mtk_camsv.c | 334 ++++ .../mediatek/isp/isp_30/camsv/mtk_camsv.h | 200 +++ .../isp/isp_30/camsv/mtk_camsv30_hw.c | 474 +++++ .../isp/isp_30/camsv/mtk_camsv30_regs.h | 59 + .../isp/isp_30/camsv/mtk_camsv_video.c | 781 +++++++++ .../mediatek/isp/isp_30/seninf/Makefile | 5 + .../mediatek/isp/isp_30/seninf/mtk_seninf.c | 1561 +++++++++++++++++ .../isp/isp_30/seninf/mtk_seninf_reg.h | 99 ++ 18 files changed, 3984 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/mediatek,mt8365-camsv.yaml create mode 100644 Documentation/devicetree/bindings/media/mediatek,mt8365-seninf.yaml create mode 100644 drivers/media/platform/mediatek/isp/Kconfig create mode 100644 drivers/media/platform/mediatek/isp/Makefile create mode 100644 drivers/media/platform/mediatek/isp/isp_30/Kconfig create mode 100644 drivers/media/platform/mediatek/isp/isp_30/Makefile create mode 100644 drivers/media/platform/mediatek/isp/isp_30/camsv/Makefile create mode 100644 drivers/media/platform/mediatek/isp/isp_30/camsv/mtk_camsv.c create mode 100644 drivers/media/platform/mediatek/isp/isp_30/camsv/mtk_camsv.h create mode 100644 drivers/media/platform/mediatek/isp/isp_30/camsv/mtk_camsv30_hw.c create mode 100644 drivers/media/platform/mediatek/isp/isp_30/camsv/mtk_camsv30_regs.h create mode 100644 drivers/media/platform/mediatek/isp/isp_30/camsv/mtk_camsv_video.c create mode 100644 drivers/media/platform/mediatek/isp/isp_30/seninf/Makefile create mode 100644 drivers/media/platform/mediatek/isp/isp_30/seninf/mtk_seninf.c create mode 100644 drivers/media/platform/mediatek/isp/isp_30/seninf/mtk_seninf_reg.h -- 2.41.0