mbox series

[0/2] ASoC: fsl_sai: Fill Tx FIFO to avoid initial underruns

Message ID 20230629135820.2631908-1-s.hauer@pengutronix.de
Headers show
Series ASoC: fsl_sai: Fill Tx FIFO to avoid initial underruns | expand

Message

Sascha Hauer June 29, 2023, 1:58 p.m. UTC 
This series fixes initial underruns that can occur in the TX queue of the
fsl_sai interface when starting playback. These patches are around here
for quite some time and have proven useful. Time to upstream them.

Sascha

Ahmad Fatoum (2):
  ASoC: fsl_sai: refactor TDM slots calculation into helper function
  ASoC: fsl_sai: Fill Tx FIFO to avoid initial underruns

 sound/soc/fsl/fsl_sai.c | 38 +++++++++++++++++++++++++++++++++-----
 sound/soc/fsl/fsl_sai.h |  1 +
 2 files changed, 34 insertions(+), 5 deletions(-)

Comments

Mark Brown June 29, 2023, 2:03 p.m. UTC | #1 
On Thu, Jun 29, 2023 at 03:58:19PM +0200, Sascha Hauer wrote:
> From: Ahmad Fatoum <a.fatoum@pengutronix.de>
> 
> Splitting the calculation between the initializer and later on makes it
> harder to follow. A follow-up commit will also need to do this calculation,
> so move it into a helper function. No functional change.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---

You've not provided a Signed-off-by for this so I can't do anything with
it, please see Documentation/process/submitting-patches.rst for details
on what this is and why it's important.