Message ID | 20230623203056.689705-1-varshini.rajendran@microchip.com |
---|---|
Headers | show |
Series | Add support for sam9x7 SoC family | expand |
On 23/06/2023 22:30, Varshini Rajendran wrote: > Add sam9x60, sam9x7 compatible string support in the schema file. > > Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com> > --- > .../devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml | Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 23/06/2023 22:30, Varshini Rajendran wrote: > Document the property clock-names in the schema. > > It fixes the dtbs_check warning, > 'clock-names' does not match any of the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com> > --- > Documentation/devicetree/bindings/usb/generic-ehci.yaml | 4 ++++ This is a friendly reminder during the review process. It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. Best regards, Krzysztof
On 23/06/2023 22:30, Varshini Rajendran wrote: > This patch series adds support for the new SoC family - sam9x7. > - The device tree, configs and drivers are added > - Clock driver for sam9x7 is added > - Support for basic peripherals is added > - Target board SAM9X75 Curiosity is added Your CC list is enormous and causes multiple bounces/rejections. Organize your patchset properly to avoid this. Best regards, Krzysztof
On 23/06/2023 22:30, Varshini Rajendran wrote: > Add DT bindings for atmel AES. > > Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com> > --- > .../devicetree/bindings/crypto/atmel,at91sam9g46-aes.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-aes.yaml b/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-aes.yaml > index 0b7383b3106b..f0736696c883 100644 > --- a/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-aes.yaml > +++ b/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-aes.yaml > @@ -12,7 +12,10 @@ maintainers: > > properties: > compatible: > - const: atmel,at91sam9g46-aes > + oneOf: This is not oneOf. > + - items: And these are not items. You just broke existing users, which points to the fact that you did not test the bindings nor the DTS. You didn't test anything here. This comment applies for entire patchset - please test everything. I expect v3, after testing. Best regards, Krzysztof
On 23/06/2023 22:30, Varshini Rajendran wrote: > Add compatible string for sam9x7. > > Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com> > --- > Documentation/devicetree/bindings/i2c/atmel,at91sam-i2c.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/i2c/atmel,at91sam-i2c.yaml b/Documentation/devicetree/bindings/i2c/atmel,at91sam-i2c.yaml > index 6adedd3ec399..440f890e209f 100644 > --- a/Documentation/devicetree/bindings/i2c/atmel,at91sam-i2c.yaml > +++ b/Documentation/devicetree/bindings/i2c/atmel,at91sam-i2c.yaml > @@ -24,9 +24,11 @@ properties: > - atmel,sama5d4-i2c > - atmel,sama5d2-i2c > - microchip,sam9x60-i2c > + - microchip,sam9x7-i2c Same as in other cases, so just to avoid applying by submaintainer: looks not tested and not working. Best regards, Krzysztof
On 23/06/2023 22:30, Varshini Rajendran wrote: > Add compatbile for Microchip sam9x7 TRNG. > > Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com> > --- > Documentation/devicetree/bindings/rng/atmel,at91-trng.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/rng/atmel,at91-trng.yaml b/Documentation/devicetree/bindings/rng/atmel,at91-trng.yaml > index 3ce45456d867..7e4dbf5e22b4 100644 > --- a/Documentation/devicetree/bindings/rng/atmel,at91-trng.yaml > +++ b/Documentation/devicetree/bindings/rng/atmel,at91-trng.yaml > @@ -17,6 +17,7 @@ properties: > - enum: > - atmel,at91sam9g45-trng > - microchip,sam9x60-trng > + - microchip,sam9x7-trng Same as in other cases, so just to avoid applying by submaintainer: looks not tested and not working. Best regards, Krzysztof
On 23/06/2023 22:30, Varshini Rajendran wrote: > Add sam9x7 compatible to DT bindings documentation. > > Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com> > --- > Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml b/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml > index 30b2131b5860..d836224f99c6 100644 > --- a/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml > +++ b/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml > @@ -17,6 +17,7 @@ properties: > - atmel,at91rm9200-usart > - atmel,at91sam9260-usart > - microchip,sam9x60-usart > + - microchip,sam9x7-usart > - items: > - const: atmel,at91rm9200-dbgu > - const: atmel,at91rm9200-usart > @@ -26,6 +27,8 @@ properties: > - items: > - const: microchip,sam9x60-dbgu > - const: microchip,sam9x60-usart > + - const: microchip,sam9x7-dbgu > + - const: microchip,sam9x7-usart Same as in other cases, so just to avoid applying by submaintainer: not tested, broken. Best regards, Krzysztof
On 23/06/2023 22:30, Varshini Rajendran wrote: > Add sam9x7 compatible to DT bindings documentation. > > Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com> > --- > Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml b/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml > index 6c57dd6c3a36..bdc42eeacba4 100644 > --- a/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml > +++ b/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml > @@ -19,6 +19,7 @@ properties: > - const: atmel,at91rm9200-spi > - items: > - const: microchip,sam9x60-spi > + - const: microchip,sam9x7-spi > - const: atmel,at91rm9200-spi > Same as in other cases, so just to avoid applying by maintainer: not tested, broken. Best regards, Krzysztof
On 23/06/2023 22:30, Varshini Rajendran wrote: > Add device tree file for sam9x75 curiosity board. > > Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com> > --- > arch/arm/boot/dts/Makefile | 2 + > arch/arm/boot/dts/at91-sam9x75_curiosity.dts | 336 +++++++++++++++++++ > 2 files changed, 338 insertions(+) > create mode 100644 arch/arm/boot/dts/at91-sam9x75_curiosity.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 59829fc90315..31f357f8e947 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -53,6 +53,8 @@ dtb-$(CONFIG_SOC_AT91SAM9) += \ > dtb-$(CONFIG_SOC_SAM9X60) += \ > at91-sam9x60_curiosity.dtb \ > at91-sam9x60ek.dtb > +dtb-$(CONFIG_SOC_SAM9X7) += \ > + at91-sam9x75_curiosity.dtb > dtb-$(CONFIG_SOC_SAM_V7) += \ > at91-kizbox2-2.dtb \ > at91-kizbox3-hs.dtb \ > diff --git a/arch/arm/boot/dts/at91-sam9x75_curiosity.dts b/arch/arm/boot/dts/at91-sam9x75_curiosity.dts > new file mode 100644 > index 000000000000..56d3af549201 > --- /dev/null > +++ b/arch/arm/boot/dts/at91-sam9x75_curiosity.dts > @@ -0,0 +1,336 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * at91-sam9x75_curiosity.dts - Device Tree file for Microchip SAM9X75 Curiosity board > + * > + * Copyright (C) 2023 Microchip Technology Inc. and its subsidiaries > + * > + * Author: Varshini Rajendran <varshini.rajendran@microchip.com> > + */ > +/dts-v1/; > +#include "sam9x7.dtsi" > +#include <dt-bindings/input/input.h> > + > +/ { > + model = "Microchip SAM9X75 Curiosity"; > + compatible = "microchip,sam9x75-curiosity", "microchip,sam9x7", "atmel,at91sam9"; > + > + aliases { > + i2c0 = &i2c6; > + i2c1 = &i2c7; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + clocks { > + clock-slowxtal { > + clock-frequency = <32768>; > + }; > + > + clock-mainxtal { > + clock-frequency = <24000000>; > + }; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_key_gpio_default>; > + status = "okay"; Why? Did you disable it? > + > + button-user { > + label = "USER"; > + gpios = <&pioC 9 GPIO_ACTIVE_LOW>; > + linux,code = <KEY_PROG1>; > + wakeup-source; > + }; > + }; > + > + leds { > + compatible = "gpio-leds"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_led_gpio_default>; > + status = "okay"; Why? Did you disable it? > + > + led-0 { > + label = "red"; > + gpios = <&pioC 19 GPIO_ACTIVE_HIGH>; > + }; > + > + led-1 { > + label = "green"; > + gpios = <&pioC 21 GPIO_ACTIVE_HIGH>; > + }; > + > + led-2 { > + label = "blue"; > + gpios = <&pioC 20 GPIO_ACTIVE_HIGH>; > + linux,default-trigger = "heartbeat"; > + }; > + }; > + > + memory@20000000 { > + device_type = "memory"; > + reg = <0x20000000 0x10000000>; > + }; > +}; > + > +&dbgu { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_dbgu>; > + status = "okay"; > +}; > + > +&dma0 { > + status = "okay"; > +}; > + > +&ehci0 { > + status = "okay"; > +}; > + > +&flx6 { > + atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_TWI>; > + status = "okay"; > + > + i2c6: i2c@600 { > + #address-cells = <1>; > + #size-cells = <0>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_flx6_default>; > + i2c-analog-filter; > + i2c-digital-filter; > + i2c-digital-filter-width-ns = <35>; > + status = "okay"; Did you disable it? If so this should be overridden by label... > + > + mcp16502@5b { Node names should be generic. See also explanation and list of examples in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "microchip,mcp16502"; > + reg = <0x5b>; > + status = "okay"; Srsly, drop. > + > + regulators { > + vdd_3v3: VDD_IO { > + regulator-name = "VDD_IO"; > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3600000>; ... > +&flx7 { > + atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_TWI>; > + status = "okay"; > + > + i2c7: i2c@600 { > + #address-cells = <1>; > + #size-cells = <0>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_flx7_default>; > + i2c-analog-filter; > + i2c-digital-filter; > + i2c-digital-filter-width-ns = <35>; > + status = "okay"; Empty bus. Keep disabled. Anyway overrides should be done via label, not by duplicating children. > + }; > +}; > + > +&ohci0 { > + num-ports = <3>; > + atmel,vbus-gpio = <0 > + &pioC 27 GPIO_ACTIVE_HIGH > + &pioB 18 GPIO_ACTIVE_HIGH>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_usb_default>; > + status = "okay"; > +}; > + > +&pinctrl { > + > + dbgu { > + pinctrl_dbgu: dbgu-0 { > + atmel,pins = <AT91_PIOA 26 AT91_PERIPH_A AT91_PINCTRL_PULL_UP > + AT91_PIOA 27 AT91_PERIPH_A AT91_PINCTRL_NONE>; > + }; > + }; > + > + flexcom { > + pinctrl_flx6_default: flx6_twi { No underscors in node names. This applies everywhere. Best regards, Krzysztof
On 23/06/2023 22:30, Varshini Rajendran wrote: > Add sam9x7 bindings. > > Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com> > --- > Documentation/devicetree/bindings/usb/atmel-usb.txt | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/atmel-usb.txt b/Documentation/devicetree/bindings/usb/atmel-usb.txt > index 12183ef47ee4..6359af0123bf 100644 > --- a/Documentation/devicetree/bindings/usb/atmel-usb.txt > +++ b/Documentation/devicetree/bindings/usb/atmel-usb.txt > @@ -3,8 +3,8 @@ Atmel SOC USB controllers > OHCI > > Required properties: > - - compatible: Should be "atmel,at91rm9200-ohci" for USB controllers > - used in host mode. > + - compatible: Should be "atmel,at91rm9200-ohci" or "microchip,sam9x7-ohci" That's not what your DTS is saying. NAK. Best regards, Krzysztof
On 23/06/2023 22:30, Varshini Rajendran wrote: > Add microchip,sam9x7-pmecc to DT bindings documentation. > > Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com> > --- > Documentation/devicetree/bindings/mtd/atmel-nand.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/mtd/atmel-nand.txt b/Documentation/devicetree/bindings/mtd/atmel-nand.txt > index 50645828ac20..9c9dfab38fdf 100644 > --- a/Documentation/devicetree/bindings/mtd/atmel-nand.txt > +++ b/Documentation/devicetree/bindings/mtd/atmel-nand.txt > @@ -56,6 +56,7 @@ Required properties: > "atmel,sama5d4-pmecc" > "atmel,sama5d2-pmecc" > "microchip,sam9x60-pmecc" > + "microchip,sam9x7-pmecc" That's not what your DTS is saying. NAK. Best regards, Krzysztof
On 23/06/2023 22:30, Varshini Rajendran wrote: > Add compatible for sam9x7. > > Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com> > --- > Documentation/devicetree/bindings/dma/atmel-xdma.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/dma/atmel-xdma.txt b/Documentation/devicetree/bindings/dma/atmel-xdma.txt > index 510b7f25ba24..f672556ea715 100644 > --- a/Documentation/devicetree/bindings/dma/atmel-xdma.txt > +++ b/Documentation/devicetree/bindings/dma/atmel-xdma.txt > @@ -2,8 +2,8 @@ > > * XDMA Controller > Required properties: > -- compatible: Should be "atmel,sama5d4-dma", "microchip,sam9x60-dma" or > - "microchip,sama7g5-dma". > +- compatible: Should be "atmel,sama5d4-dma", "microchip,sam9x60-dma", > + "microchip,sam9x7-dma" or "microchip,sama7g5-dma". That's not what your DTS is saying. NAK. Best regards, Krzysztof
On 24/06/2023 09:53, Krzysztof Kozlowski wrote: > On 23/06/2023 22:30, Varshini Rajendran wrote: >> Add sam9x60, sam9x7 compatible string support in the schema file. >> >> Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com> >> --- >> .../devicetree/bindings/soc/microchip/atmel,at91rm9200-tcb.yaml | > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Un-acked. Actually NAK. This does not match your DTS. Please test your patches before sending. Best regards, Krzysztof