mbox series

[RFC,0/4] input: touchscreen: add initial support for Goodix Berlin touchscreen IC

Message ID 20230606-topic-goodix-berlin-upstream-initial-v1-0-4a0741b8aefd@linaro.org
Headers show
Series input: touchscreen: add initial support for Goodix Berlin touchscreen IC | expand

Message

Neil Armstrong June 6, 2023, 2:31 p.m. UTC 
These touchscreen ICs support SPI, I2C and I3C interface, up to
10 finger touch, stylus and gestures events.

This initial driver is derived from the Goodix goodix_ts_berlin
available at [1] and [2] and only supports the GT9916 IC
present on the Qualcomm SM8550 MTP & QRD touch panel.

The current implementation only supports BerlinD, aka GT9916.

Support for advanced features like:
- Firmware & config update
- Stylus events
- Gestures events
- Previous revisions support (BerlinA or BerlinB)
is not included in current version.

The current support will work with currently flashed firmware
and config, and bail out if firmware or config aren't flashed yet.

[1] https://github.com/goodix/goodix_ts_berlin
[2] https://git.codelinaro.org/clo/la/platform/vendor/opensource/touch-drivers

Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
Neil Armstrong (4):
      dt-bindings: input: document Goodix Berlin Touchscreen IC
      input: touchscreen: add core support for Goodix Berlin Touchscreen IC
      input: touchscreen: add I2C support for Goodix Berlin Touchscreen IC
      input: touchscreen: add SPI support for Goodix Berlin Touchscreen IC

 .../bindings/input/touchscreen/goodix-berlin.yaml  |  81 ++
 drivers/input/touchscreen/Kconfig                  |  33 +
 drivers/input/touchscreen/Makefile                 |   3 +
 drivers/input/touchscreen/goodix_berlin.h          | 228 +++++
 drivers/input/touchscreen/goodix_berlin_core.c     | 935 +++++++++++++++++++++
 drivers/input/touchscreen/goodix_berlin_i2c.c      |  76 ++
 drivers/input/touchscreen/goodix_berlin_spi.c      | 183 ++++
 7 files changed, 1539 insertions(+)
---
base-commit: 6db29e14f4fb7bce9eb5290288e71b05c2b0d118
change-id: 20230606-topic-goodix-berlin-upstream-initial-ba97e8ec8f4c

Best regards,

Comments

Pavel Machek June 19, 2023, 7:06 a.m. UTC | #1 
Hi!

> > Sure, should I write it down here and/or update the commit message in a new revision ?
> 
> Yes please add this to the commit msg for the next version.

Actually, putting this into comment in the driver itself might be
good.

BR,
								Pavel