| Message ID | 20230618114442.140185-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Accepted |
| Commit | 44f2f74df42910ae3a2289f1020788a348089718 |
| Headers | show |
| Series | [1/7] arm64: dts: qcom: sm8350-hdk: correct FSA4480 port | expand |
On 18/06/2023 13:44, Krzysztof Kozlowski wrote: > FSA4480 has only one port according to bindings: > > sm8450-hdk.dtb: typec-mux@42: 'port' is a required property > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 13 +++---------- > 1 file changed, 3 insertions(+), 10 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts > index d7975b3cf064..e5cbea92e07a 100644 > --- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts > +++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts > @@ -518,16 +518,9 @@ typec-mux@42 { > mode-switch; > orientation-switch; > > - ports { > - #address-cells = <1>; > - #size-cells = <0>; > - > - port@0 { > - reg = <0>; > - > - fsa4480_sbu_mux: endpoint { > - remote-endpoint = <&pmic_glink_sbu>; > - }; > + port { > + fsa4480_sbu_mux: endpoint { > + remote-endpoint = <&pmic_glink_sbu>; > }; > }; > }; Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
On 18.06.2023 13:44, Krzysztof Kozlowski wrote: > There is no 'msg-size' property in ramoops, so assume intention was for > 'pmsg-size': > > sm6350-sony-xperia-lena-pdx213.dtb: ramoops@ffc00000: Unevaluated properties are not allowed ('msg-size' was unexpected) > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > arch/arm64/boot/dts/qcom/sm6350.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qcom/sm6350.dtsi > index 30e77010aed5..698171bda9fa 100644 > --- a/arch/arm64/boot/dts/qcom/sm6350.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi > @@ -673,7 +673,7 @@ ramoops: ramoops@ffc00000 { > reg = <0 0xffc00000 0 0x100000>; > record-size = <0x1000>; > console-size = <0x40000>; > - msg-size = <0x20000 0x20000>; > + pmsg-size = <0x20000>; > ecc-size = <16>; > no-map; > };
diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts index b182f4cf06cc..95a2a42ccb9e 100644 --- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts +++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts @@ -349,16 +349,9 @@ typec-mux@42 { mode-switch; orientation-switch; - ports { - #address-cells = <1>; - #size-cells = <0>; - - port@0 { - reg = <0>; - - fsa4480_sbu_mux: endpoint { - remote-endpoint = <&pmic_glink_sbu>; - }; + port { + fsa4480_sbu_mux: endpoint { + remote-endpoint = <&pmic_glink_sbu>; }; }; };
FSA4480 has only one port according to bindings: sm8350-hdk.dtb: typec-mux@42: 'port' is a required property Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-)