| Message ID | f325bf521f1cdc498dbd48b14191d186bdf7b602.1684854545.git.geert+renesas@glider.be |
|---|---|
| State | Accepted |
| Commit | 49904a0ebf23b15aad288a10f5354e7cd8193121 |
| Headers | show |
| Series | [v2] HID: uclogic: Modular KUnit tests should not depend on KUNIT=y | expand |
On Tue, 23 May 2023, Geert Uytterhoeven wrote: > While KUnit tests that cannot be built as a loadable module must depend > on "KUNIT=y", this is not true for modular tests, where it adds an > unnecessary limitation. > > Fix this by relaxing the dependency to "KUNIT". > > Fixes: 08809e482a1c44d9 ("HID: uclogic: KUnit best practices and naming conventions") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > Reviewed-by: David Gow <davidgow@google.com> > Reviewed-by: José Expósito <jose.exposito89@gmail.com> Applied, thanks.
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index 4ce012f83253ec9f..b977450cac75265d 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -1285,7 +1285,7 @@ config HID_MCP2221 config HID_KUNIT_TEST tristate "KUnit tests for HID" if !KUNIT_ALL_TESTS - depends on KUNIT=y + depends on KUNIT depends on HID_BATTERY_STRENGTH depends on HID_UCLOGIC default KUNIT_ALL_TESTS
While KUnit tests that cannot be built as a loadable module must depend on "KUNIT=y", this is not true for modular tests, where it adds an unnecessary limitation. Fix this by relaxing the dependency to "KUNIT". Fixes: 08809e482a1c44d9 ("HID: uclogic: KUnit best practices and naming conventions") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: David Gow <davidgow@google.com> Reviewed-by: José Expósito <jose.exposito89@gmail.com> --- v2: - Add Reviewed-by. --- drivers/hid/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)