| Message ID | 20230613170327.61186-1-adrian.hunter@intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | scsi: ufs: ufs-pci: Add support for Intel Arrow Lake | expand |
On 13/06/23 21:22, Bart Van Assche wrote: > On 6/13/23 10:03, Adrian Hunter wrote: >> Add PCI ID to support Intel Arrow Lake, same as MTL. > > The patch looks good to me but the "same as MTL" text in the patch description looks confusing to me? The code change is using the same driver data as MTL: diff --git a/drivers/ufs/host/ufshcd-pci.c b/drivers/ufs/host/ufshcd-pci.c index 38276dac8e52..cf3987773051 100644 --- a/drivers/ufs/host/ufshcd-pci.c +++ b/drivers/ufs/host/ufshcd-pci.c @@ -599,6 +599,7 @@ static const struct pci_device_id ufshcd_pci_tbl[] = { { PCI_VDEVICE(INTEL, 0x54FF), (kernel_ulong_t)&ufs_intel_adl_hba_vops }, { PCI_VDEVICE(INTEL, 0x7E47), (kernel_ulong_t)&ufs_intel_mtl_hba_vops }, { PCI_VDEVICE(INTEL, 0xA847), (kernel_ulong_t)&ufs_intel_mtl_hba_vops }, + { PCI_VDEVICE(INTEL, 0x7747), (kernel_ulong_t)&ufs_intel_mtl_hba_vops }, <--- here { } /* terminate list */ }; MTL is Meteor Lake. The abbreviation is not unheard of in commit messages. A web search for Intel MTL brings up the answer. And there is this earlier patch to the same code: commit 4049f7acef3eb37c1ea0df45f3ffc29404f4e708 Author: Adrian Hunter <adrian.hunter@intel.com> Date: Mon Apr 4 08:50:38 2022 +0300 scsi: ufs: ufs-pci: Add support for Intel MTL Add PCI ID and callbacks to support Intel Meteor Lake (MTL). Link: https://lore.kernel.org/r/20220404055038.2208051-1-adrian.hunter@intel.com Cc: stable@vger.kernel.org # v5.15+ Reviewed-by: Avri Altman <avri.altman@wdc.com> Reviewed-by: Bart Van Assche <bvanassche@acm.org> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
On 6/13/23 21:54, Adrian Hunter wrote: > On 13/06/23 21:22, Bart Van Assche wrote: >> On 6/13/23 10:03, Adrian Hunter wrote: >>> Add PCI ID to support Intel Arrow Lake, same as MTL. >> >> The patch looks good to me but the "same as MTL" text in the patch description looks confusing to me? > > The code change is using the same driver data as MTL: [ ... ] Information about whether only the MTL code is reused or whether the UFS controller is identical to the MTL UFS controller would be welcome. Anyway, feel free to add: Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Adrian,
> Add PCI ID to support Intel Arrow Lake, same as MTL.
Applied to 6.5/scsi-staging, thanks!
On Tue, 13 Jun 2023 20:03:27 +0300, Adrian Hunter wrote: > Add PCI ID to support Intel Arrow Lake, same as MTL. > > Applied to 6.5/scsi-queue, thanks! [1/1] scsi: ufs: ufs-pci: Add support for Intel Arrow Lake https://git.kernel.org/mkp/scsi/c/51031cc3f903
diff --git a/drivers/ufs/host/ufshcd-pci.c b/drivers/ufs/host/ufshcd-pci.c index 38276dac8e52..cf3987773051 100644 --- a/drivers/ufs/host/ufshcd-pci.c +++ b/drivers/ufs/host/ufshcd-pci.c @@ -599,6 +599,7 @@ static const struct pci_device_id ufshcd_pci_tbl[] = { { PCI_VDEVICE(INTEL, 0x54FF), (kernel_ulong_t)&ufs_intel_adl_hba_vops }, { PCI_VDEVICE(INTEL, 0x7E47), (kernel_ulong_t)&ufs_intel_mtl_hba_vops }, { PCI_VDEVICE(INTEL, 0xA847), (kernel_ulong_t)&ufs_intel_mtl_hba_vops }, + { PCI_VDEVICE(INTEL, 0x7747), (kernel_ulong_t)&ufs_intel_mtl_hba_vops }, { } /* terminate list */ };
Add PCI ID to support Intel Arrow Lake, same as MTL. Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> --- drivers/ufs/host/ufshcd-pci.c | 1 + 1 file changed, 1 insertion(+)